Commit graph

864 commits

Author SHA1 Message Date
Ravi Kumar Kempapura Srinivasa
1bc6bf6236 Use gray tiles and state-balls for the entire branch of empty BpNode
The node state is recursively calculated in case the node contains only BpNodes as its children and are empty. The gray tiles and state-balls are used for the entire branch if the children are empty.
2020-05-11 11:45:33 +02:00
Ravi Kumar Kempapura Srinivasa
6cc5eb8e74 Check recursively for Empty BpNodes
In BpNode::recalculateState() the BpNode needs to be recursively checked if its children is empty using BpNode::isEmpty() instead of BpNode::hasChildren().
2020-05-11 11:45:27 +02:00
Ravi Kumar Kempapura Srinivasa
e19612bd4a Extend abstract isEmpty() method to check for empty nodes in child nodes
We need to check recurively whether the BP Nodes contatin only child BpNodes which are empty and set the entire tree to state NODE_EMPTY state in this case.
2020-05-11 11:45:17 +02:00
Ravi Kumar Kempapura Srinivasa
51c7fdf6c9 Fix 'Trying to access a missing business process node <$name>'
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.
2020-05-11 11:45:05 +02:00
Ravi Kumar Kempapura Srinivasa
d8567896f2 Fix 'missing node' errors for empty child nodes
Before the child empty nodes where set to missing nodes by BpNode::isMissing().

This has been corrected in this fix by checking if whether a child node is an empty node or not.
2020-05-11 11:44:55 +02:00
Ravi Kumar Kempapura Srinivasa
233e9758fa Show gray tiles and gray state badges for empty states
New tiles and state badges that are of color gray is introduced for empty nodes.
2020-05-11 11:44:50 +02:00
Ravi Kumar Kempapura Srinivasa
7de814a4af Set state to NODE_EMPTY in case of empty nodes
In case of empty nodes, the state is set to NODE_EMPTY now.
2020-05-11 11:44:41 +02:00
Ravi Kumar Kempapura Srinivasa
e533ff95f5 Introduce NODE_EMPTY state for empty nodes
An empty node state called `NODE_EMPTY` has been introduced with a value of 128 in class `Node`, and this state has been mapped to value *0* in structure `$stateToSortStateMap`.
2020-05-11 11:44:30 +02:00
Ravi Kumar Kempapura Srinivasa
32abce2529 Don't show state-badges for empty nodes
Before, the empty nodes were to be considered as missing nodes. Correspondingly, the counter for missing in BpNode::getStateSummary() was increased if an empty node is encountered.

Now, the empty nodes are not assumed as missing nodes and the counter for missing is not increased for this case.
2020-05-11 11:44:14 +02:00
Johannes Meyer
0892d1e90b Add L10n-update workflow 2020-04-30 11:19:42 +02:00
Johannes Meyer
6c4b75acb7
Merge pull request #273 from Icinga/fix/php74-compat
Fix PHP 7.4 compatibility
2020-02-27 13:25:50 +01:00
Johannes Meyer
d2d64365b6 php-diff: Don't use curly braces for string offset access 2020-02-27 10:41:54 +01:00
Eric Lippmann
a06fba34b3 Remove abstract function Node::__construct() 2020-02-27 10:08:16 +01:00
[.::MDT::.]
df29918a75 Update 81-History.md
fix typo
2020-02-26 15:10:20 +01:00
Ravi Kumar Kempapura Srinivasa
f5166f4348 Fix 'vsprintf(): Too few arguments' unexisting imported node exception
If the imported node does not exist, no arguments is  passed to BpConfig::addError() by ImportedNode::createFailedNode(). Added 'if' condition in BpConfig::addError() in case no arguments are passed to vsprintf.

refs #234
2020-02-26 15:09:17 +01:00
Ravi Kumar Kempapura Srinivasa
1278480b6e Fix 'vsprintf(): Too few arguments' in ProcessController::showAction()
Before, we called printf twice because BpConfig::addError()
already makes use of printf. The exception only occured for
nodes that have a percent sign (%) in their name.

fixes #234
2020-02-26 15:09:17 +01:00
mdkamijo
3ffbce0709
Make it possible to delete imported nodes (#248)
It is possible to import process nodes from other processes. But there
are no way, via the GUI, to remove the imported process nodes from the
current process/process node.
This commit makes it possible to remove imported process nodes, no matter
where which process they comes from.
2020-02-26 14:53:34 +01:00
Eric Lippmann
5395b42bab Fix URL param overrides upon rendering
Before, we used setParams() instead of with() to populate the parameters
which is especially problematic with imported nodes where the config
paramter got overriden for every subsequent node.

fixes #228
2020-02-26 14:18:40 +01:00
Eric Lippmann
125bf37ba8 Fix superfluous base target overrides
* Fix drill down of the tile/tree action icon links
* Set base target only on parent containers

This also fixes the dashboard integration where we only override the
base target of the div.tiles containers.

fixes #243
2020-02-26 14:17:39 +01:00
Johannes Meyer
4e6e1f0819 Node: Add __unbound__ parent node in getPaths() if there are no parents
fixes #245
2020-02-26 13:47:24 +01:00
Johannes Meyer
3772950f6e
Merge pull request #262 from Icinga/bugfix/grey-out-triangles-242
Add animations for breadcrumbs on impact
2020-02-26 13:14:36 +01:00
Johannes Meyer
9835dc9c03
Merge pull request #264 from Icinga/fix/check-command-handling-256
ProcessCommand: handle errors as UNKNOWN
2020-02-26 12:02:08 +01:00
Johannes Meyer
cb1cd24bfe de_DE: Avoid anglicisms
resolves #257
2020-02-26 12:00:15 +01:00
Yonas Habteab
1397c8a7af ProcessCommand:handle some other errors as UNKONWN
fixes #256
2020-02-26 10:23:30 +01:00
Johannes Meyer
27f1c41a42
Merge pull request #267 from Icinga/github-lint-tests
Add PHP action workflow
2020-02-26 10:17:43 +01:00
Johannes Meyer
144bcdf852 Remove space after reference operators 2020-02-26 09:19:31 +01:00
Johannes Meyer
8333846003 Add PHP action workflow 2020-02-26 09:13:59 +01:00
Feu Mourek
3bf808bfb6 Fix the delay 2020-02-25 16:26:18 +01:00
Feu Mourek
467fd70d41 Fix hover being blue 2020-02-25 16:11:01 +01:00
Yonas Habteab
09cb5ef6fe ProcessCommand: handle error as UNKNOWN
fixes #256
2020-02-25 16:04:40 +01:00
Feu Mourek
37a429b3ec Add animations for breadcrumbs on impact
refs #242
2020-02-25 14:52:32 +01:00
Eric Lippmann
a2309c4786
Merge pull request #255 from Icinga/new-cli-options-and-display-name-usage
New CLI options and display name usage
2020-02-06 09:43:59 +01:00
Eric Lippmann
a2854e8cf4 Use display_name as alias for host and service nodes 2020-02-05 15:01:22 +01:00
Dominik Seidel
8ef1dfcbdc CLI: Add options --downtime-is-ok and --ack-is-ok 2020-02-05 15:01:22 +01:00
Dominik Seidel
1414e76d94 CLI: Add options --blame and --root-cause 2020-02-05 15:01:22 +01:00
Johannes Meyer
8ee87ec1f6 css: Remove mix-blend-mode instruction 2019-12-12 14:46:30 +01:00
Johannes Meyer
137541eb62 travis: Fix invalid definitions for allowed failures
fixes #249
2019-11-14 12:07:13 +01:00
Johannes Meyer
f13145f43b BpUploadForm: Properly adjust the success url 2019-11-04 16:08:28 +01:00
Johannes Meyer
f579cc123f module.js: Use always instead of complete on jqXHR objects
`complete` is deprecated since jQuery 1.8 and now removed since
icingaweb2 upgraded to v3.
2019-07-15 12:44:56 +02:00
Johannes Meyer
845b9f9ddc sortable.js: Use substring instead of startsWith on strings
IE11 doesn't support startsWith yet

fixes #240
2019-07-15 10:58:51 +02:00
Johannes Meyer
176643472e Update issue templates 2019-04-15 08:17:42 +02:00
Johannes Meyer
c6f52063cf
Delete ISSUE_TEMPLATE.md 2019-04-15 08:16:26 +02:00
Johannes Meyer
7ab27ec783 Add issue templates 2019-04-15 08:16:10 +02:00
ignasr
db57295ab2 docs: fix wrong tag used in installation examples (#230)
doc: remove unused variables in installation examples
2019-04-12 13:05:31 +02:00
Johannes Meyer
73ad4a25dd Merge branch 'release/2.2.0' 2019-03-04 15:49:12 +01:00
Johannes Meyer
72f1a88f5a module.info: Add the ipl as dependency
And fix the version requirement syntax while we're at it.
2019-03-04 15:20:00 +01:00
Johannes Meyer
25ccc21f2a changelog: Mention the new dependency on the ipl 2019-03-04 15:12:22 +01:00
Johannes Meyer
b31cd6076b doc: Add changelog for 2.2.0 2019-03-01 13:16:21 +01:00
Johannes Meyer
7215ea9505 module.info: Raise version to 2.2.0 2019-03-01 12:43:35 +01:00
Johannes Meyer
61dc23fa10 locale: Update german translation 2019-03-01 12:43:16 +01:00