upstream/icingaweb2-module-businessprocess
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-businessprocess.git synced 2026-01-26 22:12:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix superfluous base target overrides

Browse source 
* Fix drill down of the tile/tree action icon links
* Set base target only on parent containers

This also fixes the dashboard integration where we only override the
base target of the div.tiles containers.

fixes #243
This commit is contained in:
Eric Lippmann 2020-02-26 09:30:28 +01:00 committed by Johannes Meyer
parent 4e6e1f0819
commit 125bf37ba8
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
library/Businessprocess/Renderer/TileRenderer.php
View file

@ -19,7 +19,7 @@ class TileRenderer extends Renderer
'div',
[
'class' => ['sortable', 'tiles', $this->howMany()],
'data-base-target' => '_next',
'data-base-target' => '_self',
'data-sortable-disabled' => $this->isLocked() ? 'true' : 'false',
'data-sortable-data-id-attr' => 'id',
'data-sortable-direction' => 'horizontal', // Otherwise movement is buggy on small lists

6
library/Businessprocess/Renderer/TileRenderer/NodeTile.php
View file

@ -59,8 +59,7 @@ class NodeTile extends BaseHtmlElement
$this->actions = Html::tag(
'div',
[
'class' => 'actions',
'data-base-target' => '_self'
'class' => 'actions'
]
);
@ -166,7 +165,6 @@ class NodeTile extends BaseHtmlElement
$link = Html::tag('a', ['href' => $url, 'data-base-target' => '_next'], $node->getAlias());
} else {
$link = Html::tag('a', ['href' => $url], $node->getAlias());
$link->getAttributes()->add('data-base-target', '_self');
}
return $link;
@ -181,7 +179,6 @@ class NodeTile extends BaseHtmlElement
$this->actions()->add(Html::tag(
'a',
[
'data-base-target' => '_self',
'href' => $url->with('mode', 'tile'),
'title' => mt('businessprocess', 'Show tiles for this subtree')
],
@ -189,7 +186,6 @@ class NodeTile extends BaseHtmlElement
))->add(Html::tag(
'a',
[
'data-base-target' => '_next',
'href' => $url->with('mode', 'tree'),
'title' => mt('businessprocess', 'Show this subtree as a tree')
],