17579 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Bartlomiej Plotka	ccf503efe6	Merge pull request #18629 from prometheus/owilliams/flakefix ... tsdb: fix init race that lets initialized() return true before maxTime is set	2026-05-18 14:21:59 +02:00
Bartlomiej Plotka	9a7d46e8b9	Merge pull request #18714 from prometheus/386flakiness ... tests: split 32bit x86 tests to a separate job with parallel=1	2026-05-18 13:33:33 +02:00
bwplotka	a987aef460	tests: split 32bit x86 tests to a separate job with parallel=1 ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2026-05-18 12:07:18 +01:00
Arve Knudsen	43e5fc6a24	perf(tsdb): inline oversize-chunk check in populateChunksFromIterable (#18699) ... The oversize-chunk trigger introduced in #18692 was implemented as a closure defined inside the per-sample loop in populateChunksFromIterable and invoked once at the `if` condition. Replace it with a plain conditional and hoist `len(currentChunk.Bytes())` out of the switch so the two encoding cases don't repeat the same expression. The new shape preserves the original `||` short-circuit: the size check is only evaluated when neither the encoding nor the start-timestamp capability forces a new chunk, which also keeps `currentChunk` non-nil at the point of read. `gcflags=-m=2` reports the closure body inlined and the symbol table shows no separate `func1` symbol, yet benchstat shows a measurable speedup. The most likely explanation: the closure body inlines, but the `funcval` struct (capturing `currentChunk` and `currentValueType`) is still stack-constructed each iteration — invisible to escape analysis, but a real per-iteration cost in a hot loop. Benchmark, `go test -count=6 -benchmem -bench=BenchmarkQuerierSelectWithOutOfOrder -benchtime=5s -run=^$ ./tsdb/`, Intel Xeon Platinum 8280 @ 2.70 GHz (linux/amd64), 1M-series head, query selectivity varies: │ main │ optimized │ │ sec/op │ sec/op vs base │ Head/1of1000000-16 301.5m ± 4% 257.0m ± 4% -14.74% (p=0.002 n=6) Head/10of1000000-16 305.6m ± 3% 260.4m ± 2% -14.80% (p=0.002 n=6) Head/100of1000000-16 303.9m ± 2% 259.7m ± 2% -14.54% (p=0.002 n=6) Head/1000of1000000-16 303.8m ± 2% 267.0m ± 2% -12.13% (p=0.002 n=6) Head/10000of1000000-16 318.1m ± 1% 278.9m ± 8% -12.33% (p=0.002 n=6) Head/100000of1000000-16 364.1m ± 7% 352.8m ± 4% ~ (p=0.065 n=6) Head/1000000of1000000-16 1.115 ± 2% 1.089 ± 26% ~ (p=0.394 n=6) geomean 377.8m 337.3m -10.71% allocs/op and B/op unchanged. The two largest-selectivity cases trend faster but are dominated by the per-sample append cost so the relative delta is smaller and lost in variance. `TestChunkQuerier_OverlappingInOrderAndOOOChunks` continues to exercise the overflow path. ```release-notes NONE ``` Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2026-05-15 11:40:31 +00:00
Julius Volz	49cf97be7e	Merge pull request #18658 from officialasishkumar/fix-autocomplete-label-value-escaping ... ui: escape label values in PromQL autocomplete	2026-05-15 07:45:48 +02:00
George Krajcsovits	8a9f4ff440	fix(tsdb): chunk overflow on ooo query (#18692) ... * fix(tsdb): chunk overflow on ooo query Protect against and fix overflow of chunks with more than 2^16-1 samples in case we're recoding chunks due to for example in-order and ooo samples overlap during compaction or query. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2026-05-14 22:22:52 +02:00
Asish Kumar	a21f58c2c0	test: expect label value completion apply text ... Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>	2026-05-14 22:13:03 +05:30
Asish Kumar	0254e010b3	Address PromQL autocomplete review feedback ... Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>	2026-05-14 22:11:04 +05:30
Asish Kumar	7c6bab8c58	ui: escape label values in PromQL autocomplete ... Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>	2026-05-14 22:11:04 +05:30
Arve Knudsen	cf4505c6cd	tsdb: skip entire stripes in mmapHeadChunks via per-stripe ready count (#18541) ... * tsdb: extract stripeSeries.refStripe helper Extract the repeated ref-to-stripe-index calculation into a method on stripeSeries, replacing five inline copies that used two different casting styles (int and uint64). The helper computes with uint64 internally so it is correct on 32-bit architectures. * tsdb: skip entire stripes in mmapHeadChunks via per-stripe ready count Add a per-stripe mmapReady counter to stripeSeries that tracks how many series in each stripe have headChunkCount >= 2 (i.e., are ready for mmapping). mmapHeadChunks skips stripes where the counter is zero, avoiding the RLock and map iteration entirely. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2026-05-14 18:24:56 +02:00
Bartlomiej Plotka	39580d86a1	Merge pull request #18279 from ridwanmsharif/feature/issue-14763-start-timestamp-synthesis ... scrape: Add start timestamp synthesis for cumulative metrics in the scrape path.	2026-05-14 12:40:31 +02:00
bwplotka	3ade1a7f94	add todo && gofumpt ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2026-05-14 11:05:26 +01:00
bwplotka	47b2611e31	renamed confusing input param st->t ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2026-05-14 10:58:34 +01:00
bwplotka	b350ff5fc3	apply Krajo's comment about hist ST reset ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2026-05-14 10:56:03 +01:00
bwplotka	80d6652057	rename tests from the old naming ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2026-05-14 10:33:29 +01:00
bwplotka	e2fa91da2b	fix conflicts after rebase ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2026-05-14 10:28:51 +01:00
Bartlomiej Plotka	fe871f8404	Update docs/feature_flags.md ... Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	9c48b76128	chore: rebase on main and fix test failure	2026-05-14 10:28:11 +01:00
Ridwan Sharif	24fa72a8aa	chore: add validation test for ST storage ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	82ab4432d3	chore: fix staleness tracking condition in scrape append loop ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	8bcf91c370	scrape: clear synthesis state on failure and fix histogram copy ... - Clear stCache state in scrape loop when append fails for existing series. - Copy float histogram before storing in cache to avoid mutation. - Add test for state mutation on OOO failure. - Update docs to reflect behavior on failure. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	abf3726f8a	chore: add test to make sure staleness tracking is off when ref==0 ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	4485560a60	chore: make some notes/comments more clear ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	2fddc5890c	chore: add TODOs for improvements to st-synthesis) ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	5933a39a73	fix: reject out-of-order samples when start time synthesis is enabled during scrape ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	4920ce41ef	chore: address PR comments v2 ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	c53aa4a207	chore: simplify explicit ST setting ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	d7d7f03e57	chore: address PR comments ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	859cef301a	scrape: optimize reference assignment and reduce memory allocations in st synthesis ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	8c026ee169	test: add benchmark for st synthesis ... Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Ridwan Sharif	cab74902a2	feat: Add start timestamp synthesis for cumulative metrics in the scrape path. ... Issue https://github.com/prometheus/prometheus/issues/14763 Note: Still a WIP for native histograms and summaries. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>	2026-05-14 10:28:11 +01:00
Bartlomiej Plotka	e793b26713	Merge pull request #18684 from roidelapluie/roidelapluie/revert-duration-expr-stable ... Revert "PromQL: Promote duration expressions as stable"	2026-05-13 11:22:08 +02:00
Julien Pivotto	dd406b3df5	web/api/v1: enable ExperimentalDurationExpr in translate AST tests ... Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2026-05-13 10:52:59 +02:00
Julien Pivotto	502e31a82f	promql: protect min(), max(), step(), and range() duration exprs with feature flag ... min(), max(), step(), and range() in duration expression context were not guarded by the ExperimentalDurationExpr feature flag, unlike the binary operators (+, -, *, /, %, ^). Add the missing experimentalDurationExpr() calls in both offset_duration_expr and duration_expr grammar rules. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2026-05-13 09:59:50 +02:00
Julien Pivotto	7b29b912e3	Revert "PromQL: Promote duration expressions as stable" ... This reverts commit 1463a5bb5a. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2026-05-13 09:59:50 +02:00
Julius Volz	ce93018f4e	Merge pull request #18682 from flying-musk/fix-y-axis-tick-precision ... ui: improve y-axis tick precision	2026-05-13 08:00:14 +02:00
Flying Musk	b69f991b57	ui: improve y-axis tick precision ... Signed-off-by: Flying Musk <musk.flying@gmail.com>	2026-05-12 16:11:03 -07:00
Owen Williams	9ec9b1e3c6	Comments to explain what's going on ... Signed-off-by: Owen Williams <owen.williams@grafana.com>	2026-05-12 11:00:12 -04:00
Owen Williams	9e16c38214	Merge remote-tracking branch 'origin/main' into owilliams/flakefix	2026-05-12 10:42:09 -04:00
cui	54d4f527a0	textparse: fix NaN canonicalization check in OpenMetrics getFloatValue (#18399) ... * textparse: fix NaN canonicalization check in OpenMetrics getFloatValue * textparse: add tests for OpenMetrics summary NaN quantiles getFloatValue was testing p.exemplarVal instead of the parsed float when normalizing NaN to the canonical representation, so metric values that were NaN were not normalized correctly. Extend TestOpenMetricsParse with nansum summary lines and cmpopts.EquateNaNs in requireEntries so NaN float values compare equal after canonicalization. Signed-off-by: Weixie Cui <cuiweixie@gmail.com> Signed-off-by: cui <cuiweixie@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2026-05-12 15:45:59 +02:00
Joe Adams	63f2bf9b9a	Merge pull request #16088 from rlees85/ipv6-only-ec2-sd ... discovery: Allow EC2 Service Discovery to work with IPv6-only instances	2026-05-11 23:09:34 -04:00
renovate[bot]	a732c0793a	Update actions/upload-artifact action to v7 (#18674) ... Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2026-05-11 18:11:18 +02:00
renovate[bot]	2ac56b3285	Update actions/setup-node action to v6.4.0 (#18671) ... Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2026-05-11 18:10:52 +02:00
Bartlomiej Plotka	8da59ea03b	Merge pull request #18567 from ridwanmsharif/chore/staleness-diff-v2 ... scrape: fix staleness tracking for duplicate and out-of-order sample in AppenderV2	2026-05-11 17:45:34 +02:00
renovate[bot]	5cf214cf5e	Update actions/cache action to v5.0.5 (#18670) ... Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2026-05-11 17:40:29 +02:00
Bartlomiej Plotka	5c16439c34	Merge pull request #18675 from prometheus/superq/more_renovate ... Run Renovate twice a month	2026-05-11 17:06:02 +02:00
renovate[bot]	9ddc1fe475	Update github/codeql-action action to v4.35.4 (#18672) ... Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2026-05-11 13:59:23 +00:00
Vilius Pranckaitis	129ee0d317	PromQL: resets() function considers start timestamp resets (#18627) ... * PromQL: `resets()` function considers start timestamp resets Signed-off-by: vpranckaitis <vpranckaitis@gmail.com> * PR comment Signed-off-by: vpranckaitis <vpranckaitis@gmail.com> --------- Signed-off-by: vpranckaitis <vpranckaitis@gmail.com>	2026-05-11 15:50:36 +02:00
SuperQ	3b66ea611f	Run Renovate twice a month ... Increase the frequency of Renovate to twice a month to keep up various dependencies and avoid large drift. Signed-off-by: SuperQ <superq@gmail.com>	2026-05-11 15:30:25 +02:00
Bartlomiej Plotka	c591287db3	Merge pull request #18642 from prometheus/upgrade3.12 ... chore: Upgrade Go deps before v3.12.0-rc.0	2026-05-11 13:43:41 +02:00