upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-06-10 17:10:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

chore: add TODOs for improvements to st-synthesis)

Browse source 
Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
This commit is contained in:
Ridwan Sharif 2026-04-08 17:18:55 +00:00 committed by bwplotka
parent 5933a39a73
commit 2fddc5890c
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
scrape/scrape_append_v2.go
View file

@ -261,6 +261,7 @@ loop:
st = p.StartTimestamp()
}
// TODO(ridwanmsharif): Consider injecting a 0 value with the st == t here, instead of skipping an append.
if sl.synthesizeST && st == 0 {
st, val, h, fh, skipAppend, stCache = sl.checkAndSynthesizeStartTime(st, lset, ce, lastMFName, val, h, fh, t)
}

1
scrape/st_synthesis.go
View file

@ -26,6 +26,7 @@ import (
// It maps closely to OpenTelemetry's cumulative-to-delta conversion patterns,
// similar to what is done in the OpenTelemetry Collector's `metricstarttimeprocessor`.
// See https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/metricstarttimeprocessor.
// TODO(ridwanmsharif): Make this a struct usable by a go interface (see https://github.com/prometheus/prometheus/pull/18279#discussion_r3032221849).
type stCache struct {
f *floatSynthesis
h *histogramSynthesis