From 2fddc5890ccadab5688864cdacec08260ae1b2fa Mon Sep 17 00:00:00 2001 From: Ridwan Sharif Date: Wed, 8 Apr 2026 17:18:55 +0000 Subject: [PATCH] chore: add TODOs for improvements to st-synthesis) Signed-off-by: Ridwan Sharif --- scrape/scrape_append_v2.go | 1 + scrape/st_synthesis.go | 1 + 2 files changed, 2 insertions(+) diff --git a/scrape/scrape_append_v2.go b/scrape/scrape_append_v2.go index e723c52744..2c27845530 100644 --- a/scrape/scrape_append_v2.go +++ b/scrape/scrape_append_v2.go @@ -261,6 +261,7 @@ loop: st = p.StartTimestamp() } + // TODO(ridwanmsharif): Consider injecting a 0 value with the st == t here, instead of skipping an append. if sl.synthesizeST && st == 0 { st, val, h, fh, skipAppend, stCache = sl.checkAndSynthesizeStartTime(st, lset, ce, lastMFName, val, h, fh, t) } diff --git a/scrape/st_synthesis.go b/scrape/st_synthesis.go index ba7d140da5..f7f2c0f5ab 100644 --- a/scrape/st_synthesis.go +++ b/scrape/st_synthesis.go @@ -26,6 +26,7 @@ import ( // It maps closely to OpenTelemetry's cumulative-to-delta conversion patterns, // similar to what is done in the OpenTelemetry Collector's `metricstarttimeprocessor`. // See https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/metricstarttimeprocessor. +// TODO(ridwanmsharif): Make this a struct usable by a go interface (see https://github.com/prometheus/prometheus/pull/18279#discussion_r3032221849). type stCache struct { f *floatSynthesis h *histogramSynthesis