Commit graph

77727 commits

Author SHA1 Message Date
Ferdinand Thiessen
c84c256261
fix: Adjust preview for view-only shares
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-28 15:52:27 +01:00
Joas Schilling
988b6002ed
Merge pull request #48921 from nextcloud/ci/psalm/imagick-extension
ci(psalm): Add missing imagick extension
2024-10-28 15:49:51 +01:00
Richard Steinmetz
2a437b4305
Merge pull request #48943 from nextcloud/feat/photo-cache-webp
feat: Allow WebP content type in PhotoCache
2024-10-28 14:33:55 +01:00
Ferdinand Thiessen
98cf1085f6
Merge pull request #48871 from nextcloud/fix/app-store-reactivity
fix(app-store): Update update count in navigation
2024-10-28 14:11:15 +01:00
Miguel Sánchez de León Peque
f307ed8597
feat: Allow WebP content type in PhotoCache
Signed-off-by: Miguel Sánchez de León Peque <peque@ieco.io>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-10-28 13:43:01 +01:00
Kate
d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password 2024-10-28 13:26:55 +01:00
Kate
8b5e1bac90
Merge pull request #48918 from nextcloud/fix/files_sharing/cleanup-error-messages 2024-10-28 12:47:12 +01:00
yemkareems
34b07ace95
fix: crypto made inline for constructor and decrypt error handled in exception
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 16:43:24 +05:30
nextcloud-command
955f5914c0 chore(assets): Recompile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-10-28 11:13:09 +00:00
yemkareems
3fd16de636
fix: crypto made inline for constructor and decrypt error handled in exception
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 16:32:57 +05:30
Ferdinand Thiessen
bcaf95425a fix(app-store): Update update count in navigation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-28 12:01:58 +01:00
Kate
e8dbf022c9
Merge pull request #48919 from nextcloud/fix/settings/userid-dependency-injection 2024-10-28 11:44:16 +01:00
Ferdinand Thiessen
86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring
fix(apps-store): Fix exception on generating preview url for installed app screenshot
2024-10-28 11:32:15 +01:00
yemkareems
79b1122749
fix: use Icrypto in place of Cypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:49:05 +05:30
yemkareems
a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:04:11 +05:30
Kate
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +01:00
Kate
2eaa9f79b4
Merge pull request #48917 from nextcloud/fix/dav/view-only-check 2024-10-28 10:19:09 +01:00
provokateurin
3a39f4a65e
ci(psalm): Add missing imagick extension
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 09:14:22 +01:00
provokateurin
aacb3ddc1e
fix(files_sharing): Cleanup error messages
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 09:07:41 +01:00
Joas Schilling
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-28 08:46:31 +01:00
Claudio Cambra
5969b4bea8
fix(appsmanagement): Fix exception on generating preview url for screenshots
Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-10-28 08:29:16 +01:00
provokateurin
35d614057c
fix(settings): Fix dependency injection
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 08:14:17 +01:00
provokateurin
bb7841998b
fix(dav): Cleanup view-only check
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 08:02:42 +01:00
yemkareems
505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 11:22:36 +05:30
Nextcloud bot
e6c11e1be0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-28 00:20:34 +00:00
Nextcloud bot
75e9be595b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-27 00:22:10 +00:00
Nextcloud bot
c3ac8bf89a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-26 00:20:19 +00:00
Joas Schilling
7b36547f13
Merge pull request #48898 from nextcloud/fix/files--list-header-button-title
fix(files): add title for files list table header button
2024-10-25 22:50:48 +02:00
Grigorii K. Shartsev
4010f7e64b chore(assets): Recompile assets
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 18:14:14 +02:00
Grigorii K. Shartsev
f7498d0069 fix(files): add title for files list table header button
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 18:06:33 +02:00
Josh
102d73fbbe
Merge pull request #48895 from nextcloud/jtr/chore-bug-report-logs
chore: Clarify log entry requirements in bug report form
2024-10-25 10:21:09 -04:00
Josh
ac6c85c838
chore: Clarify log entry requirements in bug report form
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-10-25 09:50:17 -04:00
Daniel
4f6667a9c9
Merge pull request #48892 from nextcloud/update-stale-bot-configuration
chore: don't remove needs info label when commenting on a stale issue
2024-10-25 15:19:01 +02:00
Joas Schilling
631f6d482e
Merge pull request #48884 from nextcloud/bugfix/noid/allow-to-force-db-throttler
feat(bruteforce): Allow forcing the database throttler
2024-10-25 15:03:27 +02:00
Grigorii K. Shartsev
92179c8175
Merge pull request #48625 from nextcloud/fix/files--handle-empty-view-with-error
fix(files): handle empty view with error
2024-10-25 17:27:04 +05:00
Daniel Kesselberg
31eed47868
chore: don't remove needs info label when commenting on a stale issue
1) Removing the "needs info" label when someone comments on a stale issue seems incorrect.
2) By default, the stale action removes the "stale" label upon commenting. However, the labels-to-remove-when-unstale option triggers an additional API request to remove the "stale" label, which was already removed in the previous API call.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-10-25 14:14:35 +02:00
Grigorii K. Shartsev
ed9fdbad6e chore(assets): Recompile assets
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 13:19:25 +02:00
Grigorii K. Shartsev
18d52323dd refactor(files): migrate to @nextcloud/sharing
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 13:01:43 +02:00
Grigorii K. Shartsev
080a8c7f1c fix(files): handle empty view with error
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 13:01:43 +02:00
Grigorii K. Shartsev
2696715d90 chore(files): migrate davUtils to TS
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 13:01:30 +02:00
Nextcloud bot
7723faf51a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-25 00:20:05 +00:00
F. E Noel Nfebe
ccd14f3a65
Merge pull request #48882 from nextcloud/safety-net-null-check
refactor(ShareApiController): Check for null and empty strings with e…
2024-10-25 00:53:22 +02:00
Joas Schilling
6854af0cc4
feat(bruteforce): Allow forcing the database throttler
Using the database is most likely worse for performance, but makes investigating
issues a lot easier as it's possible to look directly at the table to see all
logged remote addresses and actions.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-24 22:04:41 +02:00
fenn-cs
227b8462d8 refactor(ShareApiController): Check for null and empty strings with empty()
Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-24 18:37:42 +01:00
F. E Noel Nfebe
bc6a3e8159
Merge pull request #48381 from nextcloud/fix/48012/fix-share-email-send-mail-share
fix(ShareAPI): Send mails for mail shares by default
2024-10-24 18:28:12 +02:00
fenn-cs
e2d2a17810 fix(ShareAPI): Send mails for mail shares by default
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-24 14:41:07 +01:00
Ferdinand Thiessen
4176708797
Merge pull request #48874 from nextcloud/jtr/setup-checks-heading
fix(settings): Change "setup warnings" -> "setup checks" in Overview
2024-10-24 13:09:18 +02:00
Julien Veyssier
67fbce5407
Merge pull request #48863 from nextcloud/fix/noid/textprocessing-list-types
[TextProcessing] Fix: Also list types that are available in task processing
2024-10-24 12:51:55 +02:00
Julien Veyssier
5362486ca9
feat(textprocessing): factorize taskProcessingCompatibleTaskTypes
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-24 12:34:33 +02:00
Julien Veyssier
54cebc2136
fix(textprocessing): also list types that are available in task processing
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-24 11:28:16 +02:00