upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-12 10:10:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 20

Merge pull request #48882 from nextcloud/safety-net-null-check

Browse source 
refactor(ShareApiController): Check for null and empty strings with e…
This commit is contained in:
F. E Noel Nfebe 2024-10-25 00:53:22 +02:00 committed by GitHub
commit ccd14f3a65
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
apps/files_sharing/lib/Controller/ShareAPIController.php
View file

@ -661,13 +661,10 @@ class ShareAPIController extends OCSController {
// Handle mail send
if (is_null($sendMail)) {
// Define a default behavior when sendMail is not provided
if ($shareType === IShare::TYPE_EMAIL && strlen($shareWith) !== 0) {
// For email shares, the default is to send the mail
$share->setMailSend(true);
} else {
// For all other share types, the default is to not send the mail
$share->setMailSend(false);
}
// For email shares with a valid recipient, the default is to send the mail
// For all other share types, the default is to not send the mail
$allowSendMail = ($shareType === IShare::TYPE_EMAIL && $shareWith !== null && $shareWith !== '');
$share->setMailSend($allowSendMail);
} else {
$share->setMailSend($sendMail === 'true');
}