upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-21 14:23:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 15
83004 commits 874 branches 1195 tags 8.3 GiB
Commit graph

6136 commits

Author SHA1 Message Date
Robin Appelman
0001c22668 test: add test for nested cache jail unjailedroot 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-13 18:29:00 +02:00
Ferdinand Thiessen
6cf1870322
feat(FilenameValidator): allow to sanitize filenames 
Share the filename sanitizing with the OCP filename validator.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-13 14:14:17 +02:00
SebastianKrupinski
ebd80bc142 fix: check if properties exist before using them 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2025-05-12 15:44:07 -04:00
Kate
648745d524
Merge pull request #52634 from nextcloud/perf/share20/get-all-shares-in-folder 2025-05-08 16:24:21 +02:00
provokateurin
ae16a28758
perf(Share20): Add interface to query all shares in a folder without filtering by user 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-08 15:29:40 +02:00
Louis
1c518a291d
Merge pull request #52360 from nextcloud/artonge/fix/use_preview_api_for_blurhash_generation 2025-05-06 14:12:50 +02:00
Louis Chemineau
867be352f3
fix(blurhash): Use preview API to generate the previews 
This allows to benefit from all the checks done by the preview API.
This also use the newly introduced `cacheResult` argument to limit disk usage.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-05-05 11:13:31 +02:00
Joas Schilling
d46d2d1acf
test: Fix coding standards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-05 10:09:22 +02:00
Joas Schilling
10424f248b
test(comments): Make Comments test result output properly readable 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-05 09:38:02 +02:00
Joas Schilling
c24f5fb256
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-02 16:47:42 +02:00
Joas Schilling
b77011a918
test: Prepare more tests for PHPUnit 10 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-30 09:18:01 +02:00
Joas Schilling
553870d30a
fix(navigation): Fix default app entry registered as closure 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-25 14:47:33 +02:00
Ferdinand Thiessen
d86189adc5
Merge pull request #52299 from nextcloud/refactor/preview-tests 
refactor: Thumbnail Generator logging and tests
 2025-04-24 09:50:11 +02:00
nfebe
d980e69f74 refactor: Thumbnail Generator logging and tests 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-04-23 23:06:28 +01:00
Maxence Lange
743924ce4d fix(federation): allows equal signs in federation id 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2025-04-22 13:03:56 -01:00
F. E Noel Nfebe
25bc18c6dc
Merge pull request #52221 from nextcloud/feat/no-issue/add-logging-preview-generation 
feat: add logging to preview generation
 2025-04-22 12:37:49 +02:00
Arthur Schiwon
8410d67fc7
Merge pull request #52224 from nextcloud/bugfix/noid/dont-break-when-checking-if-too-long-user-exists 
fix(usermanager): Don't throw when checking if a too long user id is an existing user
 2025-04-17 16:55:02 +02:00
nfebe
6b89838cc2 feat: add logging to preview generation 
Signed-off-by: nfebe <fenn25.fn@gmail.com>
 2025-04-17 14:24:18 +01:00
Ferdinand Thiessen
8f8c11ad4e
fix(mail): use matching text color for primary elements 
when we use the default primary as background color we have to use the
default primary text color as well.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-04-17 11:51:46 +02:00
Benjamin Gaussorgues
9f666c2b73
feat(ip): add configurable IPv6 subnet for BFP and throttling 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-04-17 08:12:03 +02:00
Joas Schilling
775ca882f3
fix(usermanager): Don't throw when checking if a too long user id is an existing user 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-16 17:47:28 +02:00
Louis
f8391e60ce
Merge pull request #51020 from nextcloud/artonge/fix/transfer_ownership 2025-04-14 16:14:45 +02:00
Côme Chilliet
696e163ba2
Merge pull request #52086 from nextcloud/fix/cleanup-user-backends 
Cleanup user backends related methods
 2025-04-14 15:49:49 +02:00
Anna
9e0e53707f
Merge pull request #52085 from nextcloud/bugfix/noid/fix-cached-return-of-display-name 
fix(federation): Fix returning "no display name" after cache result
 2025-04-10 11:38:22 +02:00
Côme Chilliet
0cf4f3cc71
fix: Replace all usages of OC_User backend method calls by IUserManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-10 11:29:21 +02:00
Alexander Piskun
0a474e5ccd
Merge pull request #52050 from nextcloud/fix/noid/taskprocessing-appapi 
fix(taskprocessing): use the event for AppAPI to get list of AI providers
 2025-04-10 10:22:25 +03:00
Joas Schilling
d8744f84e8
fix(federation): Fix returning "no display name" after cache result 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-10 09:20:27 +02:00
skjnldsv
70218dc0a4 fix(files_sharing): fix share creation error handling 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-04-09 14:52:42 +00:00
Joas Schilling
8357469557
Merge pull request #52070 from nextcloud/test/noid/improve-test-output 
test: Improve comments manager test output in case of failure
 2025-04-09 16:08:19 +02:00
Oleksander Piskun
c23ab0d1f7 fix(taskprocessing): use the event for AppAPI to get list of AI providers 
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
 2025-04-09 15:47:48 +03:00
Joas Schilling
e2cd436205
test: Improve comments manager test output in case of failure 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-09 13:49:16 +02:00
Joas Schilling
6a3c53def3
fix(federation): Don't load the addressbook when resolving a cloud ID 
Instead we delay the lookup of the display name until it is actually used

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-09 10:52:03 +02:00
Joas Schilling
8358a7f769
Revert "refactor(RichObjectStrings): Only log error if key or value is not string in validator" 
This reverts commit fd156d3408.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-04-09 08:35:56 +02:00
John Molakvoæ
dd32639fa9
Merge pull request #51838 from nextcloud/feat/cleanup-oc-util-methods 
Mark all methods of OC_Util as deprecated
 2025-04-08 21:47:31 +02:00
Kate
065a976bd5
Merge pull request #52014 from nextcloud/fix/fix-movie-preview-construct 
fix(preview): Fix constructor parameter name and default value
 2025-04-08 14:38:17 +02:00
provokateurin
fd156d3408
refactor(RichObjectStrings): Only log error if key or value is not string in validator 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-04-08 11:45:36 +02:00
Benjamin Gaussorgues
c4021c8d38
feat(ip): use larger IPv6 range by default 
Some providers assign `/48` IPv6 blocks instead of `/64` so it sounds safer
to use this mask by default.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-04-08 10:08:28 +02:00
Côme Chilliet
3ca690a9f3
fix(previews): Cleanup Movie provider code and remove deprecated static vars 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-08 09:53:02 +02:00
Côme Chilliet
b2100484c0 fix: Remove some call and references to deprecated OC_Util class 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-07 17:05:54 +02:00
Côme Chilliet
12d32ee2ea
Merge pull request #51836 from nextcloud/feat/cleanup-oc-util 
chore(legacy): Remove deprecated OC_Util::addScript and functions depending on it
 2025-04-03 12:26:57 +02:00
Christoph Wurst
5003467f98
fix(session): Only mark sessions of permanent tokens as app passwords 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2025-04-03 10:08:15 +02:00
Côme Chilliet
e467ea1c6a
chore(legacy): Remove deprecated OC_Util::addScript and functions depending on it 
Deprecated since 24, currently unused.
Sadly not all related functions were officially marked as deprecated,
 but all of them were unused.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-01 15:24:24 +02:00
Louis Chemineau
8fdf2a7eae fix: Transfer ownership with S3 as primary 
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-04-01 13:53:56 +02:00
Christoph Wurst
e655ffeb43
Merge pull request #50768 from nextcloud/perf/cron/delay-timedjob-checking 
perf(cron): Delay (re)checking timed jobs
 2025-03-31 17:31:44 +02:00
Joas Schilling
aee2f2df55
Merge pull request #51768 from nextcloud/techdebt/noid/prepare-phpunit10 
fix(phpunit10): Migrate away from PHPUnit at() calls
 2025-03-31 16:04:41 +02:00
Christoph Wurst
2395526e6c
perf(cron): Delay (re)checking timed jobs 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2025-03-31 13:21:29 +02:00
Côme Chilliet
d5ad9b86ef
Merge pull request #51676 from nextcloud/fix/add-getappversions-replacement 
Add OC_App::getAppVersions replacement in IAppManager
 2025-03-31 10:51:00 +02:00
Joas Schilling
522be60ff0
fix(phpunit): Remove some more withConsecutive calls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-31 09:43:22 +02:00
SebastianKrupinski
2de6d6b908 fix: add event status and participant status 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2025-03-28 03:48:48 -04:00
Julius Knorr
46f531adec test: Adapt tests to properly use valid email addresses 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2025-03-26 11:51:52 +01:00
Côme Chilliet
34d7a957e0
chore(tests): Adapt TemplateLayoutTest to constructor change 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-25 14:23:40 +01:00
John Molakvoæ
248d21a2b9
Merge pull request #51490 from nextcloud/castUsersCountToInt 
fix(database): Cast users count to integer
 2025-03-25 12:57:34 +01:00
Ferdinand Thiessen
254dd85664
fix(IFilenameValidator): correctly handle case insensitivity 
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-21 01:00:58 +01:00
Git'Fellow
18de9be0e2
fix(database): Cast users count to integer 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-03-20 12:00:57 +01:00
Côme Chilliet
aac391d466 chore: Move template functions out of legacy folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-20 10:54:50 +01:00
Côme Chilliet
a83cae1a0e fix: Remove multiple require_once calls for template functions 
Only require them when include the template file instead

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-20 10:54:50 +01:00
Hamza Mahjoubi
c9d9abd46e fix(cardav): only show useres from enabled addressBooks in contacts menu 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
 2025-03-17 11:56:34 +01:00
provokateurin
3c698c6553
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-12 14:52:32 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
34251c4375
fix(lookup-server): do not query data by default 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-11 14:26:47 +01:00
Côme Chilliet
eb597917f6
Merge pull request #51029 from nextcloud/fix/deprecate-oc-template-and-cleanup 
fix: Deprecate OC_Template, add proper template manager instead
 2025-03-10 16:20:45 +01:00
Julius Knorr
bb6b462690
Merge pull request #51130 from nextcloud/fix/credential-passwordless-auth 
fix: Do not build encrypted password if there is none
 2025-03-07 16:49:18 +01:00
Côme Chilliet
7d64c63acf chore: Adapt TemplateLayout tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-06 15:49:25 +01:00
Julius Knorr
777cd941dc
fix: Do not build encrypted password if there is none 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2025-03-06 09:31:29 +01:00
Côme Chilliet
2ef04bfb5d
Merge pull request #47686 from nextcloud/fix/move-email-logic-local-user-backend 
fix: Move login via email logic to local backend
 2025-03-04 18:21:57 +01:00
Arthur Schiwon
42d752f767
Merge pull request #51116 from nextcloud/enh/noid/nullable-range 
feat(AppFramework): extend range check to optional parameters
 2025-03-04 14:23:21 +01:00
Ferdinand Thiessen
3c4feff028
fix: Move login via email logic to local backend 
Backends can decide which names they accept for login,
e.g. with user_ldap you can configure arbitrary login fields.
This was a hacky approach to allow login via email,
so instead this is now only handled by the local user backend.

This also fixes some other related problems:
Other logic relys on `backend::get()` which was not handling email,
so e.g. password policy could not block users logged in via email
if they use out-dated passwords.
Similar for other integrations, as the user backend was not consistent with
what is a login name and what not.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-03 18:02:07 +01:00
provokateurin
8acfc0f0f2
refactor(TempManager): Simplify and unify implementations and remove legacy behavior 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-03-03 11:11:12 +01:00
Arthur Schiwon
6594d7d96d
feat(AppFramework): extend range check to optional parameters 
Now it also applies when a paramater is documtend with a pending |null,
but no further unionation is considered.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2025-02-27 19:49:04 +01:00
Côme Chilliet
001b12c482
Merge pull request #50999 from nextcloud/fix/move-away-from-oc-app 
fix: Replace OC_App calls by IAppManager
 2025-02-27 18:33:47 +01:00
Robin Appelman
0a77ba99a2
feat: support migrating an instance to sharding 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-25 17:52:40 +01:00
Côme Chilliet
d189ed3dd9 fix: Remove incorrect @throws annotations and move away from OC_App 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-24 17:48:34 +01:00
Côme Chilliet
e2a4649257 fix(tests): Adapt tests to appManager usage 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-24 17:48:34 +01:00
Ferdinand Thiessen
e3af27b280
refactor: convert sanitize account properties repair step to background job 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:16:28 +01:00
Ferdinand Thiessen
575222b5af
fix: Optimize repair step performance 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:16:28 +01:00
Ferdinand Thiessen
08d33a9f57
fix: validate account properties as a repair step 
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-24 15:16:27 +01:00
Johannes Endres
ae2cc23658 fix: Change UserAgent to *cloud 
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
 2025-02-19 18:51:08 +01:00
Côme Chilliet
ed9b47462f
Merge pull request #49648 from nextcloud/fix/clarify-app-manager-methods 
Clarify app manager method names
 2025-02-13 11:33:52 +01:00
Côme Chilliet
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:20 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:19 +01:00
Côme Chilliet
3289cbcbd3 fix: Fix UserTest to return valid configuration values 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-10 14:52:18 +01:00
John Molakvoæ
93c72f5675
Merge pull request #50660 from nextcloud/fix/mime-int 
fix: make sure we process mime extensions as string
 2025-02-06 16:13:27 +01:00
Ferdinand Thiessen
729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated 
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-06 11:58:24 +01:00
Ferdinand Thiessen
fbef47a5d7
fix(AccountManager): Sanitize social media handles 
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-02-06 11:58:24 +01:00
skjnldsv
6baafd82b6 fix: make sure we process mime extensions as string 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-05 12:35:41 +01:00
Louis Chemineau
b6c7c28585 fix: Exclude non accepted shares when computing access list 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-01-30 09:57:14 +01:00
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 20:08:46 +01:00
Ferdinand Thiessen
0a0f56282a
fix(sharing): Move permission validation to share manager 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 16:40:50 +01:00
Andy Scherzinger
b70654aeed
Merge pull request #48581 from hammer065/fix/issue-35936 
fix: Filter for folders in cleanup old preview job
 2025-01-27 16:06:40 +01:00
Joas Schilling
c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-01-27 12:46:15 +01:00
Dario Mehlich
8c309130cf
fix(preview): Filter for folders in cleanup old preview job 
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
 2025-01-27 10:16:08 +01:00
Ferdinand Thiessen
f33e9a96ae
Merge pull request #50273 from nextcloud/artonge/fix/metadata_field_search 
fix: Metadata field search
 2025-01-25 10:43:59 +01:00
Marcel Klehr
b0d1f2c489
Merge pull request #50331 from nextcloud/fix/perf/cache-avilable-taskt-types 
fix(taskprocessing): More caching
 2025-01-25 09:11:05 +01:00
Marcel Klehr
6f94ddc1d5 fix(taskprocessing): Fix tests 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2025-01-24 16:45:43 +01:00
Ferdinand Thiessen
eea91fa1ba
fix(TemplateLayout): core is not an app but the server itself 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-24 15:10:23 +01:00
Ferdinand Thiessen
31664b3edd
fix: Correctly return app id and app version for core styles and images 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-24 13:08:31 +01:00
provokateurin
dcb370ab62
Revert "fix(Share20\Manager): Ensure node is still accessible when checking share" 
This reverts commit c2ca99e2f6.

Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-01-24 09:41:14 +01:00
Benjamin Gaussorgues
b4e3eff078 feat(systemtags): add setting to block non admin to create system tags 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2025-01-22 20:07:24 +01:00
Josh
79ca27f6a6
test: fix periodic Test\Group\DatabaseTest::testSearchGroups failure 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2025-01-22 10:53:03 -05:00
Louis Chemineau
a635710117
fix: Metadata field search 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-01-20 14:41:55 +01:00
Ferdinand Thiessen
27ac8e0f78
Merge pull request #50214 from nextcloud/feat/show-time-diff-user 
feat(contacts): Show time difference for users in different timezones
 2025-01-20 14:39:00 +01:00
Ferdinand Thiessen
84f0fc88cc
feat(contacts): Show time difference for users in different timezones 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-16 18:10:04 +01:00
Côme Chilliet
626bc7220b
Merge pull request #50171 from nextcloud/enh/limit-ldap-user-count 
Limit ldap user count
 2025-01-16 17:25:01 +01:00
Christopher Ng
42d997bcd7 test: Update tests 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2025-01-15 15:50:43 -08:00
Côme Chilliet
db94aeb96e
chore(tests): Adapt tests to the countUsers refactor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-01-14 16:34:15 +01:00
Maxence Lange
bd4a154d64 feat(lexicon): configurable default value 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2025-01-14 10:36:07 -01:00
Robin Appelman
7b2cb2e3bc
test: update test for mountpoint numeric storage id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-13 18:09:29 +01:00
Richard Steinmetz
3dbdf3266c
feat(ocp): add calendar api to retrieve availability of attendees 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-01-13 10:12:31 +01:00
Joas Schilling
dd0f7f0bbf
Merge pull request #49888 from nextcloud/feat/ocp/meetings-api-requirements 
feat(ocp): calendar event builder api
 2025-01-08 11:48:53 +01:00
Côme Chilliet
99e0867f0a chore: Adapt tests to added constructor parameters 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-01-07 10:34:30 +01:00
Richard Steinmetz
80bc1c2d6c
feat(ocp): calendar event builder api 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2025-01-06 10:16:53 +01:00
Robin Appelman
16d0363937
fix: improve checks for moving shares/storages into other mounts 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-03 15:36:32 +01:00
Andy Scherzinger
a60f71bd93
Merge pull request #49727 from nextcloud/feat/make-tasks-types-toggleable 
Feat: make taskprocessing task types toggleable
 2024-12-18 20:08:28 +01:00
Jana Peper
75e64e2942 fix: egt rid of unused variable 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
 2024-12-18 18:32:34 +01:00
Jana Peper
b1d1badcf0 test: add explicitly enabled task type unit test 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
 2024-12-18 18:32:34 +01:00
Jana Peper
129af480ac test: add disabled task type unit test 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
 2024-12-18 18:32:34 +01:00
Arthur Schiwon
13fefc4612
feat(Navigation): emit dedicated event for loading additional entries 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-12-18 12:50:11 +01:00
Maxence Lange
815991741d fix(lexicon): renaming and minor fixes 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-12-13 11:08:20 -01:00
Maxence Lange
96586ba709 feat(config): implementation of lexicon 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-12-13 11:08:20 -01:00
Côme Chilliet
365ff40929 fix(tests): Adapt ManagerTest to change in Exception class used 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-12-12 15:39:48 +01:00
Julius Knorr
cba556d641
Merge pull request #48612 from nextcloud/fix/activity-log-for-favorites-in-dav 
add activity logging for favorites in dav
 2024-12-12 15:18:47 +01:00
John Molakvoæ
3baa91d842
Merge pull request #40394 from nextcloud/updater-change-mimetype-objectstore 2024-12-11 08:40:58 +01:00
skjnldsv
adf8a454dd feat(systemtags): add color support backend 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-12-06 10:19:42 +01:00
Robin Appelman
37199779de
fix: fix mimetype not being updated when changing file extention on object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-05 18:05:13 +01:00
grnd-alt
8d953aeb8d refactor(tags): move favorite event dispatching to tags.php 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
 2024-12-03 20:56:36 +01:00
Louis Chemineau
425e0c3660
test(View): Copy preserves content 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 18:29:32 +01:00
Louis Chemineau
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 17:04:44 +01:00
Joas Schilling
dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data 
fix(controller): Fix false booleans in multipart/form-data
 2024-11-28 14:46:16 +01:00
Joas Schilling
1909b981a4
fix(controller): Fix false booleans in multipart/form-data 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-11-28 12:18:30 +01:00
John Molakvoæ
379f575c25
Merge pull request #49493 from nextcloud/artonge/feat/pwd_confirmation_allow_set_period 2024-11-28 11:58:02 +01:00
Louis Chemineau
512f3caf57
test:(PasswordConfirmationMiddleware): Fix constructor call 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-11-28 11:05:10 +01:00
Christoph Wurst
1323e5bcb1
fix(migration): Decrypt ownCloud secrets v2 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-11-28 09:00:33 +01:00
provokateurin
c2ca99e2f6
fix(Share20\Manager): Ensure node is still accessible when checking share 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
c378e74017
feat(Share20\Manager): Return all shares on IShareOwnerlessMount 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
provokateurin
a978e0a806
fix(Share20\DefaultShareProvider): Return link shares in getSharesByPath() 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-11-25 10:27:31 +01:00
Louis Chemineau
f9cda54cbf
fix: Wrap partial cache entry in CacheEntry 
Because it is returned here: 7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)

And some implementation got stricter: df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-11-21 17:13:24 +01:00
Thomas Lehmann
e4c013d86d feat(Mailer): add "null" SMTP transport mode 
== Goal

Allow disabling mail delivery altogether.

== Usecase

If mails ought to be send by other means than rendering messages from
templates and sending them via SMTP-like protocols.

Example: listening to specific Nextcloud events and pass parameters to
a centralized (i.e. REST-based) API that sends e-mails.

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
 2024-11-19 11:32:39 +01:00
Thomas Lehmann
46d8a7333b feat(Mailer): implement caching 
Currently $this->instance is never set, so the code is no-op. This
brings back caching of the instance.

Caching broke with

   be7db1573d

   Swift to \Swift_Mailer as abstraction

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
 2024-11-19 11:32:39 +01:00
Maxence Lange
5b4f1904c0 feat(user-prefs): renaming to IUserConfig 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
6afc8552b7 feat(user-prefs): switching to NCU/ 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
7c04818c5c feat(user-prefs): iterator instead of array on search 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
e73513bdd1 fix(user-prefs): adding sensitive and indexed as flags 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Maxence Lange
65e24f7def feat(user-prefs): IUserPreferences 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-11-18 20:11:31 -01:00
Côme Chilliet
0718984bdf
Merge pull request #48675 from georglauterbach/master 
DNS: do not query CNAME if A succeeded already
 2024-11-14 11:43:32 +01:00
skjnldsv
158299b3d7 fix(profile): make sure the app cannot be disabled as it was in core 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-14 10:25:10 +01:00
SebastianKrupinski
7ebeed45bd feat: add iMip Request Handling 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
 2024-11-07 21:12:37 -05:00
Robin Appelman
b21c0265df
test: add some minimal testing for metadata storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-11-07 16:27:16 +01:00
Joas Schilling
c3c8b7e2a3
fix(richobjectstrings): Add missing placeholder validation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-11-06 21:31:41 +01:00
georglauterbach
387cd8b771
fix: do not query CNAME if A succeeded already 
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
 2024-11-06 20:21:38 +01:00
John Molakvoæ
3c4290631b
Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-local 2024-11-06 09:17:52 +01:00
John Molakvoæ
8fab143aa4
Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-fors 2024-11-06 08:54:40 +01:00
Daniel Calviño Sánchez
5ea5b2de84
fix: Handle exception when clearing previously removed two factor tokens 
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-11-05 11:14:05 +01:00
Daniel Calviño Sánchez
381a2aa627
fix: Clear pending two factor tokens also from configuration 
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-11-05 11:14:04 +01:00
Josh
e885e4f13d
fix(tests): Add IpAddressClassifier v6 zone ID test 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-11-04 09:31:48 -05:00
Josh
97421fb143
fix(tests): Add RemoteAddress v6 zone ID test 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-11-04 09:30:21 -05:00
Côme Chilliet
901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership 
fix: promote re-shares when deleting the parent share
 2024-11-04 10:09:58 +01:00
Benjamin Gaussorgues
79db082fe6 fix(users): improve recently active search 
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-10-30 07:53:10 +01:00
John Molakvoæ
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +01:00
Kate
d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password 2024-10-28 13:26:55 +01:00
Ferdinand Thiessen
86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring 
fix(apps-store): Fix exception on generating preview url for installed app screenshot
 2024-10-28 11:32:15 +01:00
yemkareems
a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 15:04:11 +05:30
Kate
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +01:00
Joas Schilling
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-28 08:46:31 +01:00
yemkareems
505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 11:22:36 +05:30
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
Joas Schilling
54c3aa3f99
fix(entity): Fix mapping of old/sub-types to actually supported database types 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-23 09:22:05 +02:00
Ferdinand Thiessen
2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support 
feat(AppFramework): Add full support for date / time / datetime columns
 2024-10-18 19:05:08 +02:00
Joas Schilling
882f91605b
fix(comments): Add test for email mention 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-18 07:39:41 +02:00
Ferdinand Thiessen
db94e10af0
fix: Prevent breaking change in IQueryBuilder 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:31:44 +02:00
Ferdinand Thiessen
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns 
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.

Similar the parameter types needed to be added.

`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.

Also added more tests, especially to make sure the mapper really serializes the values correctly.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:31:42 +02:00
Ferdinand Thiessen
9a7e1bb227
feat(DeclarativeSettings): Allow to implement value getter and setter directly in Form 
Instead of implementing the form class, a setter event listener and a getter event listener,
this allows to simply write a basic class that provides `getSchema`, `setValue` and `getValue` functions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-15 20:33:45 +02:00
Ferdinand Thiessen
b964e05312
Merge pull request #48673 from nextcloud/fix/null-label 
fix(share): Return empty string if no label is set
 2024-10-14 19:10:12 +02:00
Côme Chilliet
d6ba524263
fix: Use getRelativePath method to check if node is inside folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-14 17:23:29 +02:00
Ferdinand Thiessen
980ab1f56b
fix: Shipped apps should include the Nextcloud version in the cache buster 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-14 16:04:13 +02:00
Ferdinand Thiessen
2e4d3e4e75
fix(share): Return empty string if no label is set 
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-14 15:15:51 +02:00
Côme Chilliet
e584e9baf7 fix: Fix promotion of reshares from subsubfolders 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-14 11:58:47 +02:00
Côme Chilliet
3ee5bf6af1 fix(tests): Fix share tests to test new reshare promotion system 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-14 11:58:47 +02:00
Côme Chilliet
7e9bc7c8cf fix: Tidy up code for reshare deletion 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-14 11:58:47 +02:00
Luka Trovic
42181c2f49 fix: delete re-shares when deleting the parent share 
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-14 11:58:47 +02:00
Robin Appelman
7cb07bf306 test: add test for nested jail cross-storage move 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-10 15:16:12 +02:00
Kate
356f3ded52
Merge pull request #48610 from nextcloud/fix/usertrait/backend-initialization 2024-10-08 16:53:26 +02:00
provokateurin
902fb8f9fc
fix(UserTrait): Fix backend initialization 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-08 11:12:01 +02:00
provokateurin
f28e74b7a8
refactor(Storage): Make all parameter types strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:05 +02:00
provokateurin
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:11:56 +02:00
provokateurin
d1977b8d25
refactor(Stream\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:02:27 +02:00
Joas Schilling
e6cd1051da
fix(message): Fix logic of Mail test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-07 12:11:38 +02:00
Ferdinand Thiessen
3095a92551
Merge pull request #47896 from nextcloud/fix/resiliant-user-removal 
fix: Make user removal more resilient
 2024-10-07 11:33:07 +02:00
Daniel Kesselberg
6be00432b7
chore: always execute parse_url in preventLocalAddress 
This change should make it easier to spot wrong uses of the HTTP client on development setups where allow_local_remote_servers is usually true.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-10-01 18:00:47 +02:00
Ferdinand Thiessen
eb69e89fa5
chore: Drop unused legacy OC_Files 
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-28 13:18:40 +02:00
Ferdinand Thiessen
0f6760c810
feat(files): Make the files download action use WebDAV zip download 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-28 13:18:29 +02:00
Ferdinand Thiessen
16833aff86
fix: Make user removal more resilient 
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-26 20:48:37 +02:00
provokateurin
256a8d8903
test: Fix IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:48 +02:00
Côme Chilliet
280f6df66c
Merge pull request #32018 from nextcloud/cleanup/event/trashbin 
Port files trashbin events to IEventDispatcher/IEventListener
 2024-09-24 17:15:39 +02:00
Richard Steinmetz
19ad13571c
fix: gracefully parse non-standard trusted certificates 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2024-09-24 12:36:09 +02:00
Côme Chilliet
4adf5fd5b0
fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and unlink 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-24 10:37:38 +02:00
Côme Chilliet
af0b8fbd17
fix(tests): Fix tests now that trashbin listens to events properly 
Hooks are cleared in test bootstrap so switching to events activates
 them in tests.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 18:13:29 +02:00
Joas Schilling
82566c5479
fix(rtl): Make clear that the direction is based on language 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-23 17:00:07 +02:00
Mostafa Ahangarha
d94745201b
fix(rtl): Add unittest for language direction 
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
 2024-09-23 16:59:21 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface 
fix: Move storage constructor to specific interface
 2024-09-23 15:57:38 +02:00
Côme Chilliet
b8ab560bdd
fix(tests): Fix test to remove call to non-existing constructor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 14:50:43 +02:00
Louis Chemineau
22d5d29c01 fix(users): Don't crash if disabled user is missing in the database 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-23 10:40:38 +02:00
Andy Scherzinger
3009da3722
Merge pull request #43968 from exi/custom-binary-search-paths 
feat: make search path for BinaryFinder customizable.
 2024-09-20 19:14:17 +02:00
Git'Fellow
2ba3f7ed5c
Merge pull request #47782 from nextcloud/reworkShareExceptions 
fix(l10n): Rephrasing some exceptions to be translated
 2024-09-20 18:53:40 +02:00
Git'Fellow
dcbe8da2a6 fix(l10n): Rephrasing some exceptions to be translated 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-20 18:35:11 +02:00
Reno Reckling
ef7e857881
feat: make search path for BinaryFinder customizable. 
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue #43922

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Reno Reckling <e-github@wthack.de>
 2024-09-20 17:00:06 +02:00
Julius Knorr
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2024-09-20 14:53:34 +02:00
Ferdinand Thiessen
2a59f4fc95
Merge pull request #48220 from nextcloud/chore/remove-travis 
chore: Remove old travis related stuff
 2024-09-19 23:26:39 +02:00
Ferdinand Thiessen
9813cbf616
Merge pull request #48217 from nextcloud/chore/prepare-oc_repair-unit10 
chore: Cleanup and prepare `\OC\Repair\RepairMimeTypes` tests for PHPUnit 10
 2024-09-19 20:50:35 +02:00
Ferdinand Thiessen
7ae7f7fd12
chore: Remove old travis related stuff 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-19 20:16:29 +02:00
Ferdinand Thiessen
349a9fc5f6
chore: Cleanup and prepare \OC\Repair\RepairMimeTypes tests for PHPUnit 10 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-19 19:25:42 +02:00
Joas Schilling
4ccf62a224
chore: Cleanup and prepare some app tests for PHPUnit 10 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-19 18:19:32 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Ferdinand Thiessen
44c7248749
refactor(Collaboration): Use non-deprecated methods 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-19 00:35:20 +02:00
Côme Chilliet
989d708bd8
Merge pull request #48137 from nextcloud/enh/add-rich-object-formatter 
feat: Add OCP interface to format richtext into string
 2024-09-18 18:59:56 +02:00
Robin Appelman
1db3d94e1e test: put parent items into cache in tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 16:10:14 +02:00
Robin Appelman
74adaebf96 test: fix incorrect ltrim usage in test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-18 14:11:27 +02:00
John Molakvoæ (skjnldsv)
8fb64b886a
fix(settings): pronouns UsersControllerTest 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2024-09-18 13:30:33 +02:00
Côme Chilliet
b124f19777
fix(tests): Adapt tests to changes in RepairMimeTypes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 19:34:44 +02:00
Côme Chilliet
cfca7e7911
fix(tests): Fix most obvious errors in ObjectStore tests 
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 19:20:13 +02:00
Côme Chilliet
2bdc97741c
fix(tests): Fix Folder tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 19:19:08 +02:00
Côme Chilliet
9a9dd10c0c
fix(tests): Remove deprecated tests for ServerTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 17:48:01 +02:00
Stephan Orbaugh
f25acfb799
Merge pull request #47986 from cfiehe/fix_move_on_same_bucket 
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
 2024-09-17 16:35:19 +02:00
Côme Chilliet
b926df4730
fix: Adapt notifications and activity tests to new DI dependency 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-17 15:28:09 +02:00
provokateurin
8ca6fcace7
fix(Storage): Document getOwner() can return false 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-17 10:10:50 +02:00
Côme Chilliet
b9fb1db0f8
Merge pull request #48009 from nextcloud/fix/remove-references-to-deprected-storage-interface 
fix: Remove OCP\Files\Storage interface deprecated since version 9
 2024-09-16 20:50:38 +02:00
Robin Appelman
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback 
fix(Mailer): Fix sendmail binary fallback
 2024-09-16 18:18:14 +02:00
Côme Chilliet
a165d8f978
chore: Fix encryption test use statement 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:38 +02:00
Côme Chilliet
22822d5e9b
fix: Fix other uses of removed Storage interface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:11:36 +02:00
Côme Chilliet
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:10:48 +02:00
Robin Appelman
d9c5512878
Merge pull request #46140 from nextcloud/fix-nc-env-inclusion 
fix(config): Add missing handling for `envCache` in `getKeys()`
 2024-09-16 16:55:13 +02:00
Josh
87aa1267a8 fix(Mailer): Fix sendmail binary fallback 
feat: add debug logging to sendmail binary finder

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-09-16 15:20:29 +02:00
Robin Appelman
13088b745a
Merge branch 'master' into fix-nc-env-inclusion 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-16 15:13:29 +02:00
Christoph Fiehe
9597072ada perf(ObjectStoreStorage): Improve (slow) move on same object bucket 
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
 2024-09-16 15:11:09 +02:00
Ferdinand Thiessen
7fbd518452
feat: Make CheckServerResponseTrait public and provide as OCP\SetupCheck\CheckServerResponseTrait 
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-16 14:58:21 +02:00
John Molakvoæ
ff0cab5956
Merge pull request #47852 from nextcloud/sharding-code-fixes 2024-09-16 11:39:58 +02:00
Kate
8a32881633
Merge pull request #48008 from nextcloud/fix/entity/strict-types 2024-09-16 11:08:35 +02:00
Anna
d46f271b1f
Merge pull request #48049 from nextcloud/refactor/void-tests 
refactor: Add void return type to PHPUnit test methods
 2024-09-16 00:11:41 +02:00
Anna
6892500405
Merge pull request #48046 from nextcloud/refactor/self-class-reference 
refactor: Replace __CLASS__ with ::class references
 2024-09-15 23:01:22 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Christoph Wurst
1ee833efab
refactor: Replace __CLASS__ with ::class references 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 21:40:55 +02:00
Anna Larch
6c36c54dc6 feat(db): switch from settype to casts 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-09-15 19:26:58 +02:00
provokateurin
247b1dd70e
fix(Entity): Fix magic setter call for custom strong typed setters 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-15 15:14:54 +02:00
Ferdinand Thiessen
81df2d2c12
feat(PsrLoggerAdapter): Allow to use Psr\Log\LogLevel for log method 
There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-14 17:35:11 +02:00
Côme Chilliet
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app 
Migrate away from OC_App to IAppManager
 2024-09-13 17:44:38 +02:00
Côme Chilliet
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2 
Move admin_audit to proper event listeners v2
 2024-09-13 16:21:44 +02:00
Côme Chilliet
7a16d01ea7
chore(tests): Fix Router test by mocking AppManager methods correctly 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-13 10:26:36 +02:00
Côme Chilliet
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-13 10:08:44 +02:00
Côme Chilliet
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-13 10:08:43 +02:00
Joas Schilling
dcd97e1234
fix(config): Throw PreconditionException always when it didn't match 
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-13 09:20:08 +02:00
Côme Chilliet
b6c286640f
Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace 
fix: Move OC_API into \OC\ApiHelper in standard namespace
 2024-09-12 14:34:07 +02:00