upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

Merge pull request #51020 from nextcloud/artonge/fix/transfer_ownership

Browse source
This commit is contained in:
Louis 2025-04-14 16:14:45 +02:00 committed by GitHub
commit f8391e60ce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/private/Files/ObjectStore/ObjectStoreStorage.php
View file

@ -592,7 +592,14 @@ class ObjectStoreStorage extends \OC\Files\Storage\Common implements IChunkedFil
public function moveFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath, ?ICacheEntry $sourceCacheEntry = null): bool {
$sourceCache = $sourceStorage->getCache();
if ($sourceStorage->instanceOfStorage(ObjectStoreStorage::class) && $sourceStorage->getObjectStore()->getStorageId() === $this->getObjectStore()->getStorageId()) {
if (
$sourceStorage->instanceOfStorage(ObjectStoreStorage::class) &&
$sourceStorage->getObjectStore()->getStorageId() === $this->getObjectStore()->getStorageId()
) {
if ($this->getCache()->get($targetInternalPath)) {
$this->unlink($targetInternalPath);
$this->getCache()->remove($targetInternalPath);
}
$this->getCache()->moveFromCache($sourceCache, $sourceInternalPath, $targetInternalPath);
// Do not import any data when source and target bucket are identical.
return true;
@ -615,6 +622,10 @@ class ObjectStoreStorage extends \OC\Files\Storage\Common implements IChunkedFil
/** @var ObjectStoreStorage $sourceStorage */
$sourceStorage->setPreserveCacheOnDelete(false);
}
if ($this->getCache()->get($targetInternalPath)) {
$this->unlink($targetInternalPath);
$this->getCache()->remove($targetInternalPath);
}
$this->getCache()->moveFromCache($sourceCache, $sourceInternalPath, $targetInternalPath);
return true;

18
tests/lib/Files/Storage/StoragesTest.php
View file

@ -42,6 +42,24 @@ abstract class StoragesTest extends TestCase {
$this->assertEquals('foo', $this->storage1->file_get_contents($target));
}
public function testMoveFileFromStorageWithExistingTarget() {
$source = 'source.txt';
$target = 'target.txt';
$this->storage1->file_put_contents($target, 'bar');
$this->storage2->file_put_contents($source, 'foo');
$targetURN = $this->storage1->getURN($this->storage1->getCache()->get($target)->getID());
$sourceURN = $this->storage2->getURN($this->storage2->getCache()->get($source)->getID());
$this->storage1->moveFromStorage($this->storage2, $source, $target);
$this->assertTrue($this->storage1->file_exists($target), $target . ' was not created in DB');
$this->assertFalse($this->storage2->file_exists($source), $source . ' still exists in DB');
$this->assertTrue($this->storage1->getObjectStore()->objectExists($sourceURN), $sourceURN . ' was not created in bucket');
$this->assertFalse($this->storage1->getObjectStore()->objectExists($targetURN), $targetURN . ' still exists in bucket');
$this->assertEquals('foo', $this->storage1->file_get_contents($target));
}
public function testMoveDirectoryFromStorage() {
$this->storage2->mkdir('source');
$this->storage2->file_put_contents('source/test1.txt', 'foo');