upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

chore(files_external): Remove broken SFTP_Key tests

Browse source 
They were always skipped and the tested class does not exist.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This commit is contained in:
Côme Chilliet 2026-05-12 11:38:38 +02:00 committed by Côme Chilliet
parent 7cfa95e48b
commit a77969d1c0
2 changed files with 0 additions and 83 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.github/workflows/files-external-sftp.yml vendored
View file

@ -98,7 +98,6 @@ jobs:
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/SftpTest.php \
apps/files_external/tests/Storage/SFTP_KeyTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}

82
apps/files_external/tests/Storage/SFTP_KeyTest.php
View file

@ -1,82 +0,0 @@
<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2019-2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
* SPDX-License-Identifier: AGPL-3.0-only
*/
namespace OCA\Files_External\Tests\Storage;
use OCA\Files_External\Lib\Storage\SFTP_Key;
/**
* Class SFTP_KeyTest
*
*
* @package OCA\Files_External\Tests\Storage
*/
#[\PHPUnit\Framework\Attributes\Group(name: 'DB')]
class SFTP_KeyTest extends \Test\Files\Storage\Storage {
use ConfigurableStorageTrait;
protected function setUp(): void {
parent::setUp();
$id = $this->getUniqueID();
$this->loadConfig(__DIR__ . '/../config.php');
// Make sure we have an new empty folder to work in
$this->config['sftp_key']['root'] .= '/' . $id;
$this->instance = new SFTP_Key($this->config['sftp_key']);
$this->instance->mkdir('/');
}
protected function shouldRunConfig(mixed $config): bool {
return is_array($config) && ($config['sftp_key']['run'] ?? false);
}
protected function tearDown(): void {
if ($this->instance) {
$this->instance->rmdir('/');
}
parent::tearDown();
}
public function testInvalidAddressShouldThrowException(): void {
$this->expectException(\InvalidArgumentException::class);
// I'd use example.com for this, but someone decided to break the spec and make it resolve
$this->instance->assertHostAddressValid('notarealaddress...');
}
public function testValidAddressShouldPass(): void {
$this->assertTrue($this->instance->assertHostAddressValid('localhost'));
}
public function testNegativePortNumberShouldThrowException(): void {
$this->expectException(\InvalidArgumentException::class);
$this->instance->assertPortNumberValid('-1');
}
public function testNonNumericalPortNumberShouldThrowException(): void {
$this->expectException(\InvalidArgumentException::class);
$this->instance->assertPortNumberValid('a');
}
public function testHighPortNumberShouldThrowException(): void {
$this->expectException(\InvalidArgumentException::class);
$this->instance->assertPortNumberValid('65536');
}
public function testValidPortNumberShouldPass(): void {
$this->assertTrue($this->instance->assertPortNumberValid('22222'));
}
}