From a77969d1c0cc1d9a25902beca744fdbe82368d71 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=B4me=20Chilliet?= <come.chilliet@nextcloud.com>
Date: Tue, 12 May 2026 11:38:38 +0200
Subject: [PATCH] chore(files_external): Remove broken SFTP_Key tests
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

They were always skipped and the tested class does not exist.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
---
 .github/workflows/files-external-sftp.yml     |  1 -
 .../tests/Storage/SFTP_KeyTest.php            | 82 -------------------
 2 files changed, 83 deletions(-)
 delete mode 100644 apps/files_external/tests/Storage/SFTP_KeyTest.php

diff --git a/.github/workflows/files-external-sftp.yml b/.github/workflows/files-external-sftp.yml
index 9a0dbdb1f59..dcfdfa9253c 100644
--- a/.github/workflows/files-external-sftp.yml
+++ b/.github/workflows/files-external-sftp.yml
@@ -98,7 +98,6 @@ jobs:
       - name: PHPUnit
         run: composer run test:files_external -- \
           apps/files_external/tests/Storage/SftpTest.php \
-          apps/files_external/tests/Storage/SFTP_KeyTest.php \
           --log-junit junit.xml \
           ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
 
diff --git a/apps/files_external/tests/Storage/SFTP_KeyTest.php b/apps/files_external/tests/Storage/SFTP_KeyTest.php
deleted file mode 100644
index 4352580132c..00000000000
--- a/apps/files_external/tests/Storage/SFTP_KeyTest.php
+++ /dev/null
@@ -1,82 +0,0 @@
-<?php
-
-declare(strict_types=1);
-/**
- * SPDX-FileCopyrightText: 2019-2024 Nextcloud GmbH and Nextcloud contributors
- * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-namespace OCA\Files_External\Tests\Storage;
-
-use OCA\Files_External\Lib\Storage\SFTP_Key;
-
-/**
- * Class SFTP_KeyTest
- *
- *
- * @package OCA\Files_External\Tests\Storage
- */
-#[\PHPUnit\Framework\Attributes\Group(name: 'DB')]
-class SFTP_KeyTest extends \Test\Files\Storage\Storage {
-	use ConfigurableStorageTrait;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$id = $this->getUniqueID();
-		$this->loadConfig(__DIR__ . '/../config.php');
-		// Make sure we have an new empty folder to work in
-		$this->config['sftp_key']['root'] .= '/' . $id;
-		$this->instance = new SFTP_Key($this->config['sftp_key']);
-		$this->instance->mkdir('/');
-	}
-
-	protected function shouldRunConfig(mixed $config): bool {
-		return is_array($config) && ($config['sftp_key']['run'] ?? false);
-	}
-
-	protected function tearDown(): void {
-		if ($this->instance) {
-			$this->instance->rmdir('/');
-		}
-
-		parent::tearDown();
-	}
-
-
-	public function testInvalidAddressShouldThrowException(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		// I'd use example.com for this, but someone decided to break the spec and make it resolve
-		$this->instance->assertHostAddressValid('notarealaddress...');
-	}
-
-	public function testValidAddressShouldPass(): void {
-		$this->assertTrue($this->instance->assertHostAddressValid('localhost'));
-	}
-
-
-	public function testNegativePortNumberShouldThrowException(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->instance->assertPortNumberValid('-1');
-	}
-
-
-	public function testNonNumericalPortNumberShouldThrowException(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->instance->assertPortNumberValid('a');
-	}
-
-
-	public function testHighPortNumberShouldThrowException(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->instance->assertPortNumberValid('65536');
-	}
-
-	public function testValidPortNumberShouldPass(): void {
-		$this->assertTrue($this->instance->assertPortNumberValid('22222'));
-	}
-}