diff --git a/.github/workflows/files-external-sftp.yml b/.github/workflows/files-external-sftp.yml index 9a0dbdb1f59..dcfdfa9253c 100644 --- a/.github/workflows/files-external-sftp.yml +++ b/.github/workflows/files-external-sftp.yml @@ -98,7 +98,6 @@ jobs: - name: PHPUnit run: composer run test:files_external -- \ apps/files_external/tests/Storage/SftpTest.php \ - apps/files_external/tests/Storage/SFTP_KeyTest.php \ --log-junit junit.xml \ ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }} diff --git a/apps/files_external/tests/Storage/SFTP_KeyTest.php b/apps/files_external/tests/Storage/SFTP_KeyTest.php deleted file mode 100644 index 4352580132c..00000000000 --- a/apps/files_external/tests/Storage/SFTP_KeyTest.php +++ /dev/null @@ -1,82 +0,0 @@ -getUniqueID(); - $this->loadConfig(__DIR__ . '/../config.php'); - // Make sure we have an new empty folder to work in - $this->config['sftp_key']['root'] .= '/' . $id; - $this->instance = new SFTP_Key($this->config['sftp_key']); - $this->instance->mkdir('/'); - } - - protected function shouldRunConfig(mixed $config): bool { - return is_array($config) && ($config['sftp_key']['run'] ?? false); - } - - protected function tearDown(): void { - if ($this->instance) { - $this->instance->rmdir('/'); - } - - parent::tearDown(); - } - - - public function testInvalidAddressShouldThrowException(): void { - $this->expectException(\InvalidArgumentException::class); - - // I'd use example.com for this, but someone decided to break the spec and make it resolve - $this->instance->assertHostAddressValid('notarealaddress...'); - } - - public function testValidAddressShouldPass(): void { - $this->assertTrue($this->instance->assertHostAddressValid('localhost')); - } - - - public function testNegativePortNumberShouldThrowException(): void { - $this->expectException(\InvalidArgumentException::class); - - $this->instance->assertPortNumberValid('-1'); - } - - - public function testNonNumericalPortNumberShouldThrowException(): void { - $this->expectException(\InvalidArgumentException::class); - - $this->instance->assertPortNumberValid('a'); - } - - - public function testHighPortNumberShouldThrowException(): void { - $this->expectException(\InvalidArgumentException::class); - - $this->instance->assertPortNumberValid('65536'); - } - - public function testValidPortNumberShouldPass(): void { - $this->assertTrue($this->instance->assertPortNumberValid('22222')); - } -}