Sukhwinder Dhillon
f4d704fbd5
Fix: Switching to the icingadb backend and searching host/service node in add/edit form throws an error
...
`HostServiceTermValidator`: `$testConfig` requires backend for `MonitoringState::apply()` call.
If the `$testConfig` has no backend set and icingadb is in use, `MonitoringState::__construct($config) => $config->getBackend()` returns an icingadb backend that is not suitable for the `MonitoringState` class.
2024-03-27 08:47:02 +01:00
Sukhwinder Dhillon
4428d78da9
phpstan: Streamline vendor file location with local dev-env ( #442 )
2024-03-26 15:55:47 +01:00
Sukhwinder Dhillon
087b1b6c8e
phpstan: Separate baseline by php version
2024-03-26 13:02:39 +01:00
Sukhwinder Dhillon
1f8d74a612
Sort: Fix var type error
2024-03-26 12:50:08 +01:00
Sukhwinder Dhillon
004044a22a
GithubActions: Add checks for php 8.3
2024-03-26 11:43:24 +01:00
Sukhwinder Dhillon
b2362f2079
phpstan: Streamline vendor file location with local dev-env
...
phpstan is not run with an action anymore, as the action runs
it its own docker container and hence has no access to files
outside the repository root. A side-effect of this is, that
phpstan now **really** runs with the php version set up by
the matrix.
2024-03-26 11:38:26 +01:00
Johannes Meyer
7eaad11e37
Release v2.5.0 ( #425 )
2023-10-12 09:23:57 +02:00
Johannes Meyer
6804abc375
module.info: Raise version to 2.5.0
2023-10-12 09:21:12 +02:00
Johannes Meyer
fcf8f1dd39
Raise required library versions
2023-10-12 09:21:12 +02:00
Johannes Meyer
d49a15065d
README.md: Update tag badge link
2023-10-12 09:21:12 +02:00
Johannes Meyer
355123157c
Drop obsolete packaging files
2023-10-12 09:20:02 +02:00
Johannes Meyer
148b8f133f
doc: Adjust accordingly to our new packaging docs
2023-10-12 09:17:11 +02:00
Johannes Meyer
517fe787af
Update default branch references
2023-10-12 09:11:38 +02:00
raviks789
d382738fcf
PHPStan: Update baseline
2023-10-12 08:35:50 +02:00
Johannes Meyer
f35fa250f5
workflows: Add Phpstan ( #378 )
...
With 8.2 php tests
2023-08-31 11:24:37 +02:00
Sukhwinder Dhillon
36cd13ad29
Github Action: Do not cancel further tests if one fails
2023-08-30 14:47:03 +02:00
Sukhwinder Dhillon
8e5c3d349f
phpstan: Analyze tests is not necessary
2023-08-24 13:38:01 +02:00
Sukhwinder Dhillon
b1025c6745
phpstan: Don't report errors that we do not acknowledge as errors
2023-08-24 13:29:11 +02:00
Yonas Habteab
1f3514ce2b
phpstan: Set level to max and add baseline config
2023-08-24 13:29:11 +02:00
Yonas Habteab
1c6ad874ac
Add variable type hint & fix argument type hints
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
b2c25d35f7
Node: Property $icon can be null
2023-08-24 13:29:11 +02:00
Yonas Habteab
9aabeb1e1c
Fix call an undefined method Filterable::fetchRow() error
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
f74a054d8b
ProcessChanges: Fix incorrect phpDoc
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
c497c7360e
Url::getRequest(): Add missing return type
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
74c3440ef9
ProcessProblemsBadge: Fix variable $count is probably undefined
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
52732dc3c7
QuickForm: Make property $successUrl nullable and add phpDoc to setAction()
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
2efe54de1f
QuickBaseForm: Property $icingaModule can be null
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
95504131d1
FormLoader: Define var $file in method scope
...
- Fixes IDE's message: `varibale $file is probabaly undefined`
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
95776d309b
Controller::storage(): Only return an instance of LegacyStorage
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
d0df785bbd
BaseTestCase: Param $subDir can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
43b391880d
LegacyConfigRenderer: Don't use dynamic property
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
7605d5e007
LegacyConfigParser: Property $prevKey can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6f81fed8e7
NodeTile: Fix incorrect phpDoc
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
26b0d921ea
Renderer::renderStateBadges(): Return type can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
ab8fe2aca6
(ServiceDetail/DetailView)Extension: Property $storage can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
3544c21056
Node: Property $state can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6934016ef0
Node: var_export() param#2 expects bool
2023-08-24 13:29:04 +02:00
Sukhwinder Dhillon
ad3cb81dc9
NodeAction: json_decode() $param#2 expects bool
2023-08-24 13:28:55 +02:00
Sukhwinder Dhillon
f960d09cc2
BpNode: Remove unreachable break statements
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
541ec5da6c
BpNode: Property $children can be null
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
598e9a1af0
BpConfig::getNode(): Define exact return types in PhpDoc
...
- This fixes the IDE's issue `Call to an undefined method`, which is caused by the fact that the parent class `Node` does not contain all the methods defined in the child classes.
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
ae8e71106f
BpConfig::hasChanges(): Fix incorrect return type
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
3643c799d0
SimulationForm: Property $simulatedNode can be nullable
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
3fffecca3f
DeleteNodeForm: Make property $parentNode nullable
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
5899aa96ef
ProcessCommand: Define $name in method scope
...
- Fixes variable is probably undefined
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
6306b5306c
Define variable type when method returns a class object
...
- This helps the IDE to find class methods and resolves the `call to an undefined method` issue
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
21933d1868
NodeAction::create(): Avoid unnecessary variable initialization
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
7346cd1cab
HostServiceTermValidator:isValid(): Add missing return statement
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
35d151b70d
Sort Trait: Make $sort nullable and adjust code accordingly
...
- Update phpDoc
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
92e982bf3d
Remove unused class Form and FormStateOverrides
2023-08-24 13:04:29 +02:00
