Add variable type hint & fix argument type hints

application/forms/AddNodeForm.php

@@ -378,9 +378,11 @@ class AddNodeForm extends CompatForm
 
             $changes->createNode(BpConfig::escapeName($this->getValue('name')), $properties);
         } else {
+            /** @var TermInput $term */
+            $term = $this->getElement('children');
             $children = array_unique(array_map(function ($term) {
                 return $term->getSearchValue();
-            }, $this->getElement('children')->getTerms()));
+            }, $term->getTerms()));
 
             if ($nodeType === 'host' || $nodeType === 'service') {
                 $stateOverrides = $this->getValue('stateOverrides');

library/Businessprocess/Modification/NodeRemoveAction.php

@@ -68,10 +68,9 @@ class NodeRemoveAction extends NodeAction
         $parentName = $this->getParentName();
         $node = $config->getNode($name);
 
-        $this->updateStateOverrides(
-            $node,
-            $parentName ? $config->getNode($parentName) : null
-        );
+        /** @var ?BpNode $parentBpNode */
+        $parentBpNode = $parentName ? $config->getNode($parentName) : null;
+        $this->updateStateOverrides($node, $parentBpNode);
 
         if ($parentName === null) {
             if (! $config->hasBpNode($name)) {

library/Businessprocess/Node.php

@@ -47,7 +47,7 @@ abstract class Node
         self::NODE_EMPTY      => 0
     );
 
-    /** @var string Alias of the node */
+    /** @var ?string Alias of the node */
     protected $alias;
 
     /**
@@ -346,7 +346,7 @@ abstract class Node
     /**
      * Get the alias of the node
      *
-     * @return string
+     * @return ?string
      */
     public function getAlias()
     {

library/Businessprocess/Renderer/Breadcrumb.php

@@ -48,6 +48,7 @@ class Breadcrumb extends BaseHtmlElement
 
         $parts = array();
         while ($nodeName = array_pop($path)) {
+            /** @var BpNode $node */
             $node = $bp->getNode($nodeName);
             $renderer->setParentNode($node);
             array_unshift(

library/Businessprocess/Renderer/TileRenderer/NodeTile.php

@@ -35,7 +35,6 @@ class NodeTile extends BaseHtmlElement
     /**
      * NodeTile constructor.
      * @param Renderer $renderer
-     * @param $name
      * @param Node $node
      * @param ?array $path
      */

library/Businessprocess/Storage/LegacyConfigParser.php

@@ -247,6 +247,7 @@ class LegacyConfigParser
     {
         // state_overrides <bp-node>!<child>|n-n[,n-n]!<child>|n-n[,n-n]
         $segments = preg_split('~\s*!\s*~', substr($line, 16));
+        /** @var BpNode $node */
         $node = $bp->getNode(array_shift($segments));
         foreach ($segments as $overrideDef) {
             list($childName, $overrides) = preg_split('~\s*\|\s*~', $overrideDef, 2);

library/Businessprocess/Web/Controller.php

@@ -210,6 +210,7 @@ class Controller extends CompatController
     protected function loadBpConfig()
     {
         $name = $this->params->get('config');
+        /** @var LegacyStorage $storage */
         $storage = $this->storage();
 
         if (! $storage->hasProcess($name)) {