Commit graph

303 commits

Author SHA1 Message Date
Johannes Meyer
49ebbc4cdb Apply state overrides on demand instead of directly
Internally non-process children are only instantiated once.
This means when applying state overrides directly they're
used everywhere and do not differ between the containing
process. State overrides are now applied explicitly and
on demand, decoupling them from children.
2020-07-01 08:54:34 +02:00
Johannes Meyer
0c7fca926f config: Use an extra line to store state overrides
Storing overrides as part of a node's name leads to way too complicated
code. A separate field is not only better for compatibility but also
more straightforward to process.
2020-06-26 14:08:05 +02:00
Christian Menapace
98b6b2c6d0 Add Service Override 2020-06-26 11:32:09 +02:00
Ravi Kumar Kempapura Srinivasa
1278480b6e Fix 'vsprintf(): Too few arguments' in ProcessController::showAction()
Before, we called printf twice because BpConfig::addError()
already makes use of printf. The exception only occured for
nodes that have a percent sign (%) in their name.

fixes #234
2020-02-26 15:09:17 +01:00
Johannes Meyer
9835dc9c03
Merge pull request #264 from Icinga/fix/check-command-handling-256
ProcessCommand: handle errors as UNKNOWN
2020-02-26 12:02:08 +01:00
Johannes Meyer
cb1cd24bfe de_DE: Avoid anglicisms
resolves #257
2020-02-26 12:00:15 +01:00
Yonas Habteab
1397c8a7af ProcessCommand:handle some other errors as UNKONWN
fixes #256
2020-02-26 10:23:30 +01:00
Johannes Meyer
144bcdf852 Remove space after reference operators 2020-02-26 09:19:31 +01:00
Yonas Habteab
09cb5ef6fe ProcessCommand: handle error as UNKNOWN
fixes #256
2020-02-25 16:04:40 +01:00
Dominik Seidel
8ef1dfcbdc CLI: Add options --downtime-is-ok and --ack-is-ok 2020-02-05 15:01:22 +01:00
Dominik Seidel
1414e76d94 CLI: Add options --blame and --root-cause 2020-02-05 15:01:22 +01:00
Johannes Meyer
f13145f43b BpUploadForm: Properly adjust the success url 2019-11-04 16:08:28 +01:00
Johannes Meyer
61dc23fa10 locale: Update german translation 2019-03-01 12:43:16 +01:00
Johannes Meyer
dc69522ae5 ProcessForm: Properly populate element display 2019-03-01 08:20:48 +01:00
Johannes Meyer
0fbb8956e9 node/impact: Don't show colored background for breadcrumbs
There are stateballs now.
2019-02-26 15:06:02 +01:00
Johannes Meyer
d690c07ed8 process/show: Don't show the control separator when in fullscreen or on the dashboard 2019-02-26 08:57:46 +01:00
Johannes Meyer
21980a394f NodeController: Also show impact on imported sub processes 2019-02-25 15:09:34 +01:00
Johannes Meyer
eaf5b85538 Change how imported nodes are recognized
Since configurations are cached this cannot be done by using
a flag. Instead the rendering and path aggregation are now able
to distinguish nodes themselves.
2019-02-25 13:58:18 +01:00
Johannes Meyer
40538c51ce LegacyStorage: Add cache to avoid parsing configurations multiple times 2019-02-25 12:42:52 +01:00
Johannes Meyer
6ae4cf745c RenderedProcessActionBar: Don't allow to unlock imported nodes 2019-02-22 14:41:53 +01:00
Johannes Meyer
673135c0f3 Don't redirect after a successful move action but refresh 2019-02-22 12:26:24 +01:00
Johannes Meyer
ff2274c048 node/impact: Fix that a process' state is not displayed 2019-02-22 12:26:24 +01:00
Johannes Meyer
718a4305b4 NodeController: Show all processes affected by an impact
refs #143
2019-02-22 12:26:24 +01:00
Johannes Meyer
431a5e0085 Streamline usage of a node's name 2019-02-22 12:26:24 +01:00
Johannes Meyer
8465bc0bc3 LegacyConfigParser: Establish parent-child relationships
This replaces commit d1f32c5 as this is the more efficient
and proper solution.

refs #134
2019-02-22 12:26:24 +01:00
Johannes Meyer
e0529ee844 Revert "Node: Aggregate parents if none are registered yet"
This reverts commit d1f32c59f1.
2019-02-22 12:26:24 +01:00
Johannes Meyer
7a8c48c7e8 Fix a few style issues 2019-02-22 12:26:24 +01:00
Johannes Meyer
195b3bf7b7 ProcessController: Don't unlock the renderer if fullscreen is enabled 2019-02-22 12:26:24 +01:00
Johannes Meyer
ccdadf68f2 MoveNodeForm: Respond with a status of 400 in case of a ModificationError 2019-02-22 12:26:24 +01:00
Johannes Meyer
f58e1844a1 ActionBar: Remove h1 and adjust link labels 2019-02-22 12:26:24 +01:00
Johannes Meyer
bc03569765 Properly handle display values when performing other actions than moving nodes 2019-02-22 12:26:24 +01:00
Johannes Meyer
3146bfda6a MoveNodeForm: Show ModificationErrors as notifications 2019-02-22 12:26:24 +01:00
Johannes Meyer
ea0a04065d Add support to move nodes between processes 2019-02-22 12:26:24 +01:00
Johannes Meyer
b46a633d6d ProcessController: Provide a new set of parameters when redirecting 2019-02-22 12:26:23 +01:00
Johannes Meyer
c804177ca4 Also save user defined order of processes nodes while in tree view 2019-02-22 12:26:23 +01:00
Johannes Meyer
08bfbc462b Save user defined order of processes/nodes 2019-02-22 12:26:23 +01:00
Johannes Meyer
876a577e85 Don't sort processes in case manual sorting has been applied 2019-02-22 12:26:23 +01:00
Johannes Meyer
68aedc3dce Restrict host and service lists when adding new or editing old nodes
resolves #67
2019-02-22 12:21:18 +01:00
Johannes Meyer
d1f32c59f1 Node: Aggregate parents if none are registered yet
fixes #134
2019-02-19 11:02:08 +01:00
Johannes Meyer
324a6e898d node/impact: Show message if no impact is detected
fixes #160
2019-02-19 08:45:39 +01:00
Johannes Meyer
4c0136eec8 Beautify displayed message for restricted hosts/services
refs #147
2019-02-18 15:20:42 +01:00
Alexander A. Klimov
3985f67fe7 Fix "Host not found" error
refs #147
2019-02-18 13:54:39 +01:00
Johannes Meyer
a1df0347f5 AddNodeForm: Don't allow to import imported nodes 2019-02-14 14:36:30 +01:00
Johannes Meyer
71fb738016 ProcessController: Properly handle spaces in node names 2019-02-14 14:26:20 +01:00
Johannes Meyer
763ac872d3 Introduce and utilize class NoDuplicateChildrenValidator 2019-02-14 11:29:30 +01:00
Johannes Meyer
327cb7c28c Allow to import processes from different configurations 2019-01-17 15:20:25 +01:00
Johannes Meyer
a707ee3eb7 Use "ID" instead of "Name" and "Display Name" instead of "Title" 2019-01-17 15:20:25 +01:00
Johannes Meyer
510267c7d0 Prevent nodes from being added twice
fixes #186
fixes #128
fixes #114
2019-01-17 15:20:25 +01:00
Johannes Meyer
de3e0e5b6c process/config: Preserve display mode when storing changes 2019-01-17 14:57:38 +01:00
Johannes Meyer
64256f3654 EditNodeForm: Only allow basic changes to existing sub-nodes 2019-01-17 14:57:38 +01:00
Johannes Meyer
b2ef90b99f BpConfigForm: Switch to single column layout after adding/changing processes 2019-01-17 14:36:28 +01:00
Johannes Meyer
19ae300aca lib: Remove all traces of Icinga\Module\Businessprocess\Html
refs #130
2019-01-17 13:21:46 +01:00
Johannes Meyer
67613930a2 BpConfigForm: Don't override processes which have coincidentally the same name
fixes #195
2019-01-09 13:02:20 +01:00
Thomas Gelf
8b7311591f Revert "Adjust tile navigation"
This reverts commit 50e18766f6.

refs #192
2018-12-12 16:36:09 +01:00
Eric Lippmann
8f98f31d66 Trigger session destruction to make sure it get's stored 2018-08-15 16:45:49 +02:00
Eric Lippmann
1c0e9f5bd4 Fix missing redirects
Some forms were missing the parent::onSuccess() call.
2018-08-15 09:39:26 +02:00
Eric Lippmann
50e18766f6 Adjust tile navigation
* Left to right tile drill down
* Actions redirect to main
2018-08-15 09:37:43 +02:00
Eric Lippmann
7c491496fa Use natcasesort 2018-08-13 13:30:33 +02:00
Eric Lippmann
059a59b119 Support exporting to CSV, JSON and PDF 2018-08-01 13:12:08 +02:00
Eric Lippmann
99a66a4b4b Remove node before recreating it upon edit
Else you may run into errors that objects have been defined twice.
2018-07-31 12:59:49 +02:00
Eric Lippmann
f4a3fcc81b Close action form after successful submission 2018-07-31 12:50:25 +02:00
Jennifer Mourek
9cfe95df60 Remove option 'DEG' 2018-07-31 12:50:25 +02:00
Jennifer Mourek
d9808ae9b7 Remove comment and fix codestyle 2018-07-31 12:50:25 +02:00
Jennifer Mourek
c1cb7612c0 Add preselection when editing 2018-07-31 12:50:25 +02:00
Jennifer Mourek
87b1d961bc Add functionality to edit node 2018-07-31 12:50:25 +02:00
Eric Lippmann
28bed2859b
Merge pull request #152 from Icinga/bugfix/cannot-remove-a-node-132
Make node removal working as expected
2018-07-02 17:23:32 +02:00
Jennifer Mourek
460670c769 AddNodeForm: Remove option 'DEG'
refs #159
2018-07-02 12:48:21 +02:00
Eric Lippmann
2fd3011978
Merge pull request #157 from Icinga/bugfix/new-node-self-reference-149
Prevent circular node references
2018-06-26 10:54:53 +02:00
Eric Lippmann
ab643314fe
Merge pull request #153 from Icinga/feature/unlock-required-150
Lock processes more user-friendly
2018-06-26 10:09:30 +02:00
Max Stephan
1db47e6cc3 fix translation syntax "NIcht" -> "Nicht" 2018-06-26 09:26:26 +02:00
Jennifer Mourek
d722f969b0 Fix not being able to add the first node 2018-06-25 16:56:26 +02:00
Alexander A. Klimov
1bc4b377ea Prevent circular node references
refs #149
2018-06-25 16:42:00 +02:00
Alexander A. Klimov
e4e651cbe8 Make node removal working as expected
refs #132
2017-12-04 14:14:06 +01:00
Alexander A. Klimov
aac6ebb679 Lock processes more user-friendly
refs #150
2017-12-04 14:13:48 +01:00
Markus Frosch
651bb15041 ProcessController: Shorten list of missing nodes in UI 2017-05-31 14:24:17 +02:00
Thomas Gelf
0d49df0191 locale/de_DE: refresh German translation 2017-02-20 15:21:56 +01:00
Thomas Gelf
9750e13234 BpNode, process/show: error for missing children...
...and unknown as state

fixes #105
2017-02-20 14:47:30 +01:00
Thomas Gelf
a9db4f9120 ProcessController: superfluous newline 2017-02-20 14:17:00 +01:00
Thomas Gelf
c4242f869b ProcessController: do not show edit forms...
...even if requested

refs #107
2017-02-08 17:56:38 +01:00
Thomas Gelf
e6722d9024 ProcessController: add missing permission checks
refs #107
2017-02-08 17:39:22 +01:00
Thomas Gelf
7452a39f82 BpConfig/UploadForm: unify common code, enforce...
...prefix(es) according configured restrictions

refs  #106
2017-02-08 16:08:29 +01:00
Thomas Gelf
09031d38da ProcessCommand: allow to list process nodes
fixes #97
2017-01-27 15:26:11 +01:00
Thomas Gelf
5cbd46b6e3 Node: return myself in every path
fixes #96
2017-01-27 15:01:48 +01:00
Thomas Gelf
0c395cc005 DeleteNode: use parent, not path
fixes #94
2017-01-27 14:57:57 +01:00
Thomas Gelf
b0e38df177 BpUploadForm: stop on duplicate name
fixes #95
2017-01-27 14:56:07 +01:00
Thomas Gelf
8be4adfa5d BpUploadForm: remove newline to fix phpcs issue 2017-01-27 11:40:52 +01:00
Thomas Gelf
dfd9ee74c3 BpUploadForm: completely refactor upload
It's much more comfortable and consists of two steps, upload - and a validation
allowing one to manually tweak the source before storing it.

fixes #8
2017-01-27 10:04:59 +01:00
Thomas Gelf
60d043cb18 Simulation: refactor the whole class
First step, more to come. Single node simulations should be moved to a
dedicated class of course

fixes #88
fixes #89
2017-01-26 22:09:38 +01:00
Thomas Gelf
a0a2a59bcd ProcessController: add help title for leaving...
...full screen mode
2017-01-25 10:12:00 +01:00
Thomas Gelf
7a4c9d4f6d RenderedProcessActionBar: help for tree/tile view
fixes #79
2017-01-25 10:03:45 +01:00
Thomas Gelf
70e4f20f17 locale: improve and complete German translation 2017-01-25 09:48:21 +01:00
Thomas Gelf
c221c0becd ProcessController: it's "Business Process"
fixes #85
2017-01-25 09:11:25 +01:00
Thomas Gelf
dae799fd1e AddNodeForm: do not store a parent in case...
...there is no such

fixes #83
2017-01-23 23:45:52 +01:00
Thomas Gelf
845cb3462d ProcessController: improve config-related tabs...
...and actions
2017-01-12 09:18:44 +01:00
Thomas Gelf
3dff6848ec Merge branch 'feature/travis' 2017-01-11 23:58:57 +01:00
Thomas Gelf
d87edba377 Just a couple of newlines to satisfy latest PSR2
...checks in phpcs
2017-01-11 23:56:17 +01:00
Thomas Gelf
5f6b35906d AddNode: fix creating nested nodes
fixes #13883
2017-01-11 17:38:19 +01:00
Thomas Gelf
c86c2fe151 DeleteNodeForm: fix business impact link 2017-01-11 17:33:29 +01:00
Thomas Gelf
643261c9f7 NodeController: apply simulations to business...
...impact rendering
2017-01-11 17:01:50 +01:00
Thomas Gelf
094fbd6c27 BpConfigForm: validate process name 2017-01-11 17:01:40 +01:00