Sukhwinder Dhillon
8e5c3d349f
phpstan: Analyze tests is not necessary
2023-08-24 13:38:01 +02:00
Sukhwinder Dhillon
b1025c6745
phpstan: Don't report errors that we do not acknowledge as errors
2023-08-24 13:29:11 +02:00
Yonas Habteab
1f3514ce2b
phpstan: Set level to max and add baseline config
2023-08-24 13:29:11 +02:00
Yonas Habteab
1c6ad874ac
Add variable type hint & fix argument type hints
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
b2c25d35f7
Node: Property $icon can be null
2023-08-24 13:29:11 +02:00
Yonas Habteab
9aabeb1e1c
Fix call an undefined method Filterable::fetchRow() error
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
f74a054d8b
ProcessChanges: Fix incorrect phpDoc
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
c497c7360e
Url::getRequest(): Add missing return type
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
74c3440ef9
ProcessProblemsBadge: Fix variable $count is probably undefined
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
52732dc3c7
QuickForm: Make property $successUrl nullable and add phpDoc to setAction()
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
2efe54de1f
QuickBaseForm: Property $icingaModule can be null
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
95504131d1
FormLoader: Define var $file in method scope
...
- Fixes IDE's message: `varibale $file is probabaly undefined`
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
95776d309b
Controller::storage(): Only return an instance of LegacyStorage
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
d0df785bbd
BaseTestCase: Param $subDir can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
43b391880d
LegacyConfigRenderer: Don't use dynamic property
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
7605d5e007
LegacyConfigParser: Property $prevKey can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6f81fed8e7
NodeTile: Fix incorrect phpDoc
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
26b0d921ea
Renderer::renderStateBadges(): Return type can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
ab8fe2aca6
(ServiceDetail/DetailView)Extension: Property $storage can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
3544c21056
Node: Property $state can be null
2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6934016ef0
Node: var_export() param#2 expects bool
2023-08-24 13:29:04 +02:00
Sukhwinder Dhillon
ad3cb81dc9
NodeAction: json_decode() $param#2 expects bool
2023-08-24 13:28:55 +02:00
Sukhwinder Dhillon
f960d09cc2
BpNode: Remove unreachable break statements
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
541ec5da6c
BpNode: Property $children can be null
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
598e9a1af0
BpConfig::getNode(): Define exact return types in PhpDoc
...
- This fixes the IDE's issue `Call to an undefined method`, which is caused by the fact that the parent class `Node` does not contain all the methods defined in the child classes.
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
ae8e71106f
BpConfig::hasChanges(): Fix incorrect return type
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
3643c799d0
SimulationForm: Property $simulatedNode can be nullable
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
3fffecca3f
DeleteNodeForm: Make property $parentNode nullable
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
5899aa96ef
ProcessCommand: Define $name in method scope
...
- Fixes variable is probably undefined
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
6306b5306c
Define variable type when method returns a class object
...
- This helps the IDE to find class methods and resolves the `call to an undefined method` issue
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
21933d1868
NodeAction::create(): Avoid unnecessary variable initialization
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
7346cd1cab
HostServiceTermValidator:isValid(): Add missing return statement
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
35d151b70d
Sort Trait: Make $sort nullable and adjust code accordingly
...
- Update phpDoc
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
92e982bf3d
Remove unused class Form and FormStateOverrides
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
e638fade56
Renderer: Fix that !empty($elements) is always true
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
9e67b56bca
RenderedProcessActionBar: Remove unused constructor param $auth
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
661bff8a9b
workflows: Add phpstan
2023-08-24 13:04:27 +02:00
Sukhwinder Dhillon
8923476277
BpNode::getMissingChildren(): Use child name if alias not given
...
Host/Service alias is optional and null as default
2023-08-10 12:45:17 +02:00
Johannes Meyer
a30f85dbcc
Add auto completion ( #387 )
...
resolves #295
requires https://github.com/Icinga/ipl-web/pull/179
requires https://github.com/Icinga/ipl-web/pull/178
2023-08-10 12:43:11 +02:00
Johannes Meyer
b8d5f0de2b
Drop unused trait EnumList
2023-08-09 16:13:01 +02:00
Johannes Meyer
30d952ae0a
Drop obsolete form element class StateOverrides
2023-08-09 16:13:01 +02:00
Johannes Meyer
0ea04f898f
Drop obsolete class NoDuplicateChildrenValidator
2023-08-09 16:13:01 +02:00
Johannes Meyer
890df4be7c
Re-introduce class EditNodeForm
...
Rewritten from scratch. Now with ipl-form compatibility.
2023-08-09 16:13:01 +02:00
Johannes Meyer
d9c6debfa9
ServiceNode: Change alias to <service> on <host>
2023-08-09 16:13:01 +02:00
Johannes Meyer
9c84764157
BpNode: Re-index childnames upon node removal
2023-08-09 16:13:01 +02:00
Johannes Meyer
1b837c72a3
Drop class EditNodeForm
2023-08-09 16:13:01 +02:00
Johannes Meyer
4aac658089
process/show: Utilize the new AddNodeForm
2023-08-09 16:13:01 +02:00
Johannes Meyer
da4edda2b3
Re-introduce class AddNodeForm
...
Rewritten from scratch. Now with ipl-form compatibility.
2023-08-09 16:13:01 +02:00
Johannes Meyer
6dd8a51ce5
Introduce new form validator for host/service terms
2023-08-09 16:13:01 +02:00
Johannes Meyer
46cce05c0a
Add ipl-form compatible implementation of the state override element
2023-08-09 16:13:01 +02:00
