Brad Warren a71e22678f Fix add deprecated argument (#8500) (#8501) ... Fixes https://github.com/certbot/certbot/issues/8495. To further explain the problem here, `modify_kwargs_for_default_detection` as called in `add` is simplistic and doesn't always work. See https://github.com/certbot/certbot/issues/6164 for one other example. In this case, were bitten by the code d1e7404358/certbot/certbot/_internal/cli/helpful.py (L393-L395) The action used for deprecated arguments isn't in `ZERO_ARG_ACTIONS` so it assumes that all deprecated flags take one parameter. Rather than trying to fix this function (which I think can only realistically be fixed by https://github.com/certbot/certbot/issues/4493), I took the approach that was previously used in `HelpfulArgumentParser.add_deprecated_argument` of bypassing this extra logic entirely. I adapted that function to now call `HelpfulArgumentParser.add` as well for consistency and to make testing easier. * Rename deprecated arg action class * Skip extra parsing for deprecated arguments * Add back test of --manual-public-ip-logging-ok * Add changelog entry (cherry picked from commit 5f73274390)		2020-12-03 09:06:05 +01:00
..
assets	Merge pull request #8444 from certbot/ecdsa	2020-11-19 11:54:24 -08:00
certbot_tests	Merge pull request #8444 from certbot/ecdsa	2020-11-19 11:54:24 -08:00
nginx_tests	nginx: fix Unicode crash on Python 2 (#8480)	2020-11-27 18:15:27 +01:00
rfc2136_tests	Add certbot-dns-rfc2136 integration testing (#8448)	2020-11-17 09:27:27 +01:00
utils	Fix add deprecated argument (#8500) (#8501)	2020-12-03 09:06:05 +01:00
.coveragerc	Make the contents of the nginx plugin private (#7589)	2019-11-25 14:30:24 -08:00
__init__.py	[Unix] Create a framework for certbot integration tests: PART 1 (#6578)	2019-03-01 13:18:06 -08:00
conftest.py	Add certbot-dns-rfc2136 integration testing (#8448)	2020-11-17 09:27:27 +01:00