Brad Warren a71e22678f Fix add deprecated argument (#8500) (#8501) ... Fixes https://github.com/certbot/certbot/issues/8495. To further explain the problem here, `modify_kwargs_for_default_detection` as called in `add` is simplistic and doesn't always work. See https://github.com/certbot/certbot/issues/6164 for one other example. In this case, were bitten by the code d1e7404358/certbot/certbot/_internal/cli/helpful.py (L393-L395) The action used for deprecated arguments isn't in `ZERO_ARG_ACTIONS` so it assumes that all deprecated flags take one parameter. Rather than trying to fix this function (which I think can only realistically be fixed by https://github.com/certbot/certbot/issues/4493), I took the approach that was previously used in `HelpfulArgumentParser.add_deprecated_argument` of bypassing this extra logic entirely. I adapted that function to now call `HelpfulArgumentParser.add` as well for consistency and to make testing easier. * Rename deprecated arg action class * Skip extra parsing for deprecated arguments * Add back test of --manual-public-ip-logging-ok * Add changelog entry (cherry picked from commit 5f73274390)		2020-12-03 09:06:05 +01:00
..
__init__.py	[Unix] Create a framework for certbot integration tests: PART 1 (#6578)	2019-03-01 13:18:06 -08:00
acme_server.py	Add --dns-server option in run_acme_server (#7722)	2020-11-12 15:31:32 -08:00
certbot_call.py	Fix add deprecated argument (#8500) (#8501)	2020-12-03 09:06:05 +01:00
constants.py	certbot: add --preferred-chain (#8080)	2020-06-30 17:45:39 -07:00
dns_server.py	certbot-ci: fix py2 crash in dns_server	2020-11-17 14:58:29 -08:00
misc.py	Implements support for ECDSA keys. Fixes #2163.	2020-11-04 15:16:48 +01:00
pebble_artifacts.py	Fix acme compliance to RFC 8555 (#7176)	2020-03-13 09:56:35 -07:00
pebble_ocsp_server.py	Reorganize imports (#7616)	2019-12-09 15:50:20 -05:00
proxy.py	Reorganize imports (#7616)	2019-12-09 15:50:20 -05:00