upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-05-28 04:02:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(otlp): benchmark assert makes no sense (#17023)

Browse source 
convert.Timeseries() and converter.Metadata() is never nil, because
they are always initialized. It's better to assert on whether they are
empty or not.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This commit is contained in:
George Krajcsovits 2025-08-07 19:04:21 +02:00 committed by GitHub
parent ae85827e3a
commit 8f6a71e188
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go
View file

@ -996,8 +996,13 @@ func BenchmarkPrometheusConverter_FromMetrics(b *testing.B) {
annots, err := converter.FromMetrics(context.Background(), payload.Metrics(), settings)
require.NoError(b, err)
require.Empty(b, annots)
require.NotNil(b, converter.TimeSeries())
require.NotNil(b, converter.Metadata())
if histogramCount+nonHistogramCount > 0 {
require.NotEmpty(b, converter.TimeSeries())
require.NotEmpty(b, converter.Metadata())
} else {
require.Empty(b, converter.TimeSeries())
require.Empty(b, converter.Metadata())
}
}
})
}