From 8f6a71e188aee13223e49ecfcc5333ab2167ffa7 Mon Sep 17 00:00:00 2001 From: George Krajcsovits Date: Thu, 7 Aug 2025 19:04:21 +0200 Subject: [PATCH] fix(otlp): benchmark assert makes no sense (#17023) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit convert.Timeseries() and converter.Metadata() is never nil, because they are always initialized. It's better to assert on whether they are empty or not. Signed-off-by: György Krajcsovits --- .../prometheusremotewrite/metrics_to_prw_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go b/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go index d264c81af8..b03b28e4cd 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go @@ -996,8 +996,13 @@ func BenchmarkPrometheusConverter_FromMetrics(b *testing.B) { annots, err := converter.FromMetrics(context.Background(), payload.Metrics(), settings) require.NoError(b, err) require.Empty(b, annots) - require.NotNil(b, converter.TimeSeries()) - require.NotNil(b, converter.Metadata()) + if histogramCount+nonHistogramCount > 0 { + require.NotEmpty(b, converter.TimeSeries()) + require.NotEmpty(b, converter.Metadata()) + } else { + require.Empty(b, converter.TimeSeries()) + require.Empty(b, converter.Metadata()) + } } }) }