mirror of
https://github.com/postgres/postgres.git
synced 2026-02-26 03:11:02 -05:00
ffaa44cb55
The CatalogSnapshot was not plugged into SnapshotResetXmin()'s accounting for whether MyPgXact->xmin could be cleared or advanced. In normal transactions this was masked by the fact that the transaction snapshot would be older, but during backend startup and certain utility commands it was possible to re-use the CatalogSnapshot after MyPgXact->xmin had been cleared, meaning that recently-deleted rows could be pruned even though this snapshot could still see them, causing unexpected catalog lookup failures. This effect appears to be the explanation for a recent failure on buildfarm member piculet. To fix, add the CatalogSnapshot to the RegisteredSnapshots heap whenever it is valid. In the previous logic, it was possible for the CatalogSnapshot to remain valid across waits for client input, but with this change that would mean it delays advance of global xmin in cases where it did not before. To avoid possibly causing new table-bloat problems with clients that sit idle for long intervals, add code to invalidate the CatalogSnapshot before waiting for client input. (When the backend is busy, it's unlikely that the CatalogSnapshot would be the oldest snap for very long, so we don't worry about forcing early invalidation of it otherwise.) In passing, remove the CatalogSnapshotStale flag in favor of using "CatalogSnapshot != NULL" to represent validity, as we do for the other special snapshots in snapmgr.c. And improve some obsolete comments. No regression test because I don't know a deterministic way to cause this failure. But the stress test shown in the original discussion provokes "cache lookup failed for relation 1255" within a few dozen seconds for me. Back-patch to 9.4 where MVCC catalog scans were introduced. (Note: it's quite easy to produce similar failures with the same test case in branches before 9.4. But MVCC catalog scans were supposed to fix that.) Discussion: <16447.1478818294@sss.pgh.pa.us> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| acl.h | ||
| aclchk_internal.h | ||
| array.h | ||
| arrayaccess.h | ||
| ascii.h | ||
| attoptcache.h | ||
| builtins.h | ||
| bytea.h | ||
| cash.h | ||
| catcache.h | ||
| combocid.h | ||
| date.h | ||
| datetime.h | ||
| datum.h | ||
| dynahash.h | ||
| dynamic_loader.h | ||
| elog.h | ||
| evtcache.h | ||
| expandeddatum.h | ||
| fmgrtab.h | ||
| formatting.h | ||
| geo_decls.h | ||
| guc.h | ||
| guc_tables.h | ||
| help_config.h | ||
| hsearch.h | ||
| index_selfuncs.h | ||
| inet.h | ||
| int8.h | ||
| inval.h | ||
| json.h | ||
| jsonapi.h | ||
| jsonb.h | ||
| logtape.h | ||
| lsyscache.h | ||
| memdebug.h | ||
| memutils.h | ||
| nabstime.h | ||
| numeric.h | ||
| palloc.h | ||
| pg_crc.h | ||
| pg_locale.h | ||
| pg_lsn.h | ||
| pg_rusage.h | ||
| plancache.h | ||
| portal.h | ||
| ps_status.h | ||
| rangetypes.h | ||
| rel.h | ||
| relcache.h | ||
| relfilenodemap.h | ||
| relmapper.h | ||
| reltrigger.h | ||
| resowner.h | ||
| resowner_private.h | ||
| rls.h | ||
| ruleutils.h | ||
| sampling.h | ||
| selfuncs.h | ||
| snapmgr.h | ||
| snapshot.h | ||
| sortsupport.h | ||
| spccache.h | ||
| syscache.h | ||
| timeout.h | ||
| timestamp.h | ||
| tqual.h | ||
| tuplesort.h | ||
| tuplestore.h | ||
| typcache.h | ||
| tzparser.h | ||
| uuid.h | ||
| varbit.h | ||
| xml.h | ||