mirror of
https://github.com/postgres/postgres.git
synced 2026-03-11 10:45:17 -04:00
40d1bdeb72
There is a very ancient hack in check_sql_fn_retval that allows a single SELECT targetlist entry of composite type to be taken as supplying all the output columns of a function returning composite. (This is grotty and fundamentally ambiguous, but it's really hard to do nested composite-returning functions without it.) As far as I know, that doesn't cause any problems in ordinary functions. It's disastrous for procedures however. All procedures that have any output parameters are labeled with prorettype RECORD, and the CALL code expects it will get back a record with one column per output parameter, regardless of whether any of those parameters is composite. Doing something else leads to an assertion failure or core dump. This is simple enough to fix: we just need to not apply that rule when considering procedures. However, that requires adding another argument to check_sql_fn_retval, which at least in principle might be getting called by external callers. Therefore, in the back branches convert check_sql_fn_retval into an ABI-preserving wrapper around a new function check_sql_fn_retval_ext. Per report from Yahor Yuzefovich. This has been broken since we implemented procedures, so back-patch to all supported branches. Discussion: https://postgr.es/m/CABz5gWHSjj2df6uG0NRiDhZ_Uz=Y8t0FJP-_SVSsRsnrQT76Gg@mail.gmail.com |
||
|---|---|---|
| .. | ||
| execAsync.h | ||
| execdebug.h | ||
| execdesc.h | ||
| execExpr.h | ||
| execParallel.h | ||
| execPartition.h | ||
| executor.h | ||
| functions.h | ||
| hashjoin.h | ||
| instrument.h | ||
| nodeAgg.h | ||
| nodeAppend.h | ||
| nodeBitmapAnd.h | ||
| nodeBitmapHeapscan.h | ||
| nodeBitmapIndexscan.h | ||
| nodeBitmapOr.h | ||
| nodeCtescan.h | ||
| nodeCustom.h | ||
| nodeForeignscan.h | ||
| nodeFunctionscan.h | ||
| nodeGather.h | ||
| nodeGatherMerge.h | ||
| nodeGroup.h | ||
| nodeHash.h | ||
| nodeHashjoin.h | ||
| nodeIncrementalSort.h | ||
| nodeIndexonlyscan.h | ||
| nodeIndexscan.h | ||
| nodeLimit.h | ||
| nodeLockRows.h | ||
| nodeMaterial.h | ||
| nodeMemoize.h | ||
| nodeMergeAppend.h | ||
| nodeMergejoin.h | ||
| nodeModifyTable.h | ||
| nodeNamedtuplestorescan.h | ||
| nodeNestloop.h | ||
| nodeProjectSet.h | ||
| nodeRecursiveunion.h | ||
| nodeResult.h | ||
| nodeSamplescan.h | ||
| nodeSeqscan.h | ||
| nodeSetOp.h | ||
| nodeSort.h | ||
| nodeSubplan.h | ||
| nodeSubqueryscan.h | ||
| nodeTableFuncscan.h | ||
| nodeTidrangescan.h | ||
| nodeTidscan.h | ||
| nodeUnique.h | ||
| nodeValuesscan.h | ||
| nodeWindowAgg.h | ||
| nodeWorktablescan.h | ||
| spi.h | ||
| spi_priv.h | ||
| tablefunc.h | ||
| tqueue.h | ||
| tstoreReceiver.h | ||
| tuptable.h | ||