upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-07-08 17:20:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/backend/utils/cache
History
Andres Freund c6a60471a1 Prevent pgstats from getting confused when relkind of a relation changes 
When the relkind of a relache entry changes, because a table is converted into
a view, pgstats can get confused in 15+, leading to crashes or assertion
failures.

For HEAD, Tom fixed this in b23cd185fd, by removing support for converting a
table to a view, removing the source of the inconsistency. This commit just
adds an assertion that a relcache entry's relkind does not change, just in
case we end up with another case of that in the future. As there's no cases of
changing relkind anymore, we can't add a test that that's handled correctly.

For 15, fix the problem by not maintaining the association with the old pgstat
entry when the relkind changes during a relcache invalidation processing. In
that case the pgstat entry needs to be unlinked first, to avoid
PgStat_TableStatus->relation getting out of sync. Also add a test reproducing
the issues.

No known problem exists in 11-14, so just add the test there.

Reported-by: vignesh C <vignesh21@gmail.com>
Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CALDaNm2yXz+zOtv7y5zBd5WKT8O0Ld3YxikuU3dcyCvxF7gypA@mail.gmail.com
Discussion: https://postgr.es/m/CALDaNm3oZA-8Wbps2Jd1g5_Gjrr-x3YWrJPek-mF5Asrrvz2Dg@mail.gmail.com
Backpatch: 15-
2022-12-02 18:07:47 -08:00
..
attoptcache.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
catcache.c Fix omissions in support for the "regcollation" type. 2022-07-17 17:43:28 -04:00
evtcache.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
inval.c Remove xloginsert.h from xlog.h 2022-01-30 12:25:24 -03:00
lsyscache.c Restore the previous semantics of get_constraint_index(). 2022-03-11 13:47:29 -05:00
Makefile Split all OBJS style lines in makefiles into one-line-per-entry style. 2019-11-05 14:41:07 -08:00
partcache.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
plancache.c Pre-beta mechanical code beautification. 2022-05-12 15:17:30 -04:00
relcache.c Prevent pgstats from getting confused when relkind of a relation changes 2022-12-02 18:07:47 -08:00
relfilenodemap.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
relmapper.c Pre-beta mechanical code beautification. 2022-05-12 15:17:30 -04:00
spccache.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
syscache.c Revert "Logical decoding of sequences" 2022-04-07 20:06:36 +02:00
ts_cache.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
typcache.c Update copyright for 2022 2022-01-07 19:04:57 -05:00