mirror of
https://github.com/postgres/postgres.git
synced 2026-04-15 22:10:45 -04:00
ecae097252
Because we assume that int64 and double have the same alignment requirement, AIX's default behavior that alignof(double) = 4 while alignof(int64) = 8 is a headache. There are two issues: 1. We align both int8 and float8 tuple columns per ALIGNOF_DOUBLE, which is an ancient choice that can't be undone without breaking pg_upgrade and creating some subtle SQL-level compatibility issues too. However, the cost of that is just some marginal inefficiency in fetching int8 values, which can't be too awful if the platform architects were willing to pay the same costs for fetching float8s. So our decision is to leave that alone. This patch makes our alignment choices the same as they were pre-v17, namely that ALIGNOF_DOUBLE and ALIGNOF_INT64_T are whatever the compiler prefers and then MAXIMUM_ALIGNOF is the larger of the two. (On all supported platforms other than AIX, all three values will be the same.) 2. We need to overlay C structs onto catalog tuples, and int8 fields in those struct declarations may not be aligned to match this rule. In the old branches we had some annoying rules about ordering catalog columns to avoid alignment problems, but nobody wants to resurrect those. However, there's a better answer: make the compiler construe those struct declarations the way we need it to by using the pack(N) pragma. This requires no manual effort to maintain going forward; we only have to insert the pragma into all the catalog *.h files. (As the catalogs stand at this writing, nothing actually changes because we've not moved any affected columns since v16; hence no catversion bump is required. The point of this is to not have to worry about the issue going forward.) We did not have this option when the AIX port was first made. This patch depends on the C99 feature _Pragma(), as well as the pack(N) pragma which dates to somewhere around gcc 4.0, and probably doesn't exist in xlc at all. But now that we've agreed to toss xlc support out the window, there doesn't seem to be a reason not to go this way. In passing, I got rid of LONGALIGN[_DOWN] along with the configure probes for ALIGNOF_LONG. We were not using those anywhere and it seems highly unlikely that we'd do so in future. Instead supply INT64ALIGN[_DOWN], which isn't used either but at least could have a good reason to be used. Discussion: https://postgr.es/m/1127261.1769649624@sss.pgh.pa.us
98 lines
3.7 KiB
C
98 lines
3.7 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* pg_index.h
|
|
* definition of the "index" system catalog (pg_index)
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2026, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/catalog/pg_index.h
|
|
*
|
|
* NOTES
|
|
* The Catalog.pm module reads this file and derives schema
|
|
* information.
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PG_INDEX_H
|
|
#define PG_INDEX_H
|
|
|
|
#include "catalog/genbki.h"
|
|
#include "catalog/pg_index_d.h" /* IWYU pragma: export */
|
|
|
|
/* ----------------
|
|
* pg_index definition. cpp turns this into
|
|
* typedef struct FormData_pg_index.
|
|
* ----------------
|
|
*/
|
|
BEGIN_CATALOG_STRUCT
|
|
|
|
CATALOG(pg_index,2610,IndexRelationId) BKI_SCHEMA_MACRO
|
|
{
|
|
Oid indexrelid BKI_LOOKUP(pg_class); /* OID of the index */
|
|
Oid indrelid BKI_LOOKUP(pg_class); /* OID of the relation it
|
|
* indexes */
|
|
int16 indnatts; /* total number of columns in index */
|
|
int16 indnkeyatts; /* number of key columns in index */
|
|
bool indisunique; /* is this a unique index? */
|
|
bool indnullsnotdistinct; /* null treatment in unique index */
|
|
bool indisprimary; /* is this index for primary key? */
|
|
bool indisexclusion; /* is this index for exclusion constraint? */
|
|
bool indimmediate; /* is uniqueness enforced immediately? */
|
|
bool indisclustered; /* is this the index last clustered by? */
|
|
bool indisvalid; /* is this index valid for use by queries? */
|
|
bool indcheckxmin; /* must we wait for xmin to be old? */
|
|
bool indisready; /* is this index ready for inserts? */
|
|
bool indislive; /* is this index alive at all? */
|
|
bool indisreplident; /* is this index the identity for replication? */
|
|
|
|
/* variable-length fields start here, but we allow direct access to indkey */
|
|
int2vector indkey BKI_FORCE_NOT_NULL; /* column numbers of indexed cols,
|
|
* or 0 */
|
|
|
|
#ifdef CATALOG_VARLEN
|
|
oidvector indcollation BKI_LOOKUP_OPT(pg_collation) BKI_FORCE_NOT_NULL; /* collation identifiers */
|
|
oidvector indclass BKI_LOOKUP(pg_opclass) BKI_FORCE_NOT_NULL; /* opclass identifiers */
|
|
int2vector indoption BKI_FORCE_NOT_NULL; /* per-column flags
|
|
* (AM-specific meanings) */
|
|
pg_node_tree indexprs; /* expression trees for index attributes that
|
|
* are not simple column references; one for
|
|
* each zero entry in indkey[] */
|
|
pg_node_tree indpred; /* expression tree for predicate, if a partial
|
|
* index; else NULL */
|
|
#endif
|
|
} FormData_pg_index;
|
|
|
|
END_CATALOG_STRUCT
|
|
|
|
/* ----------------
|
|
* Form_pg_index corresponds to a pointer to a tuple with
|
|
* the format of pg_index relation.
|
|
* ----------------
|
|
*/
|
|
typedef FormData_pg_index *Form_pg_index;
|
|
|
|
DECLARE_TOAST_WITH_MACRO(pg_index, 6351, 6352, PgIndexToastTable, PgIndexToastIndex);
|
|
|
|
DECLARE_INDEX(pg_index_indrelid_index, 2678, IndexIndrelidIndexId, pg_index, btree(indrelid oid_ops));
|
|
DECLARE_UNIQUE_INDEX_PKEY(pg_index_indexrelid_index, 2679, IndexRelidIndexId, pg_index, btree(indexrelid oid_ops));
|
|
|
|
MAKE_SYSCACHE(INDEXRELID, pg_index_indexrelid_index, 64);
|
|
|
|
/* indkey can contain zero (InvalidAttrNumber) to represent expressions */
|
|
DECLARE_ARRAY_FOREIGN_KEY_OPT((indrelid, indkey), pg_attribute, (attrelid, attnum));
|
|
|
|
#ifdef EXPOSE_TO_CLIENT_CODE
|
|
|
|
/*
|
|
* Index AMs that support ordered scans must support these two indoption
|
|
* bits. Otherwise, the content of the per-column indoption fields is
|
|
* open for future definition.
|
|
*/
|
|
#define INDOPTION_DESC 0x0001 /* values are in reverse order */
|
|
#define INDOPTION_NULLS_FIRST 0x0002 /* NULLs are first instead of last */
|
|
|
|
#endif /* EXPOSE_TO_CLIENT_CODE */
|
|
|
|
#endif /* PG_INDEX_H */
|