Tom Lane b43110869f Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not. ... Commit 2489d76c4 removed some logic from pullup_replace_vars() that avoided wrapping a PlaceHolderVar around a pulled-up subquery output expression if the expression could be proven to go to NULL anyway (because it contained Vars or PHVs of the pulled-up relation and did not contain non-strict constructs). But removing that logic turns out to cause performance regressions in some cases, because the extra PHV blocks subexpression folding, and will do so even if outer-join reduction later turns it into a no-op with no phnullingrels bits. This can for example prevent an expression from being matched to an index. The reason for always adding a PHV was to ensure we had someplace to put the varnullingrels marker bits of the Var being replaced. However, it turns out we can optimize in exactly the same cases that the previous code did, because we can instead attach the needed varnullingrels bits to the contained Var(s)/PHV(s). This is not a complete solution --- it would be even better if we could remove PHVs after reducing them to no-ops. It doesn't look practical to back-patch such an improvement, but this change seems safe and at least gets rid of the performance-regression cases. Per complaint from Nikhil Raj. Back-patch to v16 where the problem appeared. Discussion: https://postgr.es/m/CAG1ps1xvnTZceKK24OUfMKLPvDP2vjT-d+F2AOCWbw_v3KeEgg@mail.gmail.com		2024-08-30 12:42:13 -04:00
..
Makefile	SEARCH and CYCLE clauses	2021-02-01 14:32:51 +01:00
meson.build	Update copyright for 2024	2024-01-03 20:49:05 -05:00
rewriteDefine.c	Remove unused #include's from backend .c files	2024-03-04 12:02:20 +01:00
rewriteHandler.c	Message style improvements	2024-08-29 14:33:18 +02:00
rewriteManip.c	Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not.	2024-08-30 12:42:13 -04:00
rewriteRemove.c	Remove unused #include's from backend .c files	2024-03-04 12:02:20 +01:00
rewriteSearchCycle.c	Make the order of the header file includes consistent	2024-03-13 15:07:00 +01:00
rewriteSupport.c	Remove unused #include's from backend .c files	2024-03-04 12:02:20 +01:00
rowsecurity.c	Add RETURNING support to MERGE.	2024-03-17 13:58:59 +00:00