postgresql/src/port
Tom Lane a69f5697ae In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat.
This fixes a performance problem introduced by commit 6d7547c21.
ERROR_ACCESS_DENIED is returned in some other cases besides the
delete-pending case considered by that commit; notably, if the
given path names a directory instead of a plain file.  In that
case we'll uselessly loop for 1 second before returning the
failure condition.  That slows down some usage scenarios enough
to cause test timeout failures on our Windows buildfarm critters.

To fix, try to stat() the file, and sleep/loop only if that fails.
It will fail in the delete-pending case, and also in the case where
the deletion completed before we could stat(), so we have the cases
where we want to loop covered.  In the directory case, the stat()
should succeed, letting us exit without a wait.

One case where we'll still wait uselessly is if the access-denied
problem pertains to a directory in the given pathname.  But we don't
expect that to happen in any performance-critical code path.

There might be room to refine this further, but I'll push it now
in hopes of making the buildfarm green again.

Back-patch, like the preceding commit.

Alexander Lakhin and Tom Lane

Discussion: https://postgr.es/m/23073.1576626626@sss.pgh.pa.us
2019-12-21 17:39:36 -05:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
chklocale.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
crypt.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
dirent.c Fix error handling of readdir() port implementation on first file lookup 2019-03-04 09:50:06 +09:00
dirmod.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
erand48.c Fix latent problem with pg_jrand48(). 2018-12-28 14:08:35 -05:00
fls.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
fseeko.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getaddrinfo.c Clean up assorted misuses of snprintf()'s result value. 2018-08-15 16:29:32 -04:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getopt_long.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
getpeereid.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getrusage.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
gettimeofday.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
inet_aton.c Initial pgindent run with pg_bsd_indent version 2.0. 2017-06-21 14:39:04 -04:00
inet_net_ntop.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
isinf.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
kill.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
Makefile Replace PostmasterRandom() with a stronger source, second attempt. 2016-12-05 13:42:59 +02:00
mkdtemp.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
noblock.c Avoid depending on non-POSIX behavior of fcntl(2). 2017-04-21 15:56:16 -04:00
open.c In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat. 2019-12-21 17:39:36 -05:00
path.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
pg_crc32c_choose.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_crc32c_sb8.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pg_crc32c_sse42.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pg_strong_random.c Guard against rare RAND_bytes() failures in pg_strong_random(). 2018-07-20 08:58:37 +01:00
pgcheckdir.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pgstrcasecmp.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pqsignal.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
qsort_arg.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
quotes.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
random.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
README Refer to OS X as "macOS", except for the port name which is still "darwin". 2016-09-25 15:40:57 -04:00
rint.c Upgrade src/port/rint.c to be POSIX-compliant. 2015-03-25 15:54:18 -04:00
snprintf.c Set snprintf.c's maximum number of NL arguments to be 31. 2018-10-02 12:41:28 -04:00
sprompt.c Fix simple_prompt() to disable echo on Windows when stdin != terminal. 2018-05-23 19:04:34 -04:00
srandom.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
system.c Remove useless duplicate inclusions of system header files. 2017-02-25 16:12:55 -05:00
tar.c Allow pg_basebackup to stream transaction log in tar mode 2016-10-23 15:23:11 +02:00
thread.c Initial pgindent run with pg_bsd_indent version 2.0. 2017-06-21 14:39:04 -04:00
unsetenv.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32error.c Initial pgindent run with pg_bsd_indent version 2.0. 2017-06-21 14:39:04 -04:00
win32security.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
win32setlocale.c Deal with yet another issue related to "Norwegian (Bokmål)" locale. 2019-10-21 14:18:38 -04:00
win32ver.rc Stamp 10.11. 2019-11-11 17:07:14 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.