upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-04-10 19:47:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/interfaces/ecpg
History
Tom Lane d30d27a528 Client-side fixes for delayed NOTIFY receipt. 
PQnotifies() is defined to just process already-read data, not try to read
any more from the socket.  (This is a debatable decision, perhaps, but I'm
hesitant to change longstanding library behavior.)  The documentation has
long recommended calling PQconsumeInput() before PQnotifies() to ensure
that any already-arrived message would get absorbed and processed.
However, psql did not get that memo, which explains why it's not very
reliable about reporting notifications promptly.

Also, most (not quite all) callers called PQconsumeInput() just once before
a PQnotifies() loop.  Taking this recommendation seriously implies that we
should do PQconsumeInput() before each call.  This is more important now
that we have "payload" strings in notification messages than it was before;
that increases the probability of having more than one packet's worth
of notify messages.  Hence, adjust code as well as documentation examples
to do it like that.

Back-patch to 9.5 to match related server fixes.  In principle we could
probably go back further with these changes, but given lack of field
complaints I doubt it's worthwhile.

Discussion: https://postgr.es/m/CAOYf6ec-TmRYjKBXLLaGaB-jrd=mjG1Hzn1a1wufUAR39PQYhw@mail.gmail.com
2018-10-19 22:22:57 -04:00
..
compatlib Prevent accidental linking of system-supplied copies of libpq.so etc. 2018-04-03 16:26:05 -04:00
ecpglib Client-side fixes for delayed NOTIFY receipt. 2018-10-19 22:22:57 -04:00
include Add PGTYPESchar_free() to avoid cross-module problems on Windows. 2018-06-18 18:33:53 +12:00
pgtypeslib Clean up assorted misuses of snprintf()'s result value. 2018-08-15 16:29:32 -04:00
preproc Translation updates 2018-10-08 12:03:54 +02:00
test Add PGTYPESchar_free() to avoid cross-module problems on Windows. 2018-06-18 18:33:53 +12:00
Makefile Fix parallel make risk with new check temp-install setup 2015-04-29 20:34:22 -04:00
README.dynSQL Fix whitespace issues found by git diff --check, add gitattributes 2013-11-10 14:48:29 -05:00

README.dynSQL 

src/interfaces/ecpg/README.dynSQL

descriptor statements have the following shortcomings

- input descriptors (USING DESCRIPTOR <name>) are not supported

  Reason: to fully support dynamic SQL the frontend/backend communication
          should change to recognize input parameters.
          Since this is not likely to happen in the near future and you
          can cover the same functionality with the existing infrastructure
          (using s[n]printf), I'll leave the work to someone else.