mirror of
https://github.com/postgres/postgres.git
synced 2026-06-16 12:09:17 -04:00
cd7b204b2d
Nothing is to be gained from using pgrepack outside of REPACK (CONCURRENTLY), and it leads to assertion failures in assertion-enabled builds, and to crashes due to bogus memory lifetime in production builds. Reject attempts to do that with a clean error report. Clean up the nearby code a tad while at it. The only functional changes in that are that the output_writer_private context is allocated and partially filled by the pgrepack output plugin; and that ->relid therein is now always present (rather than only in assertion-enabled builds). Other than that it's just minor code rearrangement and added comments. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: Nikita Kalinin <n.kalinin@postgrespro.ru> Suggested-by: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Antonin Houska <ah@cybertec.at> (older version) Reviewed-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com> (older version) Discussion: https://postgr.es/m/19500-38a02529a69353a5@postgresql.org |
||
|---|---|---|
| .. | ||
| binary.out | ||
| catalog_change_snapshot.out | ||
| concurrent_ddl_dml.out | ||
| concurrent_stream.out | ||
| ddl.out | ||
| decoding_in_xact.out | ||
| decoding_into_rel.out | ||
| delayed_startup.out | ||
| invalidation_distribution.out | ||
| messages.out | ||
| mxact.out | ||
| oldest_xmin.out | ||
| ondisk_startup.out | ||
| parallel_session_origin.out | ||
| permissions.out | ||
| prepared.out | ||
| repack.out | ||
| replorigin.out | ||
| rewrite.out | ||
| skip_snapshot_restore.out | ||
| slot.out | ||
| slot_creation_error.out | ||
| snapshot_transfer.out | ||
| spill.out | ||
| stats.out | ||
| stream.out | ||
| subxact_without_top.out | ||
| time.out | ||
| toast.out | ||
| truncate.out | ||
| twophase.out | ||
| twophase_snapshot.out | ||
| twophase_stream.out | ||
| xact.out | ||