postgresql/contrib
Tom Lane b7547166fe Fix multiple bugs in contrib/pgstattuple's pgstatindex() function.
Dead or half-dead index leaf pages were incorrectly reported as live, as a
consequence of a code rearrangement I made (during a moment of severe brain
fade, evidently) in commit d287818eb5.

The index metapage was not counted in index_size, causing that result to
not agree with the actual index size on-disk.

Index root pages were not counted in internal_pages, which is inconsistent
compared to the case of a root that's also a leaf (one-page index), where
the root would be counted in leaf_pages.  Aside from that inconsistency,
this could lead to additional transient discrepancies between the reported
page counts and index_size, since it's possible for pgstatindex's scan to
see zero or multiple pages marked as BTP_ROOT, if the root moves due to
a split during the scan.  With these fixes, index_size will always be
exactly one page more than the sum of the displayed page counts.

Also, the index_size result was incorrectly documented as being measured in
pages; it's always been measured in bytes.  (While fixing that, I couldn't
resist doing some small additional wordsmithing on the pgstattuple docs.)

Including the metapage causes the reported index_size to not be zero for
an empty index.  To preserve the desired property that the pgstattuple
regression test results are platform-independent (ie, BLCKSZ configuration
independent), scale the index_size result in the regression tests.

The documentation issue was reported by Otsuka Kenji, and the inconsistent
root page counting by Peter Geoghegan; the other problems noted by me.
Back-patch to all supported branches, because this has been broken for
a long time.
2016-02-18 15:40:35 -05:00
..
adminpack Create function prototype as part of PG_FUNCTION_INFO_V1 macro 2014-04-18 00:03:19 -04:00
auth_delay Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds. 2012-11-18 17:15:06 -05:00
auto_explain Print planning time only in EXPLAIN ANALYZE, not plain EXPLAIN. 2014-10-15 18:50:16 -04:00
btree_gin Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
btree_gist Fix misc typos. 2015-09-05 11:36:24 +03:00
chkpass Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:13 -05:00
citext Fix incorrect declaration of citext's regexp_matches() functions. 2015-05-05 15:50:53 -04:00
cube Fix misc typos. 2015-09-05 11:36:24 +03:00
dblink Fix volatile-safety issue in dblink's materializeQueryResult(). 2015-01-26 15:17:36 -05:00
dict_int Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
dict_xsyn Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
dummy_seclabel Update copyright for 2014 2014-01-07 16:05:30 -05:00
earthdistance Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
file_fdw Fix contrib/file_fdw's expected file 2015-03-06 11:47:09 -03:00
fuzzystrmatch Add missing va_end() call to a early exit in dmetaphone.c's StringAt(). 2015-01-04 15:35:46 +01:00
hstore Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. 2016-02-03 01:39:08 -05:00
intagg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
intarray Prevent stack overflow in query-type functions. 2015-10-05 10:06:34 -04:00
isn contrib/isn now needs a .gitignore file. 2015-08-02 23:57:47 -04:00
lo Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
ltree Prevent stack overflow in query-type functions. 2015-10-05 10:06:34 -04:00
oid2name pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pageinspect Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
passwordcheck Update copyright for 2014 2014-01-07 16:05:30 -05:00
pg_archivecleanup pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pg_buffercache Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
pg_freespacemap Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
pg_prewarm Add interrupt checks to contrib/pg_prewarm. 2014-11-12 21:06:32 +01:00
pg_standby pg_standby: Avoid writing one byte beyond the end of the buffer. 2015-01-15 09:29:41 -05:00
pg_stat_statements Improve contrib/pg_stat_statements' handling of garbage collection failure. 2015-10-04 17:58:30 -04:00
pg_test_fsync Avoid file descriptor leak in pg_test_fsync. 2014-11-19 12:13:14 -05:00
pg_test_timing Correctly handle test durations of more than 2147s in pg_test_timing. 2015-01-04 15:52:52 +01:00
pg_trgm Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:13 -05:00
pg_upgrade Fix spelling mistake. 2016-01-14 23:15:27 -05:00
pg_upgrade_support Create function prototype as part of PG_FUNCTION_INFO_V1 macro 2014-04-18 00:03:19 -04:00
pg_xlogdump Sort $(wildcard) output where needed for reproducible build output. 2016-01-05 15:47:05 -05:00
pgbench pgbench: avoid FD_ISSET on an invalid file descriptor 2016-02-15 20:33:43 -03:00
pgcrypto Add forgotten CHECK_FOR_INTERRUPT calls in pgcrypto's crypt() 2015-12-27 13:03:19 -03:00
pgrowlocks Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
pgstattuple Fix multiple bugs in contrib/pgstattuple's pgstatindex() function. 2016-02-18 15:40:35 -05:00
postgres_fdw postgres_fdw: Avoid possible misbehavior when RETURNING tableoid column only. 2016-02-04 22:27:47 -05:00
seg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
sepgsql Fix sepgsql regression tests. 2015-08-30 11:09:31 -07:00
spi Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
sslinfo Fix error message wording in previous sslinfo commit 2015-09-08 11:10:20 -03:00
start-scripts doc: Reflect renaming of Mac OS X to OS X 2014-09-09 13:58:50 -04:00
tablefunc Handle unexpected query results, especially NULLs, safely in connectby(). 2015-01-29 20:18:37 -05:00
tcn pgindent run for 9.4 2014-05-06 12:12:18 -04:00
test_decoding Improve errhint() about replication slot naming restrictions. 2015-10-03 15:29:28 +02:00
test_parser Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
test_shm_mq pgindent run for 9.4 2014-05-06 12:12:18 -04:00
tsearch2 Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
unaccent Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
uuid-ossp Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
vacuumlo Centralize getopt-related declarations in a new header file pg_getopt.h. 2014-02-15 14:31:30 -05:00
worker_spi worker_spi: Initialize bgw_notify_pid in all cases. 2014-05-26 22:56:28 -04:00
xml2 Free libxml2/libxslt resources in a safer order. 2014-11-27 11:12:47 -05:00
contrib-global.mk Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
Makefile Support BSD and e2fsprogs UUID libraries alongside OSSP UUID library. 2014-05-27 19:42:08 -04:00
README Rename 'gmake' to 'make' in docs and recommended commands 2014-02-12 17:29:19 -05:00

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.