mirror of
https://github.com/postgres/postgres.git
synced 2026-04-22 06:37:06 -04:00
d3b0a23a20
This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the problem seems to have been confusion between the task of preserving dropped-column status and the task of preserving frozenxid status. Those are required for distinct sets of relkinds, and the reasoning was entirely undocumented in the source code. In hopes of forestalling future errors of the same kind, try to improve the commentary in this area. In passing, also improve the remarkably unhelpful comments around pg_upgrade's set_frozenxids(). That's not actually buggy AFAICS, but good luck figuring out what it does from the old comments. Per report from Claudio Freire. It appears that bug #14852 from Alexey Ermakov is an earlier report of the same issue, and there may be other cases that we failed to identify at the time. Patch by me based on analysis by Andres Freund. The bug dates back to the introduction of matviews, so back-patch to all supported branches. Discussion: https://postgr.es/m/CAGTBQpbrY9CdRGGhyBZ9yqY4jWaGC85rUF4X+R7d-aim=mBNsw@mail.gmail.com Discussion: https://postgr.es/m/20171013115320.28049.86457@wrigleys.postgresql.org |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| check.c | ||
| controldata.c | ||
| dump.c | ||
| exec.c | ||
| file.c | ||
| function.c | ||
| IMPLEMENTATION | ||
| info.c | ||
| Makefile | ||
| option.c | ||
| page.c | ||
| parallel.c | ||
| pg_upgrade.c | ||
| pg_upgrade.h | ||
| relfilenode.c | ||
| server.c | ||
| tablespace.c | ||
| test.sh | ||
| TESTING | ||
| util.c | ||
| version.c | ||
| version_old_8_3.c | ||