postgresql

mirror of https://github.com/postgres/postgres.git synced 2026-04-15 22:10:45 -04:00

History

Dean Rasheed 91ad1bdef8 Fix concurrent update trigger issues with MERGE in a CTE. If a MERGE inside a CTE attempts an UPDATE or DELETE on a table with BEFORE ROW triggers, and a concurrent UPDATE or DELETE happens, the merge code would fail (crashing in the case of an UPDATE action, and potentially executing the wrong action for a DELETE action). This is the same issue that `9321c79c86` attempted to fix, except now for a MERGE inside a CTE. As noted in `9321c79c86`, what needs to happen is for the trigger code to exit early, returning the TM_Result and TM_FailureData information to the merge code, if a concurrent modification is detected, rather than attempting to do an EPQ recheck. The merge code will then do its own rechecking, and rescan the action list, potentially executing a different action in light of the concurrent update. In particular, the trigger code must never call ExecGetUpdateNewTuple() for MERGE, since that is bound to fail because MERGE has its own per-action projection information. Commit `9321c79c86` did this using estate->es_plannedstmt->commandType in the trigger code to detect that a MERGE was being executed, which is fine for a plain MERGE command, but does not work for a MERGE inside a CTE. Fix by passing that information to the trigger code as an additional parameter passed to ExecBRUpdateTriggers() and ExecBRDeleteTriggers(). Back-patch as far as v17 only, since MERGE cannot appear inside a CTE prior to that. Additionally, take care to preserve the trigger ABI in v17 (though not in v18, which is still in beta). Bug: #18986 Reported-by: Yaroslav Syrytsia <me@ys.lc> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/18986-e7a8aac3d339fa47@postgresql.org Backpatch-through: 17		2025-07-18 10:01:31 +01:00
..
authentication	Fix an assortment of typos	2024-05-04 02:33:25 +12:00
examples	Update copyright for 2024	2024-01-03 20:49:05 -05:00
icu	Address more review comments on commit `2d819a08a1`.	2024-03-18 11:58:13 -07:00
isolation	Fix concurrent update trigger issues with MERGE in a CTE.	2025-07-18 10:01:31 +01:00
kerberos	Move Kerberos module	2024-04-08 02:49:30 +03:00
ldap	Don't clobber test exit code at cleanup in LDAP/Kerberors tests	2024-04-07 20:21:27 +03:00
locale	Update copyright for 2024	2024-01-03 20:49:05 -05:00
mb
modules	Disable commit timestamps during bootstrap	2025-07-04 15:10:19 +09:00
perl	Fix cross-version upgrade test failure	2025-05-20 10:41:20 +03:00
recovery	Test that vacuum removes tuples older than OldestXmin	2025-06-24 09:21:55 -04:00
regress	Fix dumping of comments on invalid constraints on domains	2025-07-16 19:22:53 +02:00
ssl	Skip RSA-PSS ssl test when using LibreSSL.	2025-05-09 12:29:01 -04:00
subscription	Fix race condition in subscription TAP test 021_twophase	2025-05-26 17:28:40 +09:00
Makefile	Refactor PG_TEST_EXTRA logic in autoconf build	2022-09-20 11:24:16 -07:00
meson.build	Move libpq encryption negotiation tests	2024-04-12 19:52:37 +03:00
README

README

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

authentication/
  Tests for authentication (but see also below)

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

kerberos/
  Tests for Kerberos/GSSAPI authentication and encryption

ldap/
  Tests for LDAP-based authentication

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

subscription/
  Tests for logical replication