postgresql/src/backend/catalog
Heikki Linnakangas 713bce9484 Don't call CheckAttributeType() with InvalidOid on dropped cols
If CheckAttributeType() is called with InvalidOid, it performs a bunch
of pointless, futile syscache lookups with InvalidOid, but ultimately
tolerates it and has no effect. We were calling it with InvalidOid on
dropped columns, but it seems accidental that it works, so let's stop
doing it.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/93ce56cd-02a6-4db1-8224-c8999372facc@iki.fi
Backpatch-through: 14
2026-04-23 21:28:26 +03:00
..
aclchk.c Allow choosing specific grantors via GRANT/REVOKE ... GRANTED BY. 2026-03-19 11:41:39 -05:00
catalog.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
Catalog.pm Update copyright for 2026 2026-01-01 13:24:10 -05:00
dependency.c SQL Property Graph Queries (SQL/PGQ) 2026-03-16 10:14:18 +01:00
genbki.pl Reduce presence of syscache.h in src/include/ 2026-04-09 08:49:36 +09:00
heap.c Don't call CheckAttributeType() with InvalidOid on dropped cols 2026-04-23 21:28:26 +03:00
index.c Allow index_create to suppress index_build progress reporting 2026-04-05 13:34:08 +02:00
indexing.c Remove bits* typedefs. 2026-03-30 16:12:08 -05:00
information_schema.sql SQL Property Graph Queries (SQL/PGQ) 2026-03-16 10:14:18 +01:00
Makefile Update copyright for 2026 2026-01-01 13:24:10 -05:00
meson.build Update copyright for 2026 2026-01-01 13:24:10 -05:00
namespace.c Don't include proc.h in shm_mq.h 2026-02-27 10:53:47 +01:00
objectaccess.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
objectaddress.c Add missing Datum conversions 2026-04-20 07:22:16 +02:00
partition.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_aggregate.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_attrdef.c Stop including {brin,gin}_tuple.h in tuplesort.h 2026-01-12 18:09:49 +01:00
pg_cast.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_class.c SQL Property Graph Queries (SQL/PGQ) 2026-03-16 10:14:18 +01:00
pg_collation.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_constraint.c Reject ADD CONSTRAINT NOT NULL if name mismatches existing constraint 2026-02-03 12:33:29 +01:00
pg_conversion.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_db_role_setting.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_depend.c Harden _int_matchsel() against being attached to the wrong operator. 2026-02-09 10:14:22 -05:00
pg_enum.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_inherits.c Don't include storage/lock.h in so many headers 2026-03-24 17:11:12 +01:00
pg_largeobject.c Stop including {brin,gin}_tuple.h in tuplesort.h 2026-01-12 18:09:49 +01:00
pg_namespace.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_operator.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_parameter_acl.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_proc.c Replace pg_mblen() with bounds-checked versions. 2026-02-09 12:44:04 +13:00
pg_publication.c Add target_relid parameter to pg_get_publication_tables(). 2026-04-02 11:34:50 -07:00
pg_range.c Record range constructor functions in pg_range 2026-01-22 15:56:29 +01:00
pg_shdepend.c Use fallthrough attribute instead of comment 2026-02-19 08:51:12 +01:00
pg_subscription.c Add missing Datum conversions 2026-04-20 07:22:16 +02:00
pg_tablespace.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
pg_type.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
sql_feature_packages.txt Update SQL features 2023-05-02 10:59:21 +02:00
sql_features.txt SQL Property Graph Queries (SQL/PGQ) 2026-03-16 10:14:18 +01:00
storage.c Update copyright for 2026 2026-01-01 13:24:10 -05:00
system_functions.sql Make cast function from circle to polygon error safe 2026-03-30 09:11:08 +02:00
system_views.sql Add pg_stat_autovacuum_scores system view. 2026-04-06 16:56:33 -05:00
toasting.c Avoid including vacuum.h in tableam.h and heapam.h. 2026-03-31 12:43:52 -05:00