mirror of
https://github.com/postgres/postgres.git
synced 2026-03-01 21:01:12 -05:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
44 lines
1.5 KiB
C
44 lines
1.5 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* copy.h
|
|
* Definitions for using the POSTGRES copy command.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/commands/copy.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef COPY_H
|
|
#define COPY_H
|
|
|
|
#include "nodes/execnodes.h"
|
|
#include "nodes/parsenodes.h"
|
|
#include "parser/parse_node.h"
|
|
#include "tcop/dest.h"
|
|
|
|
/* CopyStateData is private in commands/copy.c */
|
|
typedef struct CopyStateData *CopyState;
|
|
typedef int (*copy_data_source_cb) (void *outbuf, int minread, int maxread);
|
|
|
|
extern void DoCopy(ParseState *state, const CopyStmt *stmt,
|
|
int stmt_location, int stmt_len,
|
|
uint64 *processed);
|
|
|
|
extern void ProcessCopyOptions(ParseState *pstate, CopyState cstate, bool is_from, List *options);
|
|
extern CopyState BeginCopyFrom(ParseState *pstate, Relation rel, const char *filename,
|
|
bool is_program, copy_data_source_cb data_source_cb, List *attnamelist, List *options);
|
|
extern void EndCopyFrom(CopyState cstate);
|
|
extern bool NextCopyFrom(CopyState cstate, ExprContext *econtext,
|
|
Datum *values, bool *nulls, Oid *tupleOid);
|
|
extern bool NextCopyFromRawFields(CopyState cstate,
|
|
char ***fields, int *nfields);
|
|
extern void CopyFromErrorCallback(void *arg);
|
|
|
|
extern uint64 CopyFrom(CopyState cstate);
|
|
|
|
extern DestReceiver *CreateCopyDestReceiver(void);
|
|
|
|
#endif /* COPY_H */
|