mirror of
https://github.com/postgres/postgres.git
synced 2026-04-15 22:10:45 -04:00
f3bef03e7e
When a foreign-key constraint references another column of the same table, row updates will queue both the PK's ON UPDATE action and the FK's CHECK action in the same event. The ON UPDATE action must execute first, else the CHECK will check a non-final state of the row and possibly throw an inappropriate error, as seen in bug #6268 from Roman Lytovchenko. Now, the firing order of multiple triggers for the same event is determined by the sort order of their pg_trigger.tgnames, and the auto-generated names we use for FK triggers are "RI_ConstraintTrigger_NNNN" where NNNN is the trigger OID. So most of the time the firing order is the same as creation order, and so rearranging the creation order fixes it. This patch will fail to fix the problem if the OID counter wraps around or adds a decimal digit (eg, from 99999 to 100000) while we are creating the triggers for an FK constraint. Given the small odds of that, and the low usage of self-referential FKs, we'll live with that solution in the back branches. A better fix is to change the auto-generated names for FK triggers, but it seems unwise to do that in stable branches because there may be client code that depends on the naming convention. We'll fix it that way in HEAD in a separate patch. Back-patch to all supported branches, since this bug has existed for a long time. |
||
|---|---|---|
| .. | ||
| aggregatecmds.c | ||
| alter.c | ||
| analyze.c | ||
| async.c | ||
| cluster.c | ||
| comment.c | ||
| conversioncmds.c | ||
| copy.c | ||
| dbcommands.c | ||
| define.c | ||
| discard.c | ||
| explain.c | ||
| foreigncmds.c | ||
| functioncmds.c | ||
| indexcmds.c | ||
| lockcmds.c | ||
| Makefile | ||
| opclasscmds.c | ||
| operatorcmds.c | ||
| portalcmds.c | ||
| prepare.c | ||
| proclang.c | ||
| schemacmds.c | ||
| sequence.c | ||
| tablecmds.c | ||
| tablespace.c | ||
| trigger.c | ||
| tsearchcmds.c | ||
| typecmds.c | ||
| user.c | ||
| vacuum.c | ||
| vacuumlazy.c | ||
| variable.c | ||
| view.c | ||