mirror of
https://github.com/postgres/postgres.git
synced 2026-07-09 09:41:00 -04:00
cd7b204b2d
Nothing is to be gained from using pgrepack outside of REPACK (CONCURRENTLY), and it leads to assertion failures in assertion-enabled builds, and to crashes due to bogus memory lifetime in production builds. Reject attempts to do that with a clean error report. Clean up the nearby code a tad while at it. The only functional changes in that are that the output_writer_private context is allocated and partially filled by the pgrepack output plugin; and that ->relid therein is now always present (rather than only in assertion-enabled builds). Other than that it's just minor code rearrangement and added comments. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: Nikita Kalinin <n.kalinin@postgrespro.ru> Suggested-by: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Antonin Houska <ah@cybertec.at> (older version) Reviewed-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com> (older version) Discussion: https://postgr.es/m/19500-38a02529a69353a5@postgresql.org |
||
|---|---|---|
| .. | ||
| alter.h | ||
| async.h | ||
| collationcmds.h | ||
| comment.h | ||
| conversioncmds.h | ||
| copy.h | ||
| copyapi.h | ||
| copyfrom_internal.h | ||
| createas.h | ||
| dbcommands.h | ||
| dbcommands_xlog.h | ||
| defrem.h | ||
| discard.h | ||
| event_trigger.h | ||
| explain.h | ||
| explain_dr.h | ||
| explain_format.h | ||
| explain_state.h | ||
| extension.h | ||
| lockcmds.h | ||
| matview.h | ||
| policy.h | ||
| portalcmds.h | ||
| prepare.h | ||
| proclang.h | ||
| progress.h | ||
| propgraphcmds.h | ||
| publicationcmds.h | ||
| repack.h | ||
| repack_internal.h | ||
| schemacmds.h | ||
| seclabel.h | ||
| sequence.h | ||
| sequence_xlog.h | ||
| subscriptioncmds.h | ||
| tablecmds.h | ||
| tablespace.h | ||
| trigger.h | ||
| typecmds.h | ||
| user.h | ||
| vacuum.h | ||
| view.h | ||
| wait.h | ||