upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-02-25 10:50:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/test
History
Tom Lane 80f66a9ad0 Fix planner failure with full join in RHS of left join. 
Given a left join containing a full join in its righthand side, with
the left join's joinclause referencing only one side of the full join
(in a non-strict fashion, so that the full join doesn't get simplified),
the planner could fail with "failed to build any N-way joins" or related
errors.  This happened because the full join was seen as overlapping the
left join's RHS, and then recent changes within join_is_legal() caused
that function to conclude that the full join couldn't validly be formed.
Rather than try to rejigger join_is_legal() yet more to allow this,
I think it's better to fix initsplan.c so that the required join order
is explicit in the SpecialJoinInfo data structure.  The previous coding
there essentially ignored full joins, relying on the fact that we don't
flatten them in the joinlist data structure to preserve their ordering.
That's sufficient to prevent a wrong plan from being formed, but as this
example shows, it's not sufficient to ensure that the right plan will
be formed.  We need to work a bit harder to ensure that the right plan
looks sane according to the SpecialJoinInfos.

Per bug #14105 from Vojtech Rylko.  This was apparently induced by
commit 8703059c6 (though now that I've seen it, I wonder whether there
are related cases that could have failed before that); so back-patch
to all active branches.  Unfortunately, that patch also went into 9.0,
so this bug is a regression that won't be fixed in that branch.
2016-04-21 20:05:58 -04:00
..
examples Update copyright for 2016 2016-01-02 13:33:40 -05:00
isolation Replace printf format %i by %d 2016-04-08 12:42:58 -04:00
locale Fix omission of -X (--no-psqlrc) in some psql invocations. 2015-12-28 11:46:43 -05:00
mb Revert "Fix broken multibyte regression tests." 2016-01-26 08:29:15 +09:00
modules In recordExtensionInitPriv(), keep the scan til we're done with it 2016-04-15 21:57:15 -04:00
perl Add regression tests for multiple synchronous standbys. 2016-04-08 16:48:53 +09:00
recovery Make regression test for multiple synchronous standbys more stable. 2016-04-15 13:58:14 +09:00
regress Fix planner failure with full join in RHS of left join. 2016-04-21 20:05:58 -04:00
ssl Clean the last few TAP suite tmp_check directories. 2016-02-24 23:41:54 -05:00
thread Update copyright for 2016 2016-01-02 13:33:40 -05:00
Makefile Add a test framework for recovery 2016-02-26 16:13:30 -03:00
README Minor tweaks for new src/test/recovery 2016-02-29 18:16:59 -03:00

README 

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

thread/
  A thread-safety-testing utility used by configure