Alvaro Herrera 7e7c57bbb2 Fix dependency recording bug for partitioned PKs ... When DefineIndex recurses to create constraints on partitions, it needs to use the value returned by index_constraint_create to set up partition dependencies. However, in the course of fixing the DEPENDENCY_INTERNAL_AUTO mess, commit 1d92a0c9f7 introduced some code to that function that clobbered the return value, causing the recorded OID to be of the wrong object. Close examination of pg_depend after creating the tables leads to indescribable objects :-( My sin (in commit bdc3d7fa23, while preparing for DDL deparsing in event triggers) was to use a variable name for the return value that's typically used for throwaway objects in dependency-setting calls ("referenced"). Fix by changing the variable names to match extended practice (the return value is "myself" rather than "referenced".) The pg_upgrade test notices the problem (in an indirect way: the pg_dump outputs are in different order), but only if you create the objects in a specific way that wasn't being used in the existing tests. Add a stanza to leave some objects around that shows the bug. Catversion bump because preexisting databases might have bogus pg_depend entries. Discussion: https://postgr.es/m/20190318204235.GA30360@alvherre.pgsql		2019-03-21 18:34:29 -03:00
..
backend	Fix dependency recording bug for partitioned PKs	2019-03-21 18:34:29 -03:00
bin	Remove unused macro	2019-03-18 09:13:08 +01:00
common	Refactor more code logic to update the control file	2019-03-18 12:59:35 +09:00
fe_utils	More unconstify use	2019-02-13 11:50:16 +01:00
include	Improve error reporting for DROP FUNCTION/PROCEDURE/AGGREGATE/ROUTINE.	2019-03-21 11:52:08 -04:00
interfaces	Restructure libpq's handling of send failures.	2019-03-19 16:20:28 -04:00
makefiles	Move port-specific parts of with_temp_install to port makefile.	2019-02-04 18:54:56 +00:00
pl	PL/Tcl: Improve trigger tests organization	2019-03-15 12:42:07 +01:00
port	Fix error handling of readdir() port implementation on first file lookup	2019-03-04 09:49:06 +09:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Fix dependency recording bug for partitioned PKs	2019-03-21 18:34:29 -03:00
timezone	More unconstify use	2019-02-13 11:50:16 +01:00
tools	Get rid of jsonpath_gram.h and jsonpath_scanner.h	2019-03-20 11:13:34 +03:00
tutorial	SQL comment: remove extra word in heading comment	2019-01-25 18:57:21 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Revert attempts to use POPCNT etc instructions	2019-02-15 16:32:30 -03:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	Replace @postgresql.org with @lists.postgresql.org for mailinglists	2019-01-19 19:06:35 +01:00