postgresql/src/port
Michael Paquier 29b039e916 Fix POSIX compliance in pgwin32_unsetenv() for "name" argument
pgwin32_unsetenv() (compatibility routine of unsetenv() on Windows)
lacks the input validation that its sibling pgwin32_setenv() has.
Without these checks, calling unsetenv() with incorrect names crashes on
WIN32.  However, invalid names should be handled, failing on EINVAL.

This commit adds the same checks as setenv() to fail with EINVAL for a
"name" set to NULL, an empty string, or if '=' is included in the value,
per POSIX requirements.

Like 7ca37fb040, backpatch down to v14.  pgwin32_unsetenv() is defined
on REL_13_STABLE, but with the branch going EOL soon and the lack of
setenv() there for WIN32, nothing is done for v13.

Author: Bryan Green <dbryan.green@gmail.com>
Discussion: https://postgr.es/m/b6a1e52b-d808-4df7-87f7-2ff48d15003e@gmail.com
Backpatch-through: 14
2025-10-21 08:05:28 +09:00
..
.gitignore Build src/port files as a library with -fPIC, and use that in libpq. 2018-09-27 11:23:43 -04:00
bsearch_arg.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
chklocale.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
dirent.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
dirmod.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
explicit_bzero.c Make our usage of memset_s() conform strictly to the C11 standard. 2025-05-18 12:45:55 -04:00
getopt.c Restore missing line to copyright notice 2024-10-28 13:08:43 +02:00
getopt_long.c Teach in-tree getopt_long() to move non-options to the end of argv. 2023-07-12 20:34:39 -07:00
getpeereid.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
inet_aton.c Correct include file name in inet_aton fallback. 2017-10-01 17:41:00 -07:00
inet_net_ntop.c Remove configure probe for sockaddr_in6 and require AF_INET6. 2022-08-26 10:18:30 +12:00
kill.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
Makefile Add support for basic NUMA awareness 2025-04-07 23:08:17 +02:00
meson.build Add support for basic NUMA awareness 2025-04-07 23:08:17 +02:00
mkdtemp.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
noblock.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
open.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
path.c Avoid breaking SJIS encoding while de-backslashing Windows paths. 2025-01-29 14:24:36 -05:00
pg_bitutils.c Optimize popcount functions with ARM Neon intrinsics. 2025-03-28 14:49:35 -05:00
pg_crc32c_armv8.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pg_crc32c_armv8_choose.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pg_crc32c_loongarch.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pg_crc32c_sb8.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pg_crc32c_sse42.c Properly fix AVX-512 CRC calculation bug 2025-06-23 18:03:56 +07:00
pg_crc32c_sse42_choose.c Properly fix AVX-512 CRC calculation bug 2025-06-23 18:03:56 +07:00
pg_localeconv_r.c Fix incorrect year in some copyright notices 2025-05-19 09:46:52 +09:00
pg_numa.c Fix indentation in pg_numa code 2025-07-01 15:23:07 +02:00
pg_popcount_aarch64.c Fix typos and grammar in the code 2025-04-19 19:17:42 +09:00
pg_popcount_avx512.c Rename TRY_POPCNT_FAST to TRY_POPCNT_X86_64. 2025-03-28 12:27:47 -05:00
pg_strong_random.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pgcheckdir.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pgmkdirp.c Use strchr instead of strstr for single-char lookups 2025-07-23 12:02:55 +12:00
pgsleep.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pgstrcasecmp.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pgstrsignal.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
pqsignal.c Assert that wrapper_handler()'s argument is within expected range. 2025-03-07 15:23:09 -06:00
pthread-win32.h Clean up Windows-specific mutex code in libpq and ecpglib. 2024-02-09 11:11:39 -05:00
pthread_barrier_wait.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
qsort.c Use sort_template.h for qsort() and qsort_arg(). 2021-03-03 17:02:32 +13:00
qsort_arg.c Use sort_template.h for qsort() and qsort_arg(). 2021-03-03 17:02:32 +13:00
quotes.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
README Remove AIX support 2024-02-28 15:17:23 +04:00
snprintf.c Fix detection and handling of strchrnul() for macOS 15.4. 2025-04-01 16:50:09 -04:00
strerror.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
strnlen.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
strsep.c Add port/ replacement for strsep() 2024-07-22 09:50:30 +02:00
strtof.c Fix pg_strtof() to not crash on NULL endptr. 2025-03-01 14:22:56 -05:00
system.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
tar.c Add and use symbolic constants for tar header offsets and file types. 2023-08-01 13:50:42 -04:00
timingsafe_bcmp.c Add timingsafe_bcmp(), for constant-time memory comparison 2025-04-02 15:32:40 +03:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32common.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32dlopen.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32env.c Fix POSIX compliance in pgwin32_unsetenv() for "name" argument 2025-10-21 08:05:28 +09:00
win32error.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32fdatasync.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32fseek.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32gai_strerror.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32getrusage.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32gettimeofday.c Simplify gettimeofday for Windows. 2022-08-07 12:35:36 +12:00
win32link.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32ntdll.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32pread.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32pwrite.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32security.c Fix incorrect message-printing in win32security.c. 2025-10-13 17:56:45 -04:00
win32setlocale.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32stat.c Update copyright for 2025 2025-01-01 11:21:55 -05:00
win32ver.rc Update copyright for 2025 2025-01-01 11:21:55 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter strlcat.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export
list to control the symbols exported by libpq.