Tom Lane 7d344f0041 Fix index-only scan plans, take 2. ... Commit 4ace45677 failed to fix the problem fully, because the same issue of attempting to fetch a non-returnable index column can occur when rechecking the indexqual after using a lossy index operator. Moreover, it broke EXPLAIN for such indexquals (which indicates a gap in our test cases :-(). Revert the code changes of 4ace45677 in favor of adding a new field to struct IndexOnlyScan, containing a version of the indexqual that can be executed against the index-returned tuple without using any non-returnable columns. (The restrictions imposed by check_index_only guarantee this is possible, although we may have to recompute indexed expressions.) Support construction of that during setrefs.c processing by marking IndexOnlyScan.indextlist entries as resjunk if they can't be returned, rather than removing them entirely. (We could alternatively require setrefs.c to look up the IndexOptInfo again, but abusing resjunk this way seems like a reasonably safe way to avoid needing to do that.) This solution isn't great from an API-stability standpoint: if there are any extensions out there that build IndexOnlyScan structs directly, they'll be broken in the next minor releases. However, only a very invasive extension would be likely to do such a thing. There's no change in the Path representation, so typical planner extensions shouldn't have a problem. As before, back-patch to all supported branches. Discussion: https://postgr.es/m/3179992.1641150853@sss.pgh.pa.us Discussion: https://postgr.es/m/17350-b5bdcf476e5badbb@postgresql.org		2022-01-03 15:42:27 -05:00
..
backend	Fix index-only scan plans, take 2.	2022-01-03 15:42:27 -05:00
bin	Move into separate file all the SQL queries used in pg_upgrade tests	2021-12-02 10:31:48 +09:00
common	Fix buffer overrun in unicode string normalization with empty input	2021-11-11 15:02:06 +09:00
fe_utils	Fix incautious handling of possibly-miscoded strings in client code.	2021-06-07 14:15:25 -04:00
include	Fix index-only scan plans, take 2.	2022-01-03 15:42:27 -05:00
interfaces	backpatch "Set application_name per-test in isolation and ecpg tests."	2021-12-13 11:41:55 -08:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Remove unneeded Python includes	2021-11-25 14:32:43 +01:00
port	Stamp 10.19.	2021-11-08 17:05:38 -05:00
template	Further tweaking of PG_SYSROOT heuristics for macOS.	2021-01-20 12:07:46 -05:00
test	Fix index-only scan plans, take 2.	2022-01-03 15:42:27 -05:00
timezone	Update time zone data files to tzdata release 2021e.	2021-10-29 11:38:58 -04:00
tools	Adjust behavior of some env settings for the TAP tests of MSVC	2021-12-15 10:40:22 +09:00
tutorial	tutorial: land height is "elevation", not "altitude"	2021-03-10 20:25:18 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Build src/test/isolation during "make" and "make install".	2017-11-22 20:18:52 -08:00
Makefile.global.in	Fix prove_installcheck to use correct paths when used with PGXS	2021-07-01 08:48:24 -04:00
Makefile.shlib	makefile: use proper linker flags for C++ compiles	2020-03-31 22:26:11 -04:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00