mirror of
https://github.com/postgres/postgres.git
synced 2026-02-27 03:40:28 -05:00
546f7c2e38
The previous coding attempted to activate all the GUC settings specified in SET clauses, so that the function validator could operate in the GUC environment expected by the function body. However, this is problematic when restoring a dump, since the SET clauses might refer to database objects that don't exist yet. We already have the parameter check_function_bodies that's meant to prevent forward references in function definitions from breaking dumps, so let's change CREATE FUNCTION to not install the SET values if check_function_bodies is off. Authors of function validators were already advised not to make any "context sensitive" checks when check_function_bodies is off, if indeed they're checking anything at all in that mode. But extend the documentation to point out the GUC issue in particular. (Note that we still check the SET clauses to some extent; the behavior with !check_function_bodies is now approximately equivalent to what ALTER DATABASE/ROLE have been doing for awhile with context-dependent GUCs.) This problem can be demonstrated in all active branches, so back-patch all the way.
277 lines
6.9 KiB
PL/PgSQL
277 lines
6.9 KiB
PL/PgSQL
-- pg_regress should ensure that this default value applies; however
|
|
-- we can't rely on any specific default value of vacuum_cost_delay
|
|
SHOW datestyle;
|
|
|
|
-- SET to some nondefault value
|
|
SET vacuum_cost_delay TO 40;
|
|
SET datestyle = 'ISO, YMD';
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- SET LOCAL has no effect outside of a transaction
|
|
SET LOCAL vacuum_cost_delay TO 50;
|
|
SHOW vacuum_cost_delay;
|
|
SET LOCAL datestyle = 'SQL';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- SET LOCAL within a transaction that commits
|
|
BEGIN;
|
|
SET LOCAL vacuum_cost_delay TO 50;
|
|
SHOW vacuum_cost_delay;
|
|
SET LOCAL datestyle = 'SQL';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
COMMIT;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- SET should be reverted after ROLLBACK
|
|
BEGIN;
|
|
SET vacuum_cost_delay TO 60;
|
|
SHOW vacuum_cost_delay;
|
|
SET datestyle = 'German';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- Some tests with subtransactions
|
|
BEGIN;
|
|
SET vacuum_cost_delay TO 70;
|
|
SET datestyle = 'MDY';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
SAVEPOINT first_sp;
|
|
SET vacuum_cost_delay TO 80;
|
|
SHOW vacuum_cost_delay;
|
|
SET datestyle = 'German, DMY';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK TO first_sp;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
SAVEPOINT second_sp;
|
|
SET vacuum_cost_delay TO 90;
|
|
SET datestyle = 'SQL, YMD';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
SAVEPOINT third_sp;
|
|
SET vacuum_cost_delay TO 100;
|
|
SHOW vacuum_cost_delay;
|
|
SET datestyle = 'Postgres, MDY';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK TO third_sp;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK TO second_sp;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- SET LOCAL with Savepoints
|
|
BEGIN;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
SAVEPOINT sp;
|
|
SET LOCAL vacuum_cost_delay TO 30;
|
|
SHOW vacuum_cost_delay;
|
|
SET LOCAL datestyle = 'Postgres, MDY';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK TO sp;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- SET LOCAL persists through RELEASE (which was not true in 8.0-8.2)
|
|
BEGIN;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
SAVEPOINT sp;
|
|
SET LOCAL vacuum_cost_delay TO 30;
|
|
SHOW vacuum_cost_delay;
|
|
SET LOCAL datestyle = 'Postgres, MDY';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
RELEASE SAVEPOINT sp;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
ROLLBACK;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
-- SET followed by SET LOCAL
|
|
BEGIN;
|
|
SET vacuum_cost_delay TO 40;
|
|
SET LOCAL vacuum_cost_delay TO 50;
|
|
SHOW vacuum_cost_delay;
|
|
SET datestyle = 'ISO, DMY';
|
|
SET LOCAL datestyle = 'Postgres, MDY';
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
COMMIT;
|
|
SHOW vacuum_cost_delay;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
--
|
|
-- Test RESET. We use datestyle because the reset value is forced by
|
|
-- pg_regress, so it doesn't depend on the installation's configuration.
|
|
--
|
|
SET datestyle = iso, ymd;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
RESET datestyle;
|
|
SHOW datestyle;
|
|
SELECT '2006-08-13 12:34:56'::timestamptz;
|
|
|
|
--
|
|
-- Test DISCARD TEMP
|
|
--
|
|
CREATE TEMP TABLE reset_test ( data text ) ON COMMIT DELETE ROWS;
|
|
SELECT relname FROM pg_class WHERE relname = 'reset_test';
|
|
DISCARD TEMP;
|
|
SELECT relname FROM pg_class WHERE relname = 'reset_test';
|
|
|
|
--
|
|
-- Test DISCARD ALL
|
|
--
|
|
|
|
-- do changes
|
|
DECLARE foo CURSOR WITH HOLD FOR SELECT 1;
|
|
PREPARE foo AS SELECT 1;
|
|
LISTEN foo_event;
|
|
SET vacuum_cost_delay = 13;
|
|
CREATE TEMP TABLE tmp_foo (data text) ON COMMIT DELETE ROWS;
|
|
CREATE ROLE temp_reset_user;
|
|
SET SESSION AUTHORIZATION temp_reset_user;
|
|
-- look changes
|
|
SELECT pg_listening_channels();
|
|
SELECT name FROM pg_prepared_statements;
|
|
SELECT name FROM pg_cursors;
|
|
SHOW vacuum_cost_delay;
|
|
SELECT relname from pg_class where relname = 'tmp_foo';
|
|
SELECT current_user = 'temp_reset_user';
|
|
-- discard everything
|
|
DISCARD ALL;
|
|
-- look again
|
|
SELECT pg_listening_channels();
|
|
SELECT name FROM pg_prepared_statements;
|
|
SELECT name FROM pg_cursors;
|
|
SHOW vacuum_cost_delay;
|
|
SELECT relname from pg_class where relname = 'tmp_foo';
|
|
SELECT current_user = 'temp_reset_user';
|
|
DROP ROLE temp_reset_user;
|
|
|
|
--
|
|
-- search_path should react to changes in pg_namespace
|
|
--
|
|
|
|
set search_path = foo, public, not_there_initially;
|
|
select current_schemas(false);
|
|
create schema not_there_initially;
|
|
select current_schemas(false);
|
|
drop schema not_there_initially;
|
|
select current_schemas(false);
|
|
reset search_path;
|
|
|
|
--
|
|
-- Tests for function-local GUC settings
|
|
--
|
|
|
|
set work_mem = '3MB';
|
|
|
|
create function report_guc(text) returns text as
|
|
$$ select current_setting($1) $$ language sql
|
|
set work_mem = '1MB';
|
|
|
|
select report_guc('work_mem'), current_setting('work_mem');
|
|
|
|
alter function report_guc(text) set work_mem = '2MB';
|
|
|
|
select report_guc('work_mem'), current_setting('work_mem');
|
|
|
|
alter function report_guc(text) reset all;
|
|
|
|
select report_guc('work_mem'), current_setting('work_mem');
|
|
|
|
-- SET LOCAL is restricted by a function SET option
|
|
create or replace function myfunc(int) returns text as $$
|
|
begin
|
|
set local work_mem = '2MB';
|
|
return current_setting('work_mem');
|
|
end $$
|
|
language plpgsql
|
|
set work_mem = '1MB';
|
|
|
|
select myfunc(0), current_setting('work_mem');
|
|
|
|
alter function myfunc(int) reset all;
|
|
|
|
select myfunc(0), current_setting('work_mem');
|
|
|
|
set work_mem = '3MB';
|
|
|
|
-- but SET isn't
|
|
create or replace function myfunc(int) returns text as $$
|
|
begin
|
|
set work_mem = '2MB';
|
|
return current_setting('work_mem');
|
|
end $$
|
|
language plpgsql
|
|
set work_mem = '1MB';
|
|
|
|
select myfunc(0), current_setting('work_mem');
|
|
|
|
set work_mem = '3MB';
|
|
|
|
-- it should roll back on error, though
|
|
create or replace function myfunc(int) returns text as $$
|
|
begin
|
|
set work_mem = '2MB';
|
|
perform 1/$1;
|
|
return current_setting('work_mem');
|
|
end $$
|
|
language plpgsql
|
|
set work_mem = '1MB';
|
|
|
|
select myfunc(0);
|
|
select current_setting('work_mem');
|
|
select myfunc(1), current_setting('work_mem');
|
|
|
|
-- Normally, CREATE FUNCTION should complain about invalid values in
|
|
-- function SET options; but not if check_function_bodies is off,
|
|
-- because that creates ordering hazards for pg_dump
|
|
|
|
create function func_with_bad_set() returns int as $$ select 1 $$
|
|
language sql
|
|
set default_text_search_config = no_such_config;
|
|
|
|
set check_function_bodies = off;
|
|
|
|
create function func_with_bad_set() returns int as $$ select 1 $$
|
|
language sql
|
|
set default_text_search_config = no_such_config;
|
|
|
|
select func_with_bad_set();
|
|
|
|
reset check_function_bodies;
|