David Rowley 74530804fc Fix incorrect accessing of pfree'd memory in Memoize ... For pass-by-reference types, the code added in 0b053e78b, which aimed to resolve a memory leak, was overly aggressive in resetting the per-tuple memory context which could result in pfree'd memory being accessed resulting in failing to find previously cached results in the hash table. What was happening was prepare_probe_slot() was switching to the per-tuple memory context and calling ExecEvalExpr(). ExecEvalExpr() may have required a memory allocation. Both MemoizeHash_hash() and MemoizeHash_equal() were aggressively resetting the per-tuple context and after determining the hash value, the context would have gotten reset before MemoizeHash_equal() was called. This could have resulted in MemoizeHash_equal() looking at pfree'd memory. This is less likely to have caused issues on a production build as some other allocation would have had to have reused the pfree'd memory to overwrite it. Otherwise, the original contents would have been intact. However, this clearly caused issues on MEMORY_CONTEXT_CHECKING builds. Author: Tender Wang, Andrei Lepikhov Reported-by: Tender Wang (using SQLancer) Reviewed-by: Andrei Lepikhov, Richard Guo, David Rowley Discussion: https://postgr.es/m/CAHewXNnT6N6UJkya0z-jLFzVxcwGfeRQSfhiwA+NyLg-x8iGew@mail.gmail.com Backpatch-through: 14, where Memoize was added		2024-03-11 18:21:23 +13:00
..
backend	Fix incorrect accessing of pfree'd memory in Memoize	2024-03-11 18:21:23 +13:00
bin	Skip .DS_Store files in server side utils	2024-02-13 13:47:12 +01:00
common	Move is_valid_ascii() to ascii.h.	2024-01-29 12:09:08 -06:00
fe_utils	Don't spuriously report FD_SETSIZE exhaustion on Windows.	2023-10-14 15:54:49 -07:00
include	Revert "Fix parallel-safety check of expressions and predicate for index builds"	2024-03-07 08:31:04 +09:00
interfaces	Cope with a deficiency in OpenSSL 3.x's error reporting.	2024-03-07 19:37:51 -05:00
makefiles	Refactor DLSUFFIX handling	2022-03-25 08:56:02 +01:00
pl	Translation updates	2024-02-05 14:47:58 +01:00
port	Clean up Windows-specific mutex code in libpq and ecpglib.	2024-02-09 11:11:39 -05:00
template	On NetBSD, force dynamic symbol resolution at postmaster start.	2022-08-30 17:28:55 -04:00
test	Fix incorrect accessing of pfree'd memory in Memoize	2024-03-11 18:21:23 +13:00
timezone	Update time zone data files to tzdata release 2024a.	2024-02-01 15:57:53 -05:00
tools	Fix various issues with ALTER TEXT SEARCH CONFIGURATION	2024-01-31 13:16:46 +09:00
tutorial	Doc: sync src/tutorial/basics.source with SGML documentation.	2022-11-19 13:09:14 -05:00
.gitignore
DEVELOPERS
Makefile	Remove the option to build thread_test.c outside configure.	2020-10-21 12:08:48 -04:00
Makefile.global.in	Suppress macOS warnings about duplicate libraries in link commands.	2023-09-29 14:07:30 -04:00
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2023-09-26 21:06:21 -04:00
nls-global.mk	Improve frontend error logging style.	2022-04-08 14:55:14 -04:00