postgresql/src/test/modules/test_regex
Tom Lane b6312becc8 Avoid assertion due to disconnected NFA sub-graphs in regex parsing.
In commit 08c0d6ad6 which introduced "rainbow" arcs in regex NFAs,
I didn't think terribly hard about what to do when creating the color
complement of a rainbow arc.  Clearly, the complement cannot match any
characters, and I took the easy way out by just not building any arcs
at all in the complement arc set.  That mostly works, but Nikolay
Shaplov found a case where it doesn't: if we decide to delete that
sub-NFA later because it's inside a "{0}" quantifier, delsub()
suffered an assertion failure.  That's because delsub() relies on
the target sub-NFA being fully connected.  That was always true
before, and the best fix seems to be to restore that property.
Hence, invent a new arc type CANTMATCH that can be generated in
place of an empty color complement, and drop it again later when we
start NFA optimization.  (At that point we don't need to do delsub()
any more, and besides there are other cases where NFA optimization can
lead to disconnected subgraphs.)

It appears that this bug has no consequences in a non-assert-enabled
build: there will be some transiently leaked NFA states/arcs, but
they'll get cleaned up eventually.  Still, we don't like assertion
failures, so back-patch to v14 where rainbow arcs were introduced.

Per bug #18708 from Nikolay Shaplov.

Discussion: https://postgr.es/m/18708-f94f2599c9d2c005@postgresql.org
2024-11-15 18:23:38 -05:00
..
expected Avoid assertion due to disconnected NFA sub-graphs in regex parsing. 2024-11-15 18:23:38 -05:00
sql Avoid assertion due to disconnected NFA sub-graphs in regex parsing. 2024-11-15 18:23:38 -05:00
.gitignore Add a test module for the regular expression package. 2021-01-06 10:51:14 -05:00
Makefile Add a test module for the regular expression package. 2021-01-06 10:51:14 -05:00
meson.build meson: Prevent installation of test files during main install 2023-03-03 07:45:52 +01:00
README Add a test module for the regular expression package. 2021-01-06 10:51:14 -05:00
test_regex--1.0.sql Add a test module for the regular expression package. 2021-01-06 10:51:14 -05:00
test_regex.c Redesign interrupt/cancel API for regex engine. 2023-04-08 22:10:39 +12:00
test_regex.control Add a test module for the regular expression package. 2021-01-06 10:51:14 -05:00

test_regex is a module for testing the regular expression package.
It is mostly meant to allow us to absorb Tcl's regex test suite.
Therefore, there are provisions to exercise regex features that
aren't currently exposed at the SQL level by PostgreSQL.

Currently, one function is provided:

test_regex(pattern text, string text, flags text) returns setof text[]

Reports an error if the pattern is an invalid regex.  Otherwise,
the first row of output contains the number of subexpressions,
followed by words reporting set bit(s) in the regex's re_info field.
If the pattern doesn't match the string, that's all.
If the pattern does match, the next row contains the whole match
as the first array element.  If there are parenthesized subexpression(s),
following array elements contain the matches to those subexpressions.
If the "g" (glob) flag is set, then additional row(s) of output similarly
report any additional matches.

The "flags" argument is a string of zero or more single-character
flags that modify the behavior of the regex package or the test
function.  As described in Tcl's reg.test file:

The flag characters are complex and a bit eclectic.  Generally speaking,
lowercase letters are compile options, uppercase are expected re_info
bits, and nonalphabetics are match options, controls for how the test is
run, or testing options.  The one small surprise is that AREs are the
default, and you must explicitly request lesser flavors of RE.  The flags
are as follows.  It is admitted that some are not very mnemonic.

	-	no-op (placeholder)
	0	report indices not actual strings
		(This substitutes for Tcl's -indices switch)
	!	expect partial match, report start position anyway
	%	force small state-set cache in matcher (to test cache replace)
	^	beginning of string is not beginning of line
	$	end of string is not end of line
	*	test is Unicode-specific, needs big character set
	+	provide fake xy equivalence class and ch collating element
		(Note: the equivalence class is implemented, the
		collating element is not; so references to [.ch.] fail)
	,	set REG_PROGRESS (only useful in REG_DEBUG builds)
	.	set REG_DUMP (only useful in REG_DEBUG builds)
	:	set REG_MTRACE (only useful in REG_DEBUG builds)
	;	set REG_FTRACE (only useful in REG_DEBUG builds)

	&	test as both ARE and BRE
		(Not implemented in Postgres, we use separate tests)
	b	BRE
	e	ERE
	a	turn advanced-features bit on (error unless ERE already)
	q	literal string, no metacharacters at all

	g	global match (find all matches)
	i	case-independent matching
	o	("opaque") do not return match locations
	p	newlines are half-magic, excluded from . and [^ only
	w	newlines are half-magic, significant to ^ and $ only
	n	newlines are fully magic, both effects
	x	expanded RE syntax
	t	incomplete-match reporting
	c	canmatch (equivalent to "t0!", in Postgres implementation)
	s	match only at start (REG_BOSONLY)

	A	backslash-_a_lphanumeric seen
	B	ERE/ARE literal-_b_race heuristic used
	E	backslash (_e_scape) seen within []
	H	looka_h_ead constraint seen
	I	_i_mpossible to match
	L	_l_ocale-specific construct seen
	M	unportable (_m_achine-specific) construct seen
	N	RE can match empty (_n_ull) string
	P	non-_P_OSIX construct seen
	Q	{} _q_uantifier seen
	R	back _r_eference seen
	S	POSIX-un_s_pecified syntax seen
	T	prefers shortest (_t_iny)
	U	saw original-POSIX botch: unmatched right paren in ERE (_u_gh)