upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-04-15 22:10:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/contrib
History
Tom Lane e1aecebc04 Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. 
This patch essentially reverts commit 4c6780fd17, in favor of a much
simpler solution for the case where the new cluster would choose to create
a TOAST table but the old cluster doesn't have one: just don't create a
TOAST table.

The existing code failed in at least two different ways if the situation
arose: (1) ALTER TABLE RESET didn't grab an exclusive lock, so that the
lock sanity check in create_toast_table failed; (2) pg_upgrade did not
provide a pg_type OID for the new toast table, so that the crosscheck in
TypeCreate failed.  While both these problems were introduced by later
patches, they show that the hack being used to cause TOAST table creation
is overwhelmingly fragile (and untested).  I also note that before the
TypeCreate crosscheck was added, the code would have resulted in assigning
an indeterminate pg_type OID to the toast table, possibly causing a later
OID conflict in that catalog; so that it didn't really work even when
committed.

If we simply don't create a TOAST table, there will only be a problem if
the code tries to store a tuple that's wider than a page, and field
compression isn't sufficient to get it under a page.  Given that the TOAST
creation threshold is intended to be about a quarter of a page, it's very
hard to believe that cross-version differences in the do-we-need-a-toast-
table heuristic could result in an observable problem.  So let's just
follow the old version's conclusion about whether a TOAST table is needed.

(If we ever do change needs_toast_table() so much that this conclusion
doesn't apply, we can devise a solution at that time, and hopefully do
it in a less klugy way than 4c6780fd17 did.)

Back-patch to 9.3, like the previous patch.

Discussion: <8110.1462291671@sss.pgh.pa.us>
2016-05-06 22:05:51 -04:00
..
adminpack Create function prototype as part of PG_FUNCTION_INFO_V1 macro 2014-04-18 00:03:19 -04:00
auth_delay Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds. 2012-11-18 17:15:06 -05:00
auto_explain Print planning time only in EXPLAIN ANALYZE, not plain EXPLAIN. 2014-10-15 18:50:16 -04:00
btree_gin Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
btree_gist Fix misc typos. 2015-09-05 11:36:24 +03:00
chkpass Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:13 -05:00
citext Fix incorrect declaration of citext's regexp_matches() functions. 2015-05-05 15:50:53 -04:00
cube Fix misc typos. 2015-09-05 11:36:24 +03:00
dblink Fix volatile-safety issue in dblink's materializeQueryResult(). 2015-01-26 15:17:36 -05:00
dict_int Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
dict_xsyn Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
dummy_seclabel Update copyright for 2014 2014-01-07 16:05:30 -05:00
earthdistance Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
file_fdw Fix contrib/file_fdw's expected file 2015-03-06 11:47:09 -03:00
fuzzystrmatch Add missing va_end() call to a early exit in dmetaphone.c's StringAt(). 2015-01-04 15:35:46 +01:00
hstore Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. 2016-02-03 01:39:08 -05:00
intagg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
intarray Prevent stack overflow in query-type functions. 2015-10-05 10:06:34 -04:00
isn contrib/isn now needs a .gitignore file. 2015-08-02 23:57:47 -04:00
lo Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
ltree ltree: Zero padding bytes when allocating memory for externally visible data. 2016-03-08 14:59:29 -08:00
oid2name pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pageinspect Remove unused macros. 2016-05-02 10:09:01 +03:00
passwordcheck Update copyright for 2014 2014-01-07 16:05:30 -05:00
pg_archivecleanup pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pg_buffercache Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
pg_freespacemap Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
pg_prewarm Add interrupt checks to contrib/pg_prewarm. 2014-11-12 21:06:32 +01:00
pg_standby pg_standby: Avoid writing one byte beyond the end of the buffer. 2015-01-15 09:29:41 -05:00
pg_stat_statements Avoid unlikely data-loss scenarios due to rename() without fsync. 2016-03-09 18:53:54 -08:00
pg_test_fsync Avoid file descriptor leak in pg_test_fsync. 2014-11-19 12:13:14 -05:00
pg_test_timing Correctly handle test durations of more than 2147s in pg_test_timing. 2015-01-04 15:52:52 +01:00
pg_trgm Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:13 -05:00
pg_upgrade Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. 2016-05-06 22:05:51 -04:00
pg_upgrade_support Create function prototype as part of PG_FUNCTION_INFO_V1 macro 2014-04-18 00:03:19 -04:00
pg_xlogdump Sort $(wildcard) output where needed for reproducible build output. 2016-01-05 15:47:05 -05:00
pgbench Fix "pg_bench -C -M prepared". 2016-03-16 23:18:07 -04:00
pgcrypto Add forgotten CHECK_FOR_INTERRUPT calls in pgcrypto's crypt() 2015-12-27 13:03:19 -03:00
pgrowlocks Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
pgstattuple Remove unused macros. 2016-05-02 10:09:01 +03:00
postgres_fdw postgres_fdw: Avoid possible misbehavior when RETURNING tableoid column only. 2016-02-04 22:27:47 -05:00
seg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
sepgsql Fix sepgsql regression tests. 2015-08-30 11:09:31 -07:00
spi Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
sslinfo Fix error message wording in previous sslinfo commit 2015-09-08 11:10:20 -03:00
start-scripts doc: Reflect renaming of Mac OS X to OS X 2014-09-09 13:58:50 -04:00
tablefunc Handle unexpected query results, especially NULLs, safely in connectby(). 2015-01-29 20:18:37 -05:00
tcn pgindent run for 9.4 2014-05-06 12:12:18 -04:00
test_decoding Fix core dump in ReorderBufferRestoreChange on alignment-picky platforms. 2016-04-14 19:42:22 -04:00
test_parser Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
test_shm_mq pgindent run for 9.4 2014-05-06 12:12:18 -04:00
tsearch2 Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
unaccent Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
uuid-ossp Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:28 +02:00
vacuumlo Centralize getopt-related declarations in a new header file pg_getopt.h. 2014-02-15 14:31:30 -05:00
worker_spi worker_spi: Initialize bgw_notify_pid in all cases. 2014-05-26 22:56:28 -04:00
xml2 Free libxml2/libxslt resources in a safer order. 2014-11-27 11:12:47 -05:00
contrib-global.mk Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
Makefile Support BSD and e2fsprogs UUID libraries alongside OSSP UUID library. 2014-05-27 19:42:08 -04:00
README Rename 'gmake' to 'make' in docs and recommended commands 2014-02-12 17:29:19 -05:00

README 

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.