Tom Lane 48b319e876 Fix more confusion in SP-GiST. ... spg_box_quad_leaf_consistent unconditionally returned the leaf datum as leafValue, even though in its usage for poly_ops that value is of completely the wrong type. In versions before 12, that was harmless because the core code did nothing with leafValue in non-index-only scans ... but since commit 2a6368343, if we were doing a KNN-style scan, spgNewHeapItem would unconditionally try to copy the value using the wrong datatype parameters. Said copying is a waste of time and space if we're not going to return the data, but it accidentally failed to fail until I fixed the datatype confusion in ac9099fc1. Hence, change spgNewHeapItem to not copy the datum unless we're actually going to return it later. This saves cycles and dodges the question of whether lossy opclasses are returning the right type. Also change spg_box_quad_leaf_consistent to not return data that might be of the wrong type, as insurance against somebody introducing a similar bug into the core code in future. It seems like a good idea to back-patch these two changes into v12 and v13, although I'm afraid to change spgNewHeapItem's mistaken idea of which datatype to use in those branches. Per buildfarm results from ac9099fc1. Discussion: https://postgr.es/m/3728741.1617381471@sss.pgh.pa.us		2021-04-04 17:57:07 -04:00
..
backend	Fix more confusion in SP-GiST.	2021-04-04 17:57:07 -04:00
bin	pg_checksums: Fix progress reporting.	2021-04-03 00:08:05 +09:00
common	Fix command-line colorization on Windows with VT100-compatible environments	2020-03-02 15:46:24 +09:00
fe_utils	Fix parallel restore of FKs to partitioned tables	2019-10-17 09:58:01 +02:00
include	Use correct spelling of statistics kind	2021-03-23 04:57:45 +01:00
interfaces	Use macro MONTHS_PER_YEAR instead of '12' in /ecpg/pgtypeslib	2021-04-02 16:42:29 -04:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:35 -04:00
pl	Translation updates	2021-02-08 17:50:22 +01:00
port	pg_attribute_no_sanitize_alignment() macro	2021-02-13 17:49:08 -05:00
template	Further tweaking of PG_SYSROOT heuristics for macOS.	2021-01-20 12:07:35 -05:00
test	Improve stability of test with vacuum_truncate in reloptions.sql	2021-04-02 09:44:54 +09:00
timezone	Update time zone data files to tzdata release 2021a.	2021-01-24 16:29:47 -05:00
tools	backpatch "jit: Add support for LLVM 12."	2020-12-07 18:39:32 -08:00
tutorial	tutorial: land height is "elevation", not "altitude"	2021-03-10 20:25:18 -05:00
.gitignore
DEVELOPERS
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:35 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	NLS: Fix backend gettext triggers	2019-09-23 09:05:50 +02:00