mirror of
https://github.com/postgres/postgres.git
synced 2026-03-10 02:01:23 -04:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
89 lines
3.4 KiB
C
89 lines
3.4 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* event_trigger.h
|
|
* Declarations for command trigger handling.
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/commands/event_trigger.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef EVENT_TRIGGER_H
|
|
#define EVENT_TRIGGER_H
|
|
|
|
#include "catalog/dependency.h"
|
|
#include "catalog/objectaddress.h"
|
|
#include "catalog/pg_event_trigger.h"
|
|
#include "nodes/parsenodes.h"
|
|
#include "utils/aclchk_internal.h"
|
|
#include "tcop/deparse_utility.h"
|
|
|
|
typedef struct EventTriggerData
|
|
{
|
|
NodeTag type;
|
|
const char *event; /* event name */
|
|
Node *parsetree; /* parse tree */
|
|
const char *tag; /* command tag */
|
|
} EventTriggerData;
|
|
|
|
#define AT_REWRITE_ALTER_PERSISTENCE 0x01
|
|
#define AT_REWRITE_DEFAULT_VAL 0x02
|
|
#define AT_REWRITE_COLUMN_REWRITE 0x04
|
|
#define AT_REWRITE_ALTER_OID 0x08
|
|
|
|
/*
|
|
* EventTriggerData is the node type that is passed as fmgr "context" info
|
|
* when a function is called by the event trigger manager.
|
|
*/
|
|
#define CALLED_AS_EVENT_TRIGGER(fcinfo) \
|
|
((fcinfo)->context != NULL && IsA((fcinfo)->context, EventTriggerData))
|
|
|
|
extern Oid CreateEventTrigger(CreateEventTrigStmt *stmt);
|
|
extern void RemoveEventTriggerById(Oid ctrigOid);
|
|
extern Oid get_event_trigger_oid(const char *trigname, bool missing_ok);
|
|
|
|
extern Oid AlterEventTrigger(AlterEventTrigStmt *stmt);
|
|
extern ObjectAddress AlterEventTriggerOwner(const char *name, Oid newOwnerId);
|
|
extern void AlterEventTriggerOwner_oid(Oid, Oid newOwnerId);
|
|
|
|
extern bool EventTriggerSupportsObjectType(ObjectType obtype);
|
|
extern bool EventTriggerSupportsObjectClass(ObjectClass objclass);
|
|
extern bool EventTriggerSupportsGrantObjectType(GrantObjectType objtype);
|
|
extern void EventTriggerDDLCommandStart(Node *parsetree);
|
|
extern void EventTriggerDDLCommandEnd(Node *parsetree);
|
|
extern void EventTriggerSQLDrop(Node *parsetree);
|
|
extern void EventTriggerTableRewrite(Node *parsetree, Oid tableOid, int reason);
|
|
|
|
extern bool EventTriggerBeginCompleteQuery(void);
|
|
extern void EventTriggerEndCompleteQuery(void);
|
|
extern bool trackDroppedObjectsNeeded(void);
|
|
extern void EventTriggerSQLDropAddObject(const ObjectAddress *object,
|
|
bool original, bool normal);
|
|
|
|
extern void EventTriggerInhibitCommandCollection(void);
|
|
extern void EventTriggerUndoInhibitCommandCollection(void);
|
|
|
|
extern void EventTriggerCollectSimpleCommand(ObjectAddress address,
|
|
ObjectAddress secondaryObject,
|
|
Node *parsetree);
|
|
|
|
extern void EventTriggerAlterTableStart(Node *parsetree);
|
|
extern void EventTriggerAlterTableRelid(Oid objectId);
|
|
extern void EventTriggerCollectAlterTableSubcmd(Node *subcmd,
|
|
ObjectAddress address);
|
|
extern void EventTriggerAlterTableEnd(void);
|
|
|
|
extern void EventTriggerCollectGrant(InternalGrant *istmt);
|
|
extern void EventTriggerCollectAlterOpFam(AlterOpFamilyStmt *stmt,
|
|
Oid opfamoid, List *operators,
|
|
List *procedures);
|
|
extern void EventTriggerCollectCreateOpClass(CreateOpClassStmt *stmt,
|
|
Oid opcoid, List *operators,
|
|
List *procedures);
|
|
extern void EventTriggerCollectAlterTSConfig(AlterTSConfigurationStmt *stmt,
|
|
Oid cfgId, Oid *dictIds, int ndicts);
|
|
extern void EventTriggerCollectAlterDefPrivs(AlterDefaultPrivilegesStmt *stmt);
|
|
|
|
#endif /* EVENT_TRIGGER_H */
|