postgresql

mirror of https://github.com/postgres/postgres.git synced 2026-05-13 18:03:10 -04:00

History

Heikki Linnakangas c3c284b379 Fix another bug in parent page splitting during GiST index build. Yet another bug in the ilk of commits `a7ee7c851` and `741b88435`. In `741b88435`, we took care to clear the memorized location of the downlink when we split the parent page, because splitting the parent page can move the downlink. But we missed that even updating a tuple on the parent can move it, because updating a tuple on a gist page is implemented as a delete+insert, so the updated tuple gets moved to the end of the page. This commit fixes the bug in two different ways (belt and suspenders): 1. Clear the downlink when we update a tuple on the parent page, even if it's not split. This the same approach as in commits `a7ee7c851` and `741b88435`. I also noticed that gistFindCorrectParent did not clear the 'downlinkoffnum' when it stepped to the right sibling. Fix that too, as it seems like a clear bug even though I haven't been able to find a test case to hit that. 2. Change gistFindCorrectParent so that it treats 'downlinkoffnum' merely as a hint. It now always first checks if the downlink is still at that location, and if not, it scans the page like before. That's more robust if there are still more cases where we fail to clear 'downlinkoffnum' that we haven't yet uncovered. With this, it's no longer necessary to meticulously clear 'downlinkoffnum', so this makes the previous fixes unnecessary, but I didn't revert them because it still seems nice to clear it when we know that the downlink has moved. Also add the test case using the same test data that Alexander posted. I tried to reduce it to a smaller test, and I also tried to reproduce this with different test data, but I was not able to, so let's just include what we have. Backpatch to v12, like the previous fixes. Reported-by: Alexander Lakhin Discussion: https://www.postgresql.org/message-id/18129-caca016eaf0c3702@postgresql.org		2023-09-26 14:15:19 +03:00
..
adminpack
amcheck	amcheck: In verify_heapam, allows tuples with xmin 0.	2023-03-28 16:17:03 -04:00
auth_delay
auto_explain
basebackup_to_shell	basebackup_to_shell: Check for a NULL return from OpenPipeStream.	2023-04-12 11:51:09 -04:00
basic_archive
bloom	If wait_for_catchup fails under has_wal_read_bug, skip balance of test.	2022-11-12 11:19:56 -08:00
bool_plperl
btree_gin
btree_gist
citext
cube
dblink
dict_int
dict_xsyn
earthdistance
file_fdw
fuzzystrmatch	Ensure Soundex difference() function handles empty input sanely.	2023-05-16 10:53:42 -04:00
hstore	hstore: Tighten key/value parsing check for whitespaces	2023-06-12 09:14:13 +09:00
hstore_plperl
hstore_plpython	In hstore_plpython, avoid crashing when return value isn't a mapping.	2023-04-27 11:55:06 -04:00
intagg
intarray	Fix another bug in parent page splitting during GiST index build.	2023-09-26 14:15:19 +03:00
isn
jsonb_plperl
jsonb_plpython
lo
ltree	Validate ltree siglen GiST option to be int-aligned	2023-04-23 14:30:51 +03:00
ltree_plpython
oid2name
old_snapshot
pageinspect	pageinspect: Fix gist_page_items() with included columns	2023-05-19 12:38:15 +09:00
passwordcheck
pg_buffercache
pg_freespacemap
pg_prewarm
pg_stat_statements	pg_stat_statements: Fix second comment related to entry resets	2023-06-29 09:17:30 +09:00
pg_surgery
pg_trgm	Fix misbehavior in contrib/pg_trgm with an unsatisfiable regex.	2023-03-11 12:15:41 -05:00
pg_visibility
pg_walinspect	Limit memory usage of pg_walinspect functions.	2023-02-20 11:29:31 -08:00
pgcrypto
pgrowlocks
pgstattuple
postgres_fdw	postgres_fdw: Fix test for parameterized foreign scan.	2023-08-30 17:15:03 +09:00
seg	Replace last PushOverrideSearchPath() call with set_config_option().	2023-05-08 06:14:11 -07:00
sepgsql	Adjust sepgsql expected output for `681d9e462` et al.	2023-05-08 11:24:47 -04:00
spi
sslinfo
start-scripts
tablefunc
tcn
test_decoding	Make test_decoding ddl.out shorter	2023-07-24 17:48:06 +02:00
tsm_system_rows
tsm_system_time
unaccent
uuid-ossp
vacuumlo
xml2
contrib-global.mk
Makefile
README

README

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.