postgresql/contrib/file_fdw
Amit Langote 6d2fa44d2a Fix bogus ctid requirement for dummy-root partitioned targets
ExecInitModifyTable() unconditionally required a ctid junk column even
when the target was a partitioned table. This led to spurious "could
not find junk ctid column" errors when all children were excluded and
only the dummy root result relation remained.

A partitioned table only appears in the result relations list when all
leaf partitions have been pruned, leaving the dummy root as the sole
entry. Assert this invariant (nrels == 1) and skip the ctid requirement.
Also adjust ExecModifyTable() to tolerate invalid ri_RowIdAttNo for
partitioned tables, which is safe since no rows will be processed in
this case.

Bug: #19099
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Amit Langote <amitlangote09@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/19099-e05dcfa022fe553d%40postgresql.org
Backpatch-through: 14
2026-01-23 10:23:10 +09:00
..
data pg_prewarm: Add automatic prewarm feature. 2017-08-21 14:17:39 -04:00
expected Add contrib/file_fdw foreign-data wrapper for reading files via COPY. 2011-02-20 14:06:59 -05:00
input Fix bogus ctid requirement for dummy-root partitioned targets 2026-01-23 10:23:10 +09:00
output Fix bogus ctid requirement for dummy-root partitioned targets 2026-01-23 10:23:10 +09:00
sql Add contrib/file_fdw foreign-data wrapper for reading files via COPY. 2011-02-20 14:06:59 -05:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
file_fdw--1.0.sql Throw a useful error message if an extension script file is fed to psql. 2011-10-12 15:45:03 -04:00
file_fdw.c Rename Default Roles to Predefined Roles 2021-04-01 15:32:06 -04:00
file_fdw.control Add contrib/file_fdw foreign-data wrapper for reading files via COPY. 2011-02-20 14:06:59 -05:00
Makefile Add file version information to most installed Windows binaries. 2014-07-14 14:07:52 -04:00