postgresql/contrib/pg_stat_statements/sql
Álvaro Herrera 0f65f3eec4
Fix squashing algorithm for query texts
The algorithm to squash lists of constants added by commit 62d712ecfd
was a bit too simplistic; we wanted to avoid adding unnecessary
complexity, but cases like direct function calls of typecasting
functions (and others) were missed, and bogus SQL syntax was being shown
in pg_stat_statements normalized query text field.  To fix normalization
for those cases, we need the parser to transmit information about were
each list of constant values starts and ends, so add that to a couple of
nodes.  Also add a few more test cases to make sure we're doing the
right thing.

The patch initially submitted by Sami added a new private struct in
gram.y to carry the start/end information for A_Expr, but I (Álvaro)
decided that a better fix was to remove the parser indirection via the
in_expr production, and instead create separate components in the a_expr
rule.  I'm surprised that this works and doesn't require more changes,
but I assume (without checking) that the grammar used to be more complex
and got simplified at some point.

Bump catversion.

Author: Sami Imseih <samimseih@gmail.com>
Author: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CAA5RZ0tRXoPG2y6bMgBCWNDt0Tn=unRerbzYM=oW0syi1=C1OA@mail.gmail.com
2025-06-12 14:21:21 +02:00
..
cleanup.sql Refactor tests of pg_stat_statements for planning, utility and level tracking 2023-02-20 09:28:29 +09:00
cursors.sql Add NOT NULL checking of pg_stat_statements_reset() in tests 2023-11-27 02:52:17 +02:00
dml.sql Add NOT NULL checking of pg_stat_statements_reset() in tests 2023-11-27 02:52:17 +02:00
entry_timestamp.sql Track statement entry timestamp in contrib/pg_stat_statements 2023-11-27 02:52:17 +02:00
extended.sql pg_stat_statements: Fix parameter number gaps in normalized queries 2025-05-29 11:26:03 +09:00
level_tracking.sql Fix regression with location calculation of nested statements 2025-05-21 10:22:12 +09:00
oldextversions.sql pg_stat_statements: Add columns to track parallel worker activity 2024-10-09 08:30:45 +09:00
parallel.sql pg_stat_statements: Add columns to track parallel worker activity 2024-10-09 08:30:45 +09:00
planning.sql Revert support for improved tracking of nested queries 2025-06-12 10:08:55 +09:00
privileges.sql pg_stat_statements: Add regression test for privilege handling. 2024-07-24 20:54:51 +09:00
select.sql Fix squashing algorithm for query texts 2025-06-12 14:21:21 +02:00
squashing.sql Fix squashing algorithm for query texts 2025-06-12 14:21:21 +02:00
user_activity.sql Add NOT NULL checking of pg_stat_statements_reset() in tests 2023-11-27 02:52:17 +02:00
utility.sql pg_stat_statements: Expand tests for SET statements 2024-09-25 10:04:44 +09:00
wal.sql Add NOT NULL checking of pg_stat_statements_reset() in tests 2023-11-27 02:52:17 +02:00