postgresql/src
Bruce Momjian 0059c4216c >Well, if it is that easy, I can do it. Patch attached and applied.
>
>> On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:
>>     public boolean isWritable(int column) throws SQLException
>>     {
>>         return !isReadOnly(column);
>>     }

Actually, I think this change has a consequence for this method
in the same class:

    public boolean isDefinitelyWritable(int column)
        throws SQLException
    {
        return isWritable(column);
    }

This is from the JDBC spec
(http://java.sun.com/j2se/1.3/docs/api/java/sql/ResultSetMetaData.html):

  isReadOnly() - Indicates whether the designated column is
definitely not writable.

  isWritable() - Indicates whether it is possible for a write on
the designated column to succeed.

  isDefinitelyWritable() - Indicates whether a write on the
designated column will definitely succeed.

At this time we don't really implement the fine semantics of
these methods. I would suggest the following defaults:

  isReadOnly()             false
  isWritable()             true
  isDefinitelyWritable()   false

And that would mean that your patch is correct, but
isDefinitelyWritable() would need to be patched accordingly:

    public boolean isDefinitelyWritable(int column)
        throws SQLException
    {
        return false;
    }

Again, both in jdbc1 and jdbc2.

Regards,
Ren? Pijlman <rene@lab.applinet.nl>
2001-09-06 20:43:39 +00:00
..
backend Commit Karel's patch. 2001-09-06 04:57:30 +00:00
bin Russian translation from Serguei Mokhov 2001-09-06 11:10:47 +00:00
corba Convert files from DOS format to normal text. 2000-12-03 14:43:59 +00:00
data I've sent 3 mails to pgsql-patches. There are two files, one for doc 1999-08-16 20:27:19 +00:00
include Commit Karel's patch. 2001-09-06 04:57:30 +00:00
interfaces >Well, if it is that easy, I can do it. Patch attached and applied. 2001-09-06 20:43:39 +00:00
makefiles Add -rpath for BSD/OS, from Peter E. 2001-09-06 13:43:42 +00:00
pl Next version of patch. 2001-09-06 02:56:32 +00:00
template 0 -> O 2001-08-08 13:30:20 +00:00
test Fix handling of pg_type.typdefault per bug report from Dave Blasby. 2001-09-06 02:07:42 +00:00
tools Add back incremental patch for BSD indent. 2001-09-04 03:34:42 +00:00
tutorial New blood and fresh air for tutorial 2001-09-02 23:27:50 +00:00
utils pgindent run. Make it all clean. 2001-03-22 04:01:46 +00:00
DEVELOPERS just testing a script... 1999-07-30 03:45:57 +00:00
GNUmakefile.in Restructure the key include files per recent pghackers discussion: there 2001-02-10 02:31:31 +00:00
Makefile Restructure the key include files per recent pghackers discussion: there 2001-02-10 02:31:31 +00:00
Makefile.global.in Install the SQL command man pages into a section appropriate for each 2001-08-29 19:14:40 +00:00
Makefile.shlib Shared libraries should not be linked explicitly against -lc on FreeBSD 2001-06-20 20:25:11 +00:00
nls-global.mk Change xgettext rule to run in the source tree, so we don't have the 2001-07-15 11:43:55 +00:00
win32.mak Missed this part in pg_config.h rename. 2001-08-24 22:42:28 +00:00