upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-06-11 01:30:11 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pg_upgrade: Fix detection of invalid logical replication slots.

Browse source 
Commit 7a1f0f8747 optimized the slot verification query but
overlooked cases where all logical replication slots are already
invalidated. In this scenario, the CTE returns no rows, causing the
main query (which used a cross join) to return an empty result even
when invalid slots exist.

This commit fixes this by using a LEFT JOIN with the CTE, ensuring
that slots are properly reported even if the CTE returns no rows.

Author: Lakshmi N <lakshmin.jhs@gmail.com>
Reviewed-by: Shveta Malik <shveta.malik@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CA+3i_M8eT6j8_cBHkYykV-SXCxbmAxpVSKptjDVq+MFtpT-Paw@mail.gmail.com
This commit is contained in:
Masahiko Sawada 2026-04-22 09:59:46 -07:00
parent d14f69a32a
commit e471dc5912
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/bin/pg_upgrade/info.c
View file

@ -743,7 +743,8 @@ get_old_cluster_logical_slot_infos_query(ClusterInfo *cluster)
" confirmed_flush_lsn > last_pending_wal "
"END as caught_up, "
"invalidation_reason IS NOT NULL as invalid "
"FROM pg_catalog.pg_replication_slots, check_caught_up "
"FROM pg_catalog.pg_replication_slots "
"LEFT JOIN check_caught_up ON true "
"WHERE slot_type = 'logical' AND "
"database = current_database() AND "
"temporary IS FALSE ";